From 0ceba92a230cf3d22a25019387bb90789eed878e Mon Sep 17 00:00:00 2001 From: bbedward Date: Fri, 16 Jan 2026 09:44:03 -0500 Subject: [PATCH] i18n: more RTL fixes across settings --- quickshell/Modules/Settings/DockTab.qml | 9 +++++++++ .../Settings/Widgets/SettingsToggleCard.qml | 3 +++ quickshell/Modules/Settings/WorkspacesTab.qml | 15 ++++++++------- 3 files changed, 20 insertions(+), 7 deletions(-) diff --git a/quickshell/Modules/Settings/DockTab.qml b/quickshell/Modules/Settings/DockTab.qml index ed343560..59789997 100644 --- a/quickshell/Modules/Settings/DockTab.qml +++ b/quickshell/Modules/Settings/DockTab.qml @@ -29,6 +29,9 @@ Item { SettingsButtonGroupRow { text: I18n.tr("Position") model: ["Top", "Bottom", "Left", "Right"] + buttonPadding: Theme.spacingS + minButtonWidth: 44 + textSize: Theme.fontSizeSmall currentIndex: { switch (SettingsData.dockPosition) { case SettingsData.Position.Top: @@ -129,6 +132,9 @@ Item { tags: ["dock", "indicator", "style", "circle", "line"] text: I18n.tr("Indicator Style") model: ["Circle", "Line"] + buttonPadding: Theme.spacingS + minButtonWidth: 44 + textSize: Theme.fontSizeSmall currentIndex: SettingsData.dockIndicatorStyle === "circle" ? 0 : 1 onSelectionChanged: (index, selected) => { if (selected) { @@ -225,6 +231,9 @@ Item { description: I18n.tr("Choose the border accent color") visible: SettingsData.dockBorderEnabled model: ["Surface", "Secondary", "Primary"] + buttonPadding: Theme.spacingS + minButtonWidth: 44 + textSize: Theme.fontSizeSmall currentIndex: { switch (SettingsData.dockBorderColor) { case "surfaceText": diff --git a/quickshell/Modules/Settings/Widgets/SettingsToggleCard.qml b/quickshell/Modules/Settings/Widgets/SettingsToggleCard.qml index 11353b6f..e0be6a07 100644 --- a/quickshell/Modules/Settings/Widgets/SettingsToggleCard.qml +++ b/quickshell/Modules/Settings/Widgets/SettingsToggleCard.qml @@ -51,6 +51,7 @@ StyledRect { Row { spacing: Theme.spacingM + width: parent.width DankIcon { id: headerIcon @@ -69,6 +70,8 @@ StyledRect { color: Theme.surfaceText anchors.verticalCenter: parent.verticalCenter visible: root.title !== "" + width: parent.width - (headerIcon.visible ? headerIcon.width + parent.spacing : 0) + horizontalAlignment: Text.AlignLeft } } diff --git a/quickshell/Modules/Settings/WorkspacesTab.qml b/quickshell/Modules/Settings/WorkspacesTab.qml index 6eccab82..c57e4b5b 100644 --- a/quickshell/Modules/Settings/WorkspacesTab.qml +++ b/quickshell/Modules/Settings/WorkspacesTab.qml @@ -63,15 +63,15 @@ Item { onToggled: checked => SettingsData.set("showWorkspaceApps", checked) } - Row { - width: parent.width - Theme.spacingL - spacing: Theme.spacingL + Item { + width: parent.width + height: maxAppsColumn.height visible: SettingsData.showWorkspaceApps opacity: visible ? 1 : 0 - anchors.left: parent.left - anchors.leftMargin: Theme.spacingL Column { + id: maxAppsColumn + x: Theme.spacingL width: 120 spacing: Theme.spacingS @@ -80,14 +80,15 @@ Item { font.pixelSize: Theme.fontSizeSmall color: Theme.surfaceText font.weight: Font.Medium + horizontalAlignment: Text.AlignLeft } DankTextField { width: 100 height: 28 - placeholderText: "#ffffff" + placeholderText: "3" text: SettingsData.maxWorkspaceIcons - maximumLength: 7 + maximumLength: 2 font.pixelSize: Theme.fontSizeSmall topPadding: Theme.spacingXS bottomPadding: Theme.spacingXS