From 132e7992653c9148ced97300ce8d6c4dc9e2fec5 Mon Sep 17 00:00:00 2001
From: bbedward <bbedward@gmail.com>
Date: Wed, 21 Jan 2026 09:18:51 -0500
Subject: [PATCH] Revert "settings: fix modal not opening on latest quickshell
 (#1357)"

This reverts commit bdd01e335d1e03c3a140a648e5918ecc6e6b2ac8.
---
 quickshell/DMSShell.qml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/quickshell/DMSShell.qml b/quickshell/DMSShell.qml
index c1ff1d81..1462ffc6 100644
--- a/quickshell/DMSShell.qml
+++ b/quickshell/DMSShell.qml
@@ -474,15 +474,17 @@ Item {
             PopoutService.settingsModalLoader = settingsModalLoader;
         }
 
+        onActiveChanged: {
+            if (active && item) {
+                PopoutService.settingsModal = item;
+                PopoutService._onSettingsModalLoaded();
+            }
+        }
+
         SettingsModal {
             id: settingsModal
             property bool wasShown: false
 
-            Component.onCompleted: {
-                PopoutService.settingsModal = settingsModal;
-                PopoutService._onSettingsModalLoaded();
-            }
-
             onVisibleChanged: {
                 if (visible) {
                     wasShown = true;