Refactor pre-commit hooks to use prek (#976)

* ci: change to prek for pre-commit

* refactor: fix shellcheck warnings for the scripts

* chore: unify whitespace formatting

* nix: add prek to dev shell

.github/ISSUE_TEMPLATE/bug_report.md

@@ -6,7 +6,7 @@ labels: "bug"
 assignees: ""
 ---
 
-<!-- If your issue is related to ICONS 
+<!-- If your issue is related to ICONS
 - Purple and black checkerboards are QT's way of signalling an icon doesn't exist
   - FIX: Configure a QT6 or Icon Pack in DMS Settings that has the icon you want
   - Follow the [THEMING](https://danklinux.com/docs/dankmaterialshell/icon-theming) section to ensure your QT environment variable is configured correctly for themes.
@@ -62,4 +62,4 @@ Paste error messages or logs here
 
 ## Screenshots/Recordings
 
-<!-- If applicable, add screenshots or screen recordings -->
+<!-- If applicable, add screenshots or screen recordings -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -30,4 +30,4 @@ Is this feature specific to one compositor?
 
 ## Alternatives/Existing Solutions
 
-<!-- Include any similar/pre-existing products that solve this problem -->
+<!-- Include any similar/pre-existing products that solve this problem -->

.github/ISSUE_TEMPLATE/support_request.md

@@ -37,4 +37,4 @@ assignees: ""
 
 ## Screenshots/Recordings
 
-<!-- If applicable, add screenshots or screen recordings -->
+<!-- If applicable, add screenshots or screen recordings -->

.github/workflows/go-ci.yml

@@ -33,20 +33,6 @@ jobs:
         with:
           go-version-file: ./core/go.mod
 
-      - name: Format check
-        run: |
-          if [ "$(gofmt -s -l . | wc -l)" -gt 0 ]; then
-            echo "The following files are not formatted:"
-            gofmt -s -l .
-            exit 1
-          fi
-
-      - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v9
-        with:
-          version: v2.6
-          working-directory: core
-
       - name: Test
         run: go test -v ./...
 

.github/workflows/prek.yml

@@ -0,0 +1,15 @@
+name: Pre-commit Checks
+
+on:
+  push:
+  pull_request:
+    branches: [master, main]
+jobs:
+  pre-commit-check:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: run pre-commit hooks
+        uses: j178/prek-action@v1

.github/workflows/release.yml

@@ -272,7 +272,7 @@ jobs:
           # Create QML source package (exclude build artifacts and git files)
           # Copy root LICENSE and CONTRIBUTING.md to quickshell/ for packaging
           cp LICENSE CONTRIBUTING.md quickshell/
-          
+
           # Copy root assets directory to quickshell for systemd service and desktop file
           cp -r assets quickshell/
 

.github/workflows/run-copr.yml

@@ -19,7 +19,7 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-      
+
       - name: Determine version
         id: version
         run: |
@@ -40,31 +40,31 @@ jobs:
           echo "version=$VERSION" >> $GITHUB_OUTPUT
           echo "release=$RELEASE" >> $GITHUB_OUTPUT
           echo "✅ Building DMS hotfix version: $VERSION-$RELEASE"
-      
+
       - name: Setup build environment
         run: |
           sudo apt-get update
           sudo apt-get install -y rpm wget curl jq gzip
           mkdir -p ~/rpmbuild/{BUILD,BUILDROOT,RPMS,SOURCES,SPECS,SRPMS}
           echo "✅ RPM build environment ready"
-      
+
       - name: Download release assets
         run: |
           VERSION="${{ steps.version.outputs.version }}"
           cd ~/rpmbuild/SOURCES
-          
+
           echo "📦 Downloading DMS QML source for v${VERSION}..."
-          
+
           # Download DMS QML source
           wget "https://github.com/AvengeMedia/DankMaterialShell/releases/download/v${VERSION}/dms-qml.tar.gz" || {
             echo "❌ Failed to download dms-qml.tar.gz for v${VERSION}"
             exit 1
           }
-          
+
           echo "✅ Source downloaded"
           echo "Note: dms-cli binary will be downloaded during build based on target architecture"
           ls -lh
-      
+
       - name: Generate stable spec file
         run: |
           VERSION="${{ steps.version.outputs.version }}"
@@ -211,38 +211,38 @@ jobs:
           echo ""
           echo "=== Spec file preview ==="
           head -40 ~/rpmbuild/SPECS/dms.spec
-      
+
       - name: Build SRPM
         id: build
         run: |
           cd ~/rpmbuild/SPECS
-          
+
           echo "🔨 Building SRPM..."
           rpmbuild -bs dms.spec
-          
+
           SRPM=$(ls ~/rpmbuild/SRPMS/*.src.rpm | tail -n 1)
           SRPM_NAME=$(basename "$SRPM")
-          
+
           echo "srpm_path=$SRPM" >> $GITHUB_OUTPUT
           echo "srpm_name=$SRPM_NAME" >> $GITHUB_OUTPUT
-          
+
           echo "✅ SRPM built: $SRPM_NAME"
           echo ""
           echo "=== SRPM Info ==="
           rpm -qpi "$SRPM"
-      
+
       - name: Upload SRPM artifact
         uses: actions/upload-artifact@v4
         with:
           name: dms-stable-srpm-${{ steps.version.outputs.version }}
           path: ${{ steps.build.outputs.srpm_path }}
           retention-days: 90
-      
+
       - name: Install Copr CLI
         run: |
           sudo apt-get install -y python3-pip
           pip3 install copr-cli
-          
+
           mkdir -p ~/.config
           cat > ~/.config/copr << EOF
           [copr-cli]
@@ -252,30 +252,30 @@ jobs:
           copr_url = https://copr.fedorainfracloud.org
           EOF
           chmod 600 ~/.config/copr
-          
+
           echo "✅ Copr CLI configured"
-      
+
       - name: Upload to Copr
         run: |
           SRPM="${{ steps.build.outputs.srpm_path }}"
           VERSION="${{ steps.version.outputs.version }}"
-          
+
           echo "🚀 Uploading SRPM to avengemedia/dms..."
           echo "   SRPM: $(basename $SRPM)"
           echo "   Version: $VERSION"
-          
+
           BUILD_OUTPUT=$(copr-cli build avengemedia/dms "$SRPM" --nowait 2>&1)
           echo "$BUILD_OUTPUT"
-          
+
           BUILD_ID=$(echo "$BUILD_OUTPUT" | grep -oP 'Build was added to.*\K[0-9]+' || echo "unknown")
-          
+
           if [ "$BUILD_ID" != "unknown" ]; then
             echo "✅ Build submitted successfully!"
             echo "🔗 https://copr.fedorainfracloud.org/coprs/avengemedia/dms/build/$BUILD_ID/"
           else
             echo "⚠️  Could not extract build ID, but upload may have succeeded"
           fi
-      
+
       - name: Build summary
         if: always()
         run: |

.github/workflows/run-obs.yml

@@ -21,34 +21,34 @@ jobs:
   check-updates:
     name: Check for updates
     runs-on: ubuntu-latest
-    
+
     outputs:
       has_updates: ${{ steps.check.outputs.has_updates }}
       packages: ${{ steps.check.outputs.packages }}
       version: ${{ steps.check.outputs.version }}
-    
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      
+
       - name: Install OSC
         run: |
           sudo apt-get update
           sudo apt-get install -y osc
-          
+
           mkdir -p ~/.config/osc
           cat > ~/.config/osc/oscrc << EOF
           [general]
           apiurl = https://api.opensuse.org
-          
+
           [https://api.opensuse.org]
           user = ${{ secrets.OBS_USERNAME }}
           pass = ${{ secrets.OBS_PASSWORD }}
           EOF
           chmod 600 ~/.config/osc/oscrc
-      
+
       - name: Check for updates
         id: check
         run: |
@@ -116,13 +116,13 @@ jobs:
     if: |
       github.event_name == 'workflow_dispatch' ||
       needs.check-updates.outputs.has_updates == 'true'
-    
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      
+
       - name: Determine packages to update
         id: packages
         run: |
@@ -140,7 +140,7 @@ jobs:
           else
             echo "packages=${{ needs.check-updates.outputs.packages }}" >> $GITHUB_OUTPUT
           fi
-      
+
       - name: Update dms-git spec version
         if: contains(steps.packages.outputs.packages, 'dms-git') || steps.packages.outputs.packages == 'all'
         run: |
@@ -148,13 +148,13 @@ jobs:
           COMMIT_HASH=$(git rev-parse --short=8 HEAD)
           COMMIT_COUNT=$(git rev-list --count HEAD)
           BASE_VERSION=$(grep -oP '^Version:\s+\K[0-9.]+' distro/opensuse/dms.spec | head -1 || echo "0.6.2")
-          
+
           NEW_VERSION="${BASE_VERSION}+git${COMMIT_COUNT}.${COMMIT_HASH}"
           echo "📦 Updating dms-git.spec to version: $NEW_VERSION"
-          
+
           # Update version in spec
           sed -i "s/^Version:.*/Version:        $NEW_VERSION/" distro/opensuse/dms-git.spec
-          
+
           # Add changelog entry
           DATE_STR=$(date "+%a %b %d %Y")
           CHANGELOG_ENTRY="* $DATE_STR Avenge Media <AvengeMedia.US@gmail.com> - ${NEW_VERSION}-1\n- Git snapshot (commit $COMMIT_COUNT: $COMMIT_HASH)"
@@ -163,12 +163,12 @@ jobs:
       - name: Update Debian dms-git changelog version
         if: contains(steps.packages.outputs.packages, 'dms-git') || steps.packages.outputs.packages == 'all'
         run: |
-          # Get commit info for dms-git versioning 
+          # Get commit info for dms-git versioning
           COMMIT_HASH=$(git rev-parse --short=8 HEAD)
           COMMIT_COUNT=$(git rev-list --count HEAD)
           BASE_VERSION=$(grep -oP '^Version:\s+\K[0-9.]+' distro/opensuse/dms.spec | head -1 || echo "0.6.2")
 
-          # Debian version format: 0.6.2+git2256.9162e314 
+          # Debian version format: 0.6.2+git2256.9162e314
           NEW_VERSION="${BASE_VERSION}+git${COMMIT_COUNT}.${COMMIT_HASH}"
           echo "📦 Updating Debian dms-git changelog to version: $NEW_VERSION"
 
@@ -182,7 +182,7 @@ jobs:
           echo "Current Debian version: $CURRENT_VERSION"
           echo "New version: $NEW_VERSION"
 
-          # Only update if version changed 
+          # Only update if version changed
           if [ "$CURRENT_VERSION" != "$NEW_VERSION" ]; then
             # Create new changelog entry at top
             TEMP_CHANGELOG=$(mktemp)
@@ -211,10 +211,10 @@ jobs:
           VERSION="${{ steps.packages.outputs.version }}"
           VERSION_NO_V="${VERSION#v}"
           echo "Updating packaging to version $VERSION_NO_V"
-          
+
           # Update openSUSE dms spec (stable only)
           sed -i "s/^Version:.*/Version:        $VERSION_NO_V/" distro/opensuse/dms.spec
-          
+
           # Update Debian _service files
           for service in distro/debian/*/_service; do
             if [[ -f "$service" ]]; then
@@ -250,18 +250,18 @@ jobs:
         run: |
           PACKAGES="${{ steps.packages.outputs.packages }}"
           MESSAGE="Automated update from GitHub Actions"
-          
+
           if [[ -n "${{ steps.packages.outputs.version }}" ]]; then
             MESSAGE="Update to ${{ steps.packages.outputs.version }}"
           fi
-          
+
           if [[ "$PACKAGES" == "all" ]]; then
             bash distro/scripts/obs-upload.sh dms "$MESSAGE"
             bash distro/scripts/obs-upload.sh dms-git "Automated git update"
           else
             bash distro/scripts/obs-upload.sh "$PACKAGES" "$MESSAGE"
           fi
-      
+
       - name: Summary
         run: |
           echo "### OBS Package Update Complete" >> $GITHUB_STEP_SUMMARY

.github/workflows/run-ppa.yml

@@ -84,12 +84,12 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      
+
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
           go-version: '1.24'
-          cache: false  
+          cache: false
 
       - name: Install build dependencies
         run: |
@@ -102,7 +102,7 @@ jobs:
             build-essential \
             fakeroot \
             dpkg-dev
-      
+
       - name: Configure GPG
         env:
           GPG_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
@@ -110,7 +110,7 @@ jobs:
           echo "$GPG_KEY" | gpg --import
           GPG_KEY_ID=$(gpg --list-secret-keys --keyid-format LONG | grep sec | awk '{print $2}' | cut -d'/' -f2)
           echo "DEBSIGN_KEYID=$GPG_KEY_ID" >> $GITHUB_ENV
-      
+
       - name: Determine packages to upload
         id: packages
         run: |
@@ -123,19 +123,19 @@ jobs:
           else
             echo "packages=${{ needs.check-updates.outputs.packages }}" >> $GITHUB_OUTPUT
           fi
-      
+
       - name: Upload to PPA
         env:
           REBUILD_RELEASE: ${{ github.event.inputs.rebuild_release }}
         run: |
           PACKAGES="${{ steps.packages.outputs.packages }}"
-          
+
           # Export to ensure it's available to subprocesses
           if [ -n "$REBUILD_RELEASE" ]; then
             export REBUILD_RELEASE
             echo "✓ Using rebuild release number: ppa$REBUILD_RELEASE"
           fi
-          
+
           if [[ "$PACKAGES" == "all" ]]; then
             echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
             echo "Uploading dms to PPA..."
@@ -144,13 +144,13 @@ jobs:
             fi
             echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
             REBUILD_RELEASE="$REBUILD_RELEASE" bash distro/scripts/ppa-upload.sh "distro/ubuntu/dms" dms questing
-            
+
             echo ""
             echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
             echo "Uploading dms-git to PPA..."
             echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
             REBUILD_RELEASE="$REBUILD_RELEASE" bash distro/scripts/ppa-upload.sh "distro/ubuntu/dms-git" dms-git questing
-            
+
             echo ""
             echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
             echo "Uploading dms-greeter to PPA..."
@@ -163,7 +163,7 @@ jobs:
             echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
             REBUILD_RELEASE="$REBUILD_RELEASE" bash distro/scripts/ppa-upload.sh "distro/ubuntu/$PACKAGES" "$PPA_NAME" questing
           fi
-      
+
       - name: Summary
         run: |
           echo "### PPA Package Upload Complete" >> $GITHUB_STEP_SUMMARY
@@ -186,7 +186,7 @@ jobs:
           elif [[ "$PACKAGES" == "dms-greeter" ]]; then
             echo "- **PPA**: https://launchpad.net/~avengemedia/+archive/ubuntu/danklinux/+packages" >> $GITHUB_STEP_SUMMARY
           fi
-          
+
           if [[ -n "${{ steps.packages.outputs.version }}" ]]; then
             echo "- **Version**: ${{ steps.packages.outputs.version }}" >> $GITHUB_STEP_SUMMARY
           fi