optimizations for animation behaviors

quickshell/Modals/Common/DankModalConnected.qml

@@ -1,3 +1,5 @@
+pragma ComponentBehavior: Bound
+
 import QtQuick
 import Quickshell
 import Quickshell.Wayland
@@ -94,22 +96,11 @@ Item {
     signal dialogClosed
     signal backgroundClicked
 
+    // Coalesce per-channel dirty bits; one ConnectedModeState write per tick.
     Timer {
-        id: _fullSyncTimer
+        id: _syncTimer
         interval: 0
-        onTriggered: root._flushFullSync()
-    }
-
-    Timer {
-        id: _animSyncTimer
-        interval: 0
-        onTriggered: root._flushAnimSync()
-    }
-
-    Timer {
-        id: _bodySyncTimer
-        interval: 0
-        onTriggered: root._flushBodySync()
+        onTriggered: root._flushSync()
     }
 
     property bool animationsEnabled: true
@@ -157,40 +148,37 @@ Item {
             ConnectedModeState.releaseDockRetract(_chromeClaimId);
     }
 
-    function _flushFullSync() {
-        _fullSyncPending = false;
-        _syncModalChromeState();
-    }
+    property bool _animSyncQueued: false
+    property bool _bodySyncQueued: false
 
     function _queueFullSync() {
-        if (_fullSyncPending)
-            return;
         _fullSyncPending = true;
-        _fullSyncTimer.restart();
+        if (!_syncTimer.running)
+            _syncTimer.restart();
     }
-
-    property bool _animSyncQueued: false
     function _queueAnimSync() {
-        if (_animSyncQueued)
-            return;
         _animSyncQueued = true;
-        _animSyncTimer.restart();
+        if (!_syncTimer.running)
+            _syncTimer.restart();
     }
-    function _flushAnimSync() {
-        _animSyncQueued = false;
-        _syncModalAnim();
-    }
-
-    property bool _bodySyncQueued: false
     function _queueBodySync() {
-        if (_bodySyncQueued)
-            return;
         _bodySyncQueued = true;
-        _bodySyncTimer.restart();
+        if (!_syncTimer.running)
+            _syncTimer.restart();
     }
-    function _flushBodySync() {
+    function _flushSync() {
+        const fullDirty = _fullSyncPending;
+        const animDirty = _animSyncQueued;
+        const bodyDirty = _bodySyncQueued;
+        _fullSyncPending = false;
+        _animSyncQueued = false;
         _bodySyncQueued = false;
-        _syncModalBody();
+        if (fullDirty)
+            _syncModalChromeState();
+        if (animDirty)
+            _syncModalAnim();
+        if (bodyDirty)
+            _syncModalBody();
     }
 
     function _syncModalAnim() {
@@ -699,44 +687,31 @@ Item {
                 return root.animationOffset;
             }
 
-            property real animX: root.shouldBeVisible ? 0 : root.frozenMotionOffsetX
-            property real animY: root.shouldBeVisible ? 0 : root.frozenMotionOffsetY
+            readonly property real computedScaleCollapsed: root.animationScaleCollapsed
+
+            // openProgress: 0 = closed (at frozenMotionOffset, scaleCollapsed), 1 = open (at 0, scale 1).
+            QtObject {
+                id: morph
+                property real openProgress: root.shouldBeVisible ? 1 : 0
+                Behavior on openProgress {
+                    enabled: root.animationsEnabled
+                    NumberAnimation {
+                        duration: Theme.variantDuration(root.animationDuration, root.shouldBeVisible)
+                        easing.type: Easing.BezierSpline
+                        easing.bezierCurve: root.shouldBeVisible ? root.animationEnterCurve : root.animationExitCurve
+                    }
+                }
+            }
+
+            readonly property real animX: root.frozenMotionOffsetX * (1 - morph.openProgress)
+            readonly property real animY: root.frozenMotionOffsetY * (1 - morph.openProgress)
+            readonly property real scaleValue: computedScaleCollapsed + (1.0 - computedScaleCollapsed) * morph.openProgress
 
             onAnimXChanged: if (root.frameOwnsConnectedChrome)
                 root._queueAnimSync()
             onAnimYChanged: if (root.frameOwnsConnectedChrome)
                 root._queueAnimSync()
 
-            readonly property real computedScaleCollapsed: root.animationScaleCollapsed
-            property real scaleValue: root.shouldBeVisible ? 1.0 : computedScaleCollapsed
-
-            Behavior on animX {
-                enabled: root.animationsEnabled
-                NumberAnimation {
-                    duration: Theme.variantDuration(root.animationDuration, root.shouldBeVisible)
-                    easing.type: Easing.BezierSpline
-                    easing.bezierCurve: root.shouldBeVisible ? root.animationEnterCurve : root.animationExitCurve
-                }
-            }
-
-            Behavior on animY {
-                enabled: root.animationsEnabled
-                NumberAnimation {
-                    duration: Theme.variantDuration(root.animationDuration, root.shouldBeVisible)
-                    easing.type: Easing.BezierSpline
-                    easing.bezierCurve: root.shouldBeVisible ? root.animationEnterCurve : root.animationExitCurve
-                }
-            }
-
-            Behavior on scaleValue {
-                enabled: root.animationsEnabled
-                NumberAnimation {
-                    duration: Theme.variantDuration(root.animationDuration, root.shouldBeVisible)
-                    easing.type: Easing.BezierSpline
-                    easing.bezierCurve: root.shouldBeVisible ? root.animationEnterCurve : root.animationExitCurve
-                }
-            }
-
             Item {
                 id: contentContainer
                 anchors.centerIn: parent