From c1818dee2c03c19eff97b37320eeb00f62f142e6 Mon Sep 17 00:00:00 2001
From: arfan <arfan.jadul10@gmail.com>
Date: Wed, 30 Sep 2026 04:06:06 +0700
Subject: [PATCH] fix(theme-vscode): update editorSuggestWidget colors for
 improved visibility (#3599)

* fix(theme-vscode): update editorSuggestWidget colors for improved visibility in dark, default, and light themes

* fix(theme-vscode): update button.hoverBackground to use primary_fixed colors for consistency
---
 quickshell/matugen/templates/vscode-color-theme-dark.json  | 7 ++++---
 .../matugen/templates/vscode-color-theme-default.json      | 7 ++++---
 quickshell/matugen/templates/vscode-color-theme-light.json | 7 ++++---
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/quickshell/matugen/templates/vscode-color-theme-dark.json b/quickshell/matugen/templates/vscode-color-theme-dark.json
index b11efb1cb..b2e44516a 100644
--- a/quickshell/matugen/templates/vscode-color-theme-dark.json
+++ b/quickshell/matugen/templates/vscode-color-theme-dark.json
@@ -91,7 +91,7 @@
     //
     "button.background": "{{colors.primary.dark.hex}}",
     "button.foreground": "{{colors.on_primary.dark.hex}}",
-    "button.hoverBackground": "{{colors.primary_container.dark.hex}}",
+    "button.hoverBackground": "{{colors.primary_fixed.dark.hex}}",
     //
     // Status bar
     //
@@ -161,9 +161,10 @@
     "editorHoverWidget.border": "{{colors.outline.dark.hex}}",
     "editorSuggestWidget.background": "{{colors.surface_container.dark.hex}}",
     "editorSuggestWidget.foreground": "{{colors.on_surface.dark.hex}}",
-    "editorSuggestWidget.selectedBackground": "{{colors.surface_container_high.dark.hex}}",
-    "editorSuggestWidget.selectedForeground": "{{colors.on_surface.dark.hex}}",
+    "editorSuggestWidget.selectedBackground": "{{colors.primary.dark.hex}}",
+    "editorSuggestWidget.selectedForeground": "{{colors.on_primary.dark.hex}}",
     "editorSuggestWidget.highlightForeground": "{{colors.primary.dark.hex}}",
+    "editorSuggestWidget.focusHighlightForeground": "{{colors.on_primary.dark.hex}}",
     //
     // Scrollbar
     //
diff --git a/quickshell/matugen/templates/vscode-color-theme-default.json b/quickshell/matugen/templates/vscode-color-theme-default.json
index 9f9f96910..78b45c6a4 100644
--- a/quickshell/matugen/templates/vscode-color-theme-default.json
+++ b/quickshell/matugen/templates/vscode-color-theme-default.json
@@ -67,7 +67,7 @@
     "widget.shadow": "{{colors.background.default.hex}}80",
     "button.background": "{{colors.primary.default.hex}}",
     "button.foreground": "{{colors.on_primary.default.hex}}",
-    "button.hoverBackground": "{{colors.primary_container.default.hex}}",
+    "button.hoverBackground": "{{colors.primary_fixed.default.hex}}",
     "statusBar.background": "{{colors.background.default.hex}}",
     "statusBar.foreground": "{{colors.on_surface.default.hex}}",
     "statusBar.border": "{{colors.outline_variant.default.hex}}",
@@ -116,9 +116,10 @@
     "editorHoverWidget.border": "{{colors.outline.default.hex}}",
     "editorSuggestWidget.background": "{{colors.surface_container.default.hex}}",
     "editorSuggestWidget.foreground": "{{colors.on_surface.default.hex}}",
-    "editorSuggestWidget.selectedBackground": "{{colors.surface_container_high.default.hex}}",
-    "editorSuggestWidget.selectedForeground": "{{colors.on_surface.default.hex}}",
+    "editorSuggestWidget.selectedBackground": "{{colors.primary.default.hex}}",
+    "editorSuggestWidget.selectedForeground": "{{colors.on_primary.default.hex}}",
     "editorSuggestWidget.highlightForeground": "{{colors.primary.default.hex}}",
+    "editorSuggestWidget.focusHighlightForeground": "{{colors.on_primary.default.hex}}",
     "scrollbarSlider.background": "{{colors.on_surface_variant.default.hex}}50",
     "scrollbarSlider.hoverBackground": "{{colors.on_surface_variant.default.hex}}80",
     "scrollbarSlider.activeBackground": "{{colors.on_surface_variant.default.hex}}AA",
diff --git a/quickshell/matugen/templates/vscode-color-theme-light.json b/quickshell/matugen/templates/vscode-color-theme-light.json
index a39e7a284..8d239807e 100644
--- a/quickshell/matugen/templates/vscode-color-theme-light.json
+++ b/quickshell/matugen/templates/vscode-color-theme-light.json
@@ -43,9 +43,10 @@
     "editorSuggestWidget.background": "{{colors.surface_container.light.hex}}",
     "editorSuggestWidget.foreground": "{{colors.on_surface.light.hex}}",
     "editorSuggestWidget.border": "{{colors.outline_variant.light.hex}}",
-    "editorSuggestWidget.selectedBackground": "{{colors.surface_container_high.light.hex}}",
-    "editorSuggestWidget.selectedForeground": "{{colors.on_surface.light.hex}}",
+    "editorSuggestWidget.selectedBackground": "{{colors.primary.light.hex}}",
+    "editorSuggestWidget.selectedForeground": "{{colors.on_primary.light.hex}}",
     "editorSuggestWidget.highlightForeground": "{{colors.primary.light.hex}}",
+    "editorSuggestWidget.focusHighlightForeground": "{{colors.on_primary.light.hex}}",
     "editorGroup.border": "{{colors.outline_variant.light.hex}}",
     "editorGroup.dropBackground": "{{colors.primary_container.light.hex}}33",
     "editorGroupHeader.tabsBackground": "{{colors.background.light.hex}}",
@@ -111,7 +112,7 @@
     "quickInputList.focusIconForeground": "{{colors.on_primary.light.hex}}",
     "button.background": "{{colors.primary.light.hex}}",
     "button.foreground": "{{colors.on_primary.light.hex}}",
-    "button.hoverBackground": "{{colors.primary_container.light.hex}}",
+    "button.hoverBackground": "{{colors.primary_fixed.light.hex}}",
     "badge.background": "{{colors.secondary.light.hex}}",
     "badge.foreground": "{{colors.on_secondary.light.hex}}",
     "panel.background": "{{colors.surface_container.light.hex}}",