From dfa19b9237ace6bbed7e222ad7e241802a2f0789 Mon Sep 17 00:00:00 2001 From: Kadir <104317272+KadirJeager@users.noreply.github.com> Date: Mon, 5 Oct 2026 07:49:54 +0300 Subject: [PATCH] settings: hide include setup banners on compositors without includes (#3699) On compositors with no include support (sway, labwc, ...) the displays page showed a setup banner whose fix button can never succeed. Co-authored-by: Claude Opus 5.5 --- quickshell/Modules/Settings/DisplayConfigTab.qml | 2 +- quickshell/Modules/Settings/Widgets/IncludeSetupBanner.qml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/quickshell/Modules/Settings/DisplayConfigTab.qml b/quickshell/Modules/Settings/DisplayConfigTab.qml index 2ad1ca8dd..525d78ac6 100644 --- a/quickshell/Modules/Settings/DisplayConfigTab.qml +++ b/quickshell/Modules/Settings/DisplayConfigTab.qml @@ -457,7 +457,7 @@ Item { readonly property bool identifyConfigured: { if (!DisplayConfigState.hasOutputBackend || DisplayConfigState.readOnly) return false; - if (!["niri", "hyprland", "mango"].includes(CompositorService.compositor)) + if (!DisplayConfigState.include.compositorSupported) return true; return DisplayConfigState.includeStatus.included; } diff --git a/quickshell/Modules/Settings/Widgets/IncludeSetupBanner.qml b/quickshell/Modules/Settings/Widgets/IncludeSetupBanner.qml index f882faf5e..0f02b3d8d 100644 --- a/quickshell/Modules/Settings/Widgets/IncludeSetupBanner.qml +++ b/quickshell/Modules/Settings/Widgets/IncludeSetupBanner.qml @@ -17,7 +17,7 @@ StyledRect { color: Theme.withAlpha(Theme.primary, 0.15) border.color: Theme.withAlpha(Theme.primary, 0.3) border.width: Theme.outlineWidth - visible: visibleCondition && (showLegacy || showSetup) && !include.checking + visible: visibleCondition && include.compositorSupported && (showLegacy || showSetup) && !include.checking Row { id: content