From eb0cb80884f66575f96984cdc45d13ad807df622 Mon Sep 17 00:00:00 2001 From: Thomas Kroll <99196436+tkroll-ionos@users.noreply.github.com> Date: Wed, 23 Sep 2026 20:05:16 +0200 Subject: [PATCH] fix(workspace): ignore duplicate submit in rename modal (#3549) Pressing Enter in the name field fires both the text field's accepted signal and the dialog's own Return handler, so submitAndClose() runs twice. The first call renames and hides the window, which clears the field; the second call then renames to an empty string and unsets the workspace name. The OK button only fires once, so it was unaffected. Ignore submits once the window is hidden. Claude-Session: https://claude.ai/code/session_01791wgvD8EqJaAeURYXYbT5 Signed-off-by: Thomas Kroll <99196436+tkroll-ionos@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) --- quickshell/Modals/WorkspaceRenameModal.qml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/quickshell/Modals/WorkspaceRenameModal.qml b/quickshell/Modals/WorkspaceRenameModal.qml index 646a0f913..f29d3be34 100644 --- a/quickshell/Modals/WorkspaceRenameModal.qml +++ b/quickshell/Modals/WorkspaceRenameModal.qml @@ -44,6 +44,8 @@ DankFloatingWindow { } function submitAndClose() { + if (!root.visible) + return; if (aqueousWorkspace || CompositorService.isAqueous) { if (!aqueousWorkspace || renaming) return;