Salastil/DankMaterialShell
1
0
Fork 0
mirror of https://github.com/AvengeMedia/DankMaterialShell.git synced 2026-08-09 06:58:29 -04:00
Code Packages Releases Activity

fix(Modal): respect targetScreen property instead of always using focused screen (#2861)

Browse Source 
The open() method in both DankModalStandalone and DankModalConnected unconditionally set contentWindow.screen to the focused screen, ignoring the targetScreen property.

Fix: use root.targetScreen ?? CompositorService.getFocusedScreen() so the modal appears on the configured screen when set, and falls back to focused screen otherwise.
This commit is contained in:
Huỳnh Thiện Lộc
2026-07-14 19:42:08 +07:00
committed by GitHub
parent 9ff751b82a
commit f1e9121295
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
quickshell/Modals/Common/DankModalConnected.qml
+1 -1
View File
@@ -217,7 +217,7 @@ Item {
frozenMotionOffsetX = modalContainer ? modalContainer.offsetX : 0; frozenMotionOffsetX = modalContainer ? modalContainer.offsetX : 0;
frozenMotionOffsetY = modalContainer ? modalContainer.offsetY : animationOffset; frozenMotionOffsetY = modalContainer ? modalContainer.offsetY : animationOffset;
const focusedScreen = CompositorService.getFocusedScreen(); const focusedScreen = root.targetScreen ?? CompositorService.getFocusedScreen();
if (focusedScreen) { if (focusedScreen) {
contentWindow.screen = focusedScreen; contentWindow.screen = focusedScreen;
} }
quickshell/Modals/Common/DankModalStandalone.qml
+1 -1
View File
@@ -70,7 +70,7 @@ Item {
function open() { function open() {
closeTimer.stop(); closeTimer.stop();
isClosing = false; isClosing = false;
const focusedScreen = CompositorService.getFocusedScreen(); const focusedScreen = root.targetScreen ?? CompositorService.getFocusedScreen();
const screenChanged = focusedScreen && contentWindow.screen !== focusedScreen; const screenChanged = focusedScreen && contentWindow.screen !== focusedScreen;
if (focusedScreen) { if (focusedScreen) {
if (screenChanged) if (screenChanged)