1
0
mirror of https://github.com/AvengeMedia/DankMaterialShell.git synced 2026-08-01 19:18:28 -04:00

refactor(auth): relay on distro system auth over DMS managed sessions

- Gate greeter external-auth status fprint availability only on confirmed setups
- Reload dankshell-U2F/U2F-Key watchers live

Related: #2874
Port 1.5

(cherry picked from commit 3938e60ce4)
This commit is contained in:
purian23
2026-07-17 17:27:45 -04:00
parent fc11dfbc57
commit f37f4a1f35
8 changed files with 296 additions and 272 deletions
@@ -0,0 +1,25 @@
package qmlchecks
import (
"os"
"strings"
"testing"
)
func TestGreeterExternalAuthStatusUsesEffectiveFingerprintAvailability(t *testing.T) {
data, err := os.ReadFile("../../../quickshell/Modules/Greetd/GreeterContent.qml")
if err != nil {
t.Fatalf("read greeter QML: %v", err)
}
content := string(data)
for _, required := range []string{
"readonly property bool greeterPamHasExternalAuth: greeterPamHasFprint || greeterPamHasU2f",
"if (greeterPamHasFprint && greeterPamHasU2f)",
"if (greeterPamHasFprint)",
} {
if !strings.Contains(content, required) {
t.Fatalf("greeter external-auth status must contain %q", required)
}
}
}
@@ -31,8 +31,8 @@ func TestLockScreenAuthenticationCardOwnsFactorControls(t *testing.T) {
} }
content := string(data) content := string(data)
authCard := strings.Index(content, `title: I18n.tr("Lock Screen Authentication")`) authCard := strings.Index(content, `title: I18n.tr("Authentication")`)
behaviorCard := strings.Index(content, `title: I18n.tr("Lock Screen behaviour")`) behaviorCard := strings.Index(content, `title: I18n.tr("Behavior")`)
fingerprintToggle := strings.Index(content, `settingKey: "enableFprint"`) fingerprintToggle := strings.Index(content, `settingKey: "enableFprint"`)
u2fToggle := strings.Index(content, `settingKey: "enableU2f"`) u2fToggle := strings.Index(content, `settingKey: "enableU2f"`)
u2fSource := strings.Index(content, `settingKey: "lockU2fPamPath"`) u2fSource := strings.Index(content, `settingKey: "lockU2fPamPath"`)
+7 -1
View File
@@ -247,6 +247,10 @@ Singleton {
readonly property var _pamProbeCommand: ["sh", "-c", "for module in pam_fprintd.so pam_u2f.so; do found=false; for dir in /usr/lib64/security /usr/lib/security /lib/security /lib/x86_64-linux-gnu/security /usr/lib/x86_64-linux-gnu/security /usr/lib/aarch64-linux-gnu/security /run/current-system/sw/lib/security; do if [ -f \"$dir/$module\" ]; then found=true; break; fi; done; printf '%s:%s\\n' \"$module\" \"$found\"; done"] readonly property var _pamProbeCommand: ["sh", "-c", "for module in pam_fprintd.so pam_u2f.so; do found=false; for dir in /usr/lib64/security /usr/lib/security /lib/security /lib/x86_64-linux-gnu/security /usr/lib/x86_64-linux-gnu/security /usr/lib/aarch64-linux-gnu/security /run/current-system/sw/lib/security; do if [ -f \"$dir/$module\" ]; then found=true; break; fi; done; printf '%s:%s\\n' \"$module\" \"$found\"; done"]
function detectAuthCapabilities() { function detectAuthCapabilities() {
// FileView cannot watch paths that do not exist yet, so reload the U2F PAM
dankshellU2fPamWatcher.reload();
u2fKeysWatcher.reload();
if (forcedFprintAvailable === null) { if (forcedFprintAvailable === null) {
fingerprintProbeFinalized = false; fingerprintProbeFinalized = false;
Proc.runCommand("fprint-probe", _fprintProbeCommand, (output, exitCode) => { Proc.runCommand("fprint-probe", _fprintProbeCommand, (output, exitCode) => {
@@ -600,7 +604,7 @@ Singleton {
let details = out; let details = out;
if (err !== "") if (err !== "")
details = details !== "" ? details + "\n\nstderr:\n" + err : "stderr:\n" + err; details = details !== "" ? details + "\n\nstderr:\n" + err : "stderr:\n" + err;
ToastService.showInfo(I18n.tr("Authentication changes applied."), details, "", "auth-sync"); ToastService.showInfo(I18n.tr("Authentication changes applied"), details, "", "auth-sync");
root.detectAuthCapabilities(); root.detectAuthCapabilities();
root.finishAuthApply(); root.finishAuthApply();
return; return;
@@ -723,6 +727,7 @@ Singleton {
FileView { FileView {
id: dankshellU2fPamWatcher id: dankshellU2fPamWatcher
path: "/etc/pam.d/dankshell-u2f" path: "/etc/pam.d/dankshell-u2f"
watchChanges: true
printErrors: false printErrors: false
onLoaded: root.dankshellU2fPamText = text() onLoaded: root.dankshellU2fPamText = text()
onLoadFailed: root.dankshellU2fPamText = "" onLoadFailed: root.dankshellU2fPamText = ""
@@ -737,6 +742,7 @@ Singleton {
FileView { FileView {
id: u2fKeysWatcher id: u2fKeysWatcher
path: root.u2fKeysPath path: root.u2fKeysPath
watchChanges: true
printErrors: false printErrors: false
onLoaded: root.u2fKeysText = text() onLoaded: root.u2fKeysText = text()
onLoadFailed: root.u2fKeysText = "" onLoadFailed: root.u2fKeysText = ""
+3 -3
View File
@@ -73,14 +73,14 @@ Item {
readonly property bool greeterPamHasFprint: greeterPamStackHasFprint && (!fprintdProbeComplete || fprintdHasDevice) readonly property bool greeterPamHasFprint: greeterPamStackHasFprint && (!fprintdProbeComplete || fprintdHasDevice)
readonly property bool greeterPamHasU2f: greeterPamStackHasModule("pam_u2f") readonly property bool greeterPamHasU2f: greeterPamStackHasModule("pam_u2f")
readonly property bool greeterExternalAuthAvailable: (greeterPamHasFprint && GreetdSettings.greeterEnableFprint) || (greeterPamHasU2f && GreetdSettings.greeterEnableU2f) readonly property bool greeterExternalAuthAvailable: (greeterPamHasFprint && GreetdSettings.greeterEnableFprint) || (greeterPamHasU2f && GreetdSettings.greeterEnableU2f)
readonly property bool greeterPamHasExternalAuth: greeterPamStackHasFprint || greeterPamHasU2f readonly property bool greeterPamHasExternalAuth: greeterPamHasFprint || greeterPamHasU2f
readonly property bool externalAuthInProgress: awaitingExternalAuth || (Greetd.state !== GreetdState.Inactive && passwordSubmitRequested && greeterPamHasExternalAuth && !pendingPasswordResponse) readonly property bool externalAuthInProgress: awaitingExternalAuth || (Greetd.state !== GreetdState.Inactive && passwordSubmitRequested && greeterPamHasExternalAuth && !pendingPasswordResponse)
readonly property string externalAuthStatusMessage: { readonly property string externalAuthStatusMessage: {
if (!externalAuthInProgress) if (!externalAuthInProgress)
return ""; return "";
if (greeterPamStackHasFprint && greeterPamHasU2f) if (greeterPamHasFprint && greeterPamHasU2f)
return I18n.tr("Awaiting fingerprint or security key authentication"); return I18n.tr("Awaiting fingerprint or security key authentication");
if (greeterPamStackHasFprint) if (greeterPamHasFprint)
return I18n.tr("Awaiting fingerprint authentication"); return I18n.tr("Awaiting fingerprint authentication");
return I18n.tr("Awaiting security key authentication"); return I18n.tr("Awaiting security key authentication");
} }
+4
View File
@@ -113,6 +113,7 @@ Scope {
id: u2fConfigWatcher id: u2fConfigWatcher
path: "/etc/pam.d/dankshell-u2f" path: "/etc/pam.d/dankshell-u2f"
watchChanges: true
printErrors: false printErrors: false
} }
@@ -488,6 +489,9 @@ Scope {
root.resetAuthFlows(); root.resetAuthFlows();
if (!SettingsData.lockPamExternallyManaged && !dankshellConfigWatcher.loaded && !userPamWatcher.loaded) if (!SettingsData.lockPamExternallyManaged && !dankshellConfigWatcher.loaded && !userPamWatcher.loaded)
ensureUserPamConfig(); ensureUserPamConfig();
// FileView cannot watch a path that does not exist yet; re-read so a
// dedicated service created after startup is used on the next lock.
u2fConfigWatcher.reload();
fprint.checkAvail(); fprint.checkAvail();
u2f.checkAvail(); u2f.checkAvail();
} }
+22 -22
View File
@@ -19,39 +19,39 @@ Item {
function greeterFingerprintDescription() { function greeterFingerprintDescription() {
if (SettingsData.greeterPamExternallyManaged) if (SettingsData.greeterPamExternallyManaged)
return "greetd PAM is externally managed"; return I18n.tr("Managed by the primary PAM source", "factor managed by PAM source status");
if (SettingsData.greeterFingerprintSource === "pam") if (SettingsData.greeterFingerprintSource === "pam")
return I18n.tr("PAM already provides fingerprint auth. Enable this to show it at login.", "greeter fingerprint login setting"); return I18n.tr("PAM already provides fingerprint auth. Enable this to show it at login.", "greeter fingerprint login setting");
switch (SettingsData.greeterFingerprintReason) { switch (SettingsData.greeterFingerprintReason) {
case "ready": case "ready":
return I18n.tr("Authentication changes apply automatically.", "greeter auth setting description"); return I18n.tr("Authentication changes apply automatically", "greeter auth setting description");
case "missing_enrollment": case "missing_enrollment":
return I18n.tr("Fingerprint reader detected, but no prints are enrolled yet. You can enable this now and run Sync later.", "greeter fingerprint login setting"); return I18n.tr("Fingerprint reader detected, but no prints are enrolled yet. You can enable this now and run Sync later.", "greeter fingerprint login setting");
case "missing_reader": case "missing_reader":
return I18n.tr("No fingerprint reader detected.", "fingerprint setting status"); return I18n.tr("No fingerprint reader detected", "fingerprint setting status");
case "missing_pam_support": case "missing_pam_support":
return I18n.tr("Not available — install fprintd and pam_fprintd, or configure greetd PAM.", "greeter fingerprint login setting"); return I18n.tr("Not available — install fprintd and pam_fprintd, or configure greetd PAM.", "greeter fingerprint login setting");
default: default:
return I18n.tr("Fingerprint availability could not be confirmed.", "fingerprint setting status"); return I18n.tr("Fingerprint availability could not be confirmed", "fingerprint setting status");
} }
} }
function greeterU2fDescription() { function greeterU2fDescription() {
if (SettingsData.greeterPamExternallyManaged) if (SettingsData.greeterPamExternallyManaged)
return "greetd PAM is externally managed"; return I18n.tr("Managed by the primary PAM source", "factor managed by PAM source status");
if (SettingsData.greeterU2fSource === "pam") if (SettingsData.greeterU2fSource === "pam")
return I18n.tr("PAM already provides security-key auth. Enable this to show it at login.", "greeter security key login setting"); return I18n.tr("PAM already provides security-key auth. Enable this to show it at login.", "greeter security key login setting");
switch (SettingsData.greeterU2fReason) { switch (SettingsData.greeterU2fReason) {
case "ready": case "ready":
return I18n.tr("Authentication changes apply automatically.", "greeter auth setting description"); return I18n.tr("Authentication changes apply automatically", "greeter auth setting description");
case "missing_key_registration": case "missing_key_registration":
return I18n.tr("Security-key support was detected, but no registered key was found yet. You can enable this now and register one later.", "security key setting status"); return I18n.tr("Security-key support was detected, but no registered key was found yet. You can enable this now and register one later.", "security key setting status");
case "missing_pam_support": case "missing_pam_support":
return I18n.tr("Not available — install or configure pam_u2f, or configure greetd PAM.", "greeter security key login setting"); return I18n.tr("Not available — install or configure pam_u2f, or configure greetd PAM.", "greeter security key login setting");
default: default:
return I18n.tr("Security-key availability could not be confirmed.", "security key setting status"); return I18n.tr("Security-key availability could not be confirmed", "security key setting status");
} }
} }
@@ -305,7 +305,7 @@ Item {
onExited: exitCode => { onExited: exitCode => {
root.greeterSyncRunning = false; root.greeterSyncRunning = false;
if (exitCode === 0) { if (exitCode === 0) {
var launched = root.greeterTerminalFallbackFromPrecheck ? I18n.tr("Terminal opened. Complete sync authentication there; it will close automatically when done.") : I18n.tr("Terminal fallback opened. Complete sync there; it will close automatically when done."); var launched = root.greeterTerminalFallbackFromPrecheck ? I18n.tr("Terminal opened. Complete authentication there; it will close automatically when done.") : I18n.tr("Terminal fallback opened. Complete authentication there; it will close automatically when done.");
root.greeterStatusText = root.greeterStatusText ? root.greeterStatusText + "\n\n" + launched : launched; root.greeterStatusText = root.greeterStatusText ? root.greeterStatusText + "\n\n" + launched : launched;
SettingsData.clearGreeterSyncPending(); SettingsData.clearGreeterSyncPending();
return; return;
@@ -396,11 +396,11 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "info" iconName: "info"
title: I18n.tr("Greeter Status") title: I18n.tr("Status")
settingKey: "greeterStatus" settingKey: "greeterStatus"
StyledText { StyledText {
text: I18n.tr("Sync applies your theme and settings to the login screen. Other users should run dms greeter sync --profile instead of a full sync. Authentication changes apply automatically.") text: I18n.tr("Sync applies your theme and settings to the login screen. Shared users should run dms greeter sync --profile instead of a primary user sync.")
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
width: parent.width width: parent.width
@@ -470,11 +470,11 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "fingerprint" iconName: "fingerprint"
title: I18n.tr("Login Authentication") title: I18n.tr("Authentication")
settingKey: "greeterAuth" settingKey: "greeterAuth"
StyledText { StyledText {
text: I18n.tr("Enable fingerprint or security key for DMS Greeter. Authentication changes apply automatically.") text: I18n.tr("Enable fingerprint or security key for DMS Greeter")
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
width: parent.width width: parent.width
@@ -485,8 +485,8 @@ Item {
SettingsToggleRow { SettingsToggleRow {
settingKey: "greeterPamExternallyManaged" settingKey: "greeterPamExternallyManaged"
tags: ["greeter", "pam", "managed", "external", "greetd", "auth"] tags: ["greeter", "pam", "managed", "external", "greetd", "auth"]
text: "greetd PAM is externally managed" text: I18n.tr("Use system PAM authentication", "system PAM policy toggle")
description: "DMS removes its managed block from /etc/pam.d/greetd and stops writing to it" description: I18n.tr("DMS removes its managed block from /etc/pam.d/greetd and stops write services", "greeter system PAM toggle description")
checked: SettingsData.greeterPamExternallyManaged checked: SettingsData.greeterPamExternallyManaged
onToggled: checked => SettingsData.set("greeterPamExternallyManaged", checked) onToggled: checked => SettingsData.set("greeterPamExternallyManaged", checked)
} }
@@ -517,7 +517,7 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "palette" iconName: "palette"
title: I18n.tr("Greeter Appearance") title: I18n.tr("Appearance")
settingKey: "greeterAppearance" settingKey: "greeterAppearance"
StyledText { StyledText {
@@ -553,12 +553,12 @@ Item {
settingKey: "greeterLockDateFormat" settingKey: "greeterLockDateFormat"
tags: ["greeter", "date", "format"] tags: ["greeter", "date", "format"]
text: I18n.tr("Date Format") text: I18n.tr("Date Format")
description: I18n.tr("Greeter only — format for the date on the login screen") description: I18n.tr("Format the date on the login screen")
options: root._lockDateFormatPresets.map(p => p.label) options: root._lockDateFormatPresets.map(p => p.label)
currentValue: { currentValue: {
var current = (SettingsData.greeterLockDateFormat !== undefined && SettingsData.greeterLockDateFormat !== "") ? SettingsData.greeterLockDateFormat : SettingsData.lockDateFormat || ""; var current = (SettingsData.greeterLockDateFormat !== undefined && SettingsData.greeterLockDateFormat !== "") ? SettingsData.greeterLockDateFormat : SettingsData.lockDateFormat || "";
var match = root._lockDateFormatPresets.find(p => p.format === current); var match = root._lockDateFormatPresets.find(p => p.format === current);
return match ? match.label : (current ? I18n.tr("Custom: ") + current : root._lockDateFormatPresets[0].label); return match ? match.label : (current ? I18n.tr("Custom") + ": " + current : root._lockDateFormatPresets[0].label);
} }
onValueChanged: value => { onValueChanged: value => {
var preset = root._lockDateFormatPresets.find(p => p.label === value); var preset = root._lockDateFormatPresets.find(p => p.label === value);
@@ -577,7 +577,7 @@ Item {
} }
StyledText { StyledText {
text: I18n.tr("Use a custom image for the login screen, or leave empty to use your desktop wallpaper.") text: I18n.tr("Use a custom image for the login screen, or leave empty to use desktop wallpaper")
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
width: parent.width width: parent.width
@@ -601,11 +601,11 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "history" iconName: "history"
title: I18n.tr("Greeter Behavior") title: I18n.tr("Behavior")
settingKey: "greeterBehavior" settingKey: "greeterBehavior"
StyledText { StyledText {
text: I18n.tr("Convenience options for the login screen. Sync to apply.") text: I18n.tr("Convenience options for the login screen")
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
width: parent.width width: parent.width
@@ -649,7 +649,7 @@ Item {
settingKey: "greeterDeps" settingKey: "greeterDeps"
StyledText { StyledText {
text: I18n.tr("Requires greetd, dms-greeter, and your user in the greeter group (plus fprintd/pam_fprintd for fingerprint, pam_u2f for security keys). Auth changes apply automatically and may open a terminal for sudo.") text: I18n.tr("Requires greetd, dms-greeter, and your user in the greeter group (plus fprintd/pam_fprintd for fingerprint, pam_u2f for security keys).")
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
width: parent.width width: parent.width
@@ -658,7 +658,7 @@ Item {
} }
StyledText { StyledText {
text: I18n.tr("Installation and PAM setup: see the ") + "<a href=\"https://danklinux.com/docs/dankgreeter/installation\" style=\"text-decoration:none; color:" + Theme.primary + ";\">DankGreeter docs</a> " + I18n.tr("or run ") + "'dms greeter install'." text: I18n.tr("Installation and PAM setup are documented in the ") + "<a href=\"https://danklinux.com/docs/dankgreeter/installation\" style=\"text-decoration:none; color:" + Theme.primary + ";\">DankGreeter docs.</a> "
textFormat: Text.RichText textFormat: Text.RichText
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
+27 -38
View File
@@ -96,28 +96,28 @@ Item {
function lockFingerprintDescription() { function lockFingerprintDescription() {
switch (SettingsData.lockFingerprintReason) { switch (SettingsData.lockFingerprintReason) {
case "ready": case "ready":
return I18n.tr("Use fingerprint authentication for the lock screen.", "lock screen fingerprint setting"); return I18n.tr("Use fingerprint authentication for the lock screen", "lock screen fingerprint setting");
case "missing_enrollment": case "missing_enrollment":
return I18n.tr("Fingerprint reader detected, but no prints are enrolled yet. You can enable this now and enroll later.", "lock screen fingerprint setting"); return I18n.tr("Fingerprint reader detected, but no prints are enrolled yet. You can enable this now and enroll later.", "lock screen fingerprint setting");
case "missing_reader": case "missing_reader":
return I18n.tr("No fingerprint reader detected.", "fingerprint setting status"); return I18n.tr("No fingerprint reader detected", "fingerprint setting status");
case "missing_pam_support": case "missing_pam_support":
return I18n.tr("Not available install fprintd and pam_fprintd.", "lock screen fingerprint setting"); return I18n.tr("Not available - install fprintd and pam_fprintd", "lock screen fingerprint setting");
default: default:
return I18n.tr("Fingerprint availability could not be confirmed.", "fingerprint setting status"); return I18n.tr("Fingerprint availability could not be confirmed", "fingerprint setting status");
} }
} }
function lockU2fDescription() { function lockU2fDescription() {
switch (SettingsData.lockU2fReason) { switch (SettingsData.lockU2fReason) {
case "ready": case "ready":
return I18n.tr("Use a security key for lock screen authentication.", "lock screen U2F security key setting"); return I18n.tr("Use a security key for lock screen authentication", "lock screen U2F security key setting");
case "missing_key_registration": case "missing_key_registration":
return I18n.tr("Security-key support was detected, but no registered key was found yet. You can enable this now and register one later.", "security key setting status"); return I18n.tr("Security-key support was detected, but no registered key was found yet. You can enable this now and register one later.", "security key setting status");
case "missing_pam_support": case "missing_pam_support":
return I18n.tr("Not available install or configure pam_u2f.", "lock screen security key setting"); return I18n.tr("Not available - install or configure pam_u2f", "lock screen security key setting");
default: default:
return I18n.tr("Security-key availability could not be confirmed.", "security key setting status"); return I18n.tr("Security-key availability could not be confirmed", "security key setting status");
} }
} }
@@ -192,12 +192,12 @@ Item {
} catch (e) {} } catch (e) {}
if (!data) { if (!data) {
root.authValidateMessage = "Validation failed — is DMS in PATH?"; root.authValidateMessage = I18n.tr("Config validation failed");
return; return;
} }
if (!data.valid) { if (!data.valid) {
const errs = Array.isArray(data.errors) ? data.errors : []; const errs = Array.isArray(data.errors) ? data.errors : [];
root.authValidateMessage = ["Not applied.", ...errs].join("\n"); root.authValidateMessage = [I18n.tr("Config validation failed"), ...errs].join("\n");
return; return;
} }
@@ -207,7 +207,7 @@ Item {
const warns = Array.isArray(data.warnings) ? data.warnings : []; const warns = Array.isArray(data.warnings) ? data.warnings : [];
root.authValidateOk = true; root.authValidateOk = true;
root.authValidateWarn = warns.length > 0; root.authValidateWarn = warns.length > 0;
root.authValidateMessage = warns.length > 0 ? ["Applied with warnings.", ...warns].join("\n") : "Applied."; root.authValidateMessage = [I18n.tr("Authentication changes applied"), ...warns].join("\n");
} }
} }
@@ -232,12 +232,12 @@ Item {
} catch (e) {} } catch (e) {}
if (!data) { if (!data) {
root.u2fValidateMessage = "Validation failed — is DMS in PATH?"; root.u2fValidateMessage = I18n.tr("Config validation failed");
return; return;
} }
if (!data.valid) { if (!data.valid) {
const errs = Array.isArray(data.errors) ? data.errors : []; const errs = Array.isArray(data.errors) ? data.errors : [];
root.u2fValidateMessage = ["Not applied.", ...errs].join("\n"); root.u2fValidateMessage = [I18n.tr("Config validation failed"), ...errs].join("\n");
return; return;
} }
@@ -245,7 +245,7 @@ Item {
const warns = Array.isArray(data.warnings) ? data.warnings : []; const warns = Array.isArray(data.warnings) ? data.warnings : [];
root.u2fValidateOk = true; root.u2fValidateOk = true;
root.u2fValidateWarn = warns.length > 0; root.u2fValidateWarn = warns.length > 0;
root.u2fValidateMessage = warns.length > 0 ? ["Applied with warnings.", ...warns].join("\n") : "Applied."; root.u2fValidateMessage = [I18n.tr("Authentication changes applied"), ...warns].join("\n");
root.refreshAuthDetection(); root.refreshAuthDetection();
} }
} }
@@ -266,7 +266,7 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "lock" iconName: "lock"
title: I18n.tr("Lock Screen layout") title: I18n.tr("Layout")
settingKey: "lockLayout" settingKey: "lockLayout"
SettingsToggleRow { SettingsToggleRow {
@@ -345,7 +345,7 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "palette" iconName: "palette"
title: I18n.tr("Lock Screen Appearance") title: I18n.tr("Appearance")
settingKey: "lockAppearance" settingKey: "lockAppearance"
StyledText { StyledText {
@@ -396,11 +396,11 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "key" iconName: "key"
title: I18n.tr("Lock Screen Authentication") title: I18n.tr("Authentication")
settingKey: "lockAuthSource" settingKey: "lockAuthSource"
StyledText { StyledText {
text: I18n.tr("Changes apply automatically") text: I18n.tr("Authentication changes apply automatically")
font.pixelSize: Theme.fontSizeSmall font.pixelSize: Theme.fontSizeSmall
color: Theme.surfaceVariantText color: Theme.surfaceVariantText
width: parent.width width: parent.width
@@ -410,8 +410,8 @@ Item {
SettingsDropdownRow { SettingsDropdownRow {
settingKey: "lockPamPath" settingKey: "lockPamPath"
tags: ["lock", "screen", "pam", "authentication", "source", "service"] tags: ["lock", "screen", "pam", "authentication", "source", "service"]
text: "Authentication Source" text: I18n.tr("Authentication Source", "lock screen PAM source setting")
description: SettingsData.lockPamPath !== "" ? SettingsData.lockPamPath : "Which PAM service the lock screen uses to authenticate" description: SettingsData.lockPamPath !== "" ? SettingsData.lockPamPath : I18n.tr("Which PAM service the lock screen uses to authenticate", "lock screen PAM source setting")
options: root.authOptions options: root.authOptions
currentValue: root.authCurrentValue currentValue: root.authCurrentValue
onValueChanged: value => { onValueChanged: value => {
@@ -472,21 +472,10 @@ Item {
} }
} }
StyledText {
visible: !SettingsData.lockPamExternallyManaged && (root.primaryPamHasFprint || root.primaryPamHasU2f)
text: I18n.tr("Selected PAM source already manages the detected factors.")
font.pixelSize: Theme.fontSizeSmall
color: Theme.warning
width: parent.width
wrapMode: Text.Wrap
topPadding: Theme.spacingS
}
SettingsToggleRow { SettingsToggleRow {
settingKey: "lockPamExternallyManaged" settingKey: "lockPamExternallyManaged"
tags: ["lock", "screen", "pam", "managed", "external", "authentication", "policy"] tags: ["lock", "screen", "pam", "managed", "external", "authentication", "policy"]
text: I18n.tr("Use system PAM authentication") text: I18n.tr("Use system PAM authentication", "system PAM policy toggle")
description: SettingsData.lockPamExternallyManaged ? I18n.tr("System PAM sets the authentication policy.") : I18n.tr("DMS manages the factors below.")
checked: SettingsData.lockPamExternallyManaged checked: SettingsData.lockPamExternallyManaged
onToggled: checked => SettingsData.set("lockPamExternallyManaged", checked) onToggled: checked => SettingsData.set("lockPamExternallyManaged", checked)
} }
@@ -495,7 +484,7 @@ Item {
settingKey: "enableFprint" settingKey: "enableFprint"
tags: ["lock", "screen", "fingerprint", "authentication", "biometric", "fprint"] tags: ["lock", "screen", "fingerprint", "authentication", "biometric", "fprint"]
text: I18n.tr("Enable fingerprint authentication") text: I18n.tr("Enable fingerprint authentication")
description: root.lockFprintControlledByPrimary ? I18n.tr("Managed by the primary PAM source.") : root.lockFingerprintDescription() description: root.lockFprintControlledByPrimary ? I18n.tr("Managed by the primary PAM source", "factor managed by PAM source status") : root.lockFingerprintDescription()
descriptionColor: root.lockFprintControlledByPrimary || SettingsData.lockFingerprintReason === "ready" ? Theme.surfaceVariantText : Theme.warning descriptionColor: root.lockFprintControlledByPrimary || SettingsData.lockFingerprintReason === "ready" ? Theme.surfaceVariantText : Theme.warning
checked: SettingsData.enableFprint || root.primaryPamHasFprint checked: SettingsData.enableFprint || root.primaryPamHasFprint
enabled: root.lockFprintToggleAvailable && !root.lockFprintControlledByPrimary enabled: root.lockFprintToggleAvailable && !root.lockFprintControlledByPrimary
@@ -506,7 +495,7 @@ Item {
settingKey: "enableU2f" settingKey: "enableU2f"
tags: ["lock", "screen", "u2f", "yubikey", "security", "key", "fido", "authentication", "hardware"] tags: ["lock", "screen", "u2f", "yubikey", "security", "key", "fido", "authentication", "hardware"]
text: I18n.tr("Enable security key authentication", "Enable FIDO2/U2F hardware security key for lock screen") text: I18n.tr("Enable security key authentication", "Enable FIDO2/U2F hardware security key for lock screen")
description: root.lockU2fControlledByPrimary ? I18n.tr("Managed by the primary PAM source.") : root.lockU2fDescription() description: root.lockU2fControlledByPrimary ? I18n.tr("Managed by the primary PAM source", "factor managed by PAM source status") : root.lockU2fDescription()
descriptionColor: root.lockU2fControlledByPrimary || SettingsData.lockU2fReason === "ready" ? Theme.surfaceVariantText : Theme.warning descriptionColor: root.lockU2fControlledByPrimary || SettingsData.lockU2fReason === "ready" ? Theme.surfaceVariantText : Theme.warning
checked: SettingsData.enableU2f || root.primaryPamHasU2f checked: SettingsData.enableU2f || root.primaryPamHasU2f
enabled: root.lockU2fToggleAvailable && !root.lockU2fControlledByPrimary enabled: root.lockU2fToggleAvailable && !root.lockU2fControlledByPrimary
@@ -517,7 +506,7 @@ Item {
settingKey: "u2fMode" settingKey: "u2fMode"
tags: ["lock", "screen", "u2f", "yubikey", "security", "key", "mode", "factor", "second"] tags: ["lock", "screen", "u2f", "yubikey", "security", "key", "mode", "factor", "second"]
text: I18n.tr("Security key mode", "lock screen U2F security key mode setting") text: I18n.tr("Security key mode", "lock screen U2F security key mode setting")
description: I18n.tr("Alternative uses the passkey button. Second factor follows password or fingerprint.", "lock screen U2F security key mode setting") description: I18n.tr("'Alternative' lets the key unlock on its own. 'Second factor' requires password or fingerprint first, then the key.", "lock screen U2F security key mode setting")
visible: SettingsData.enableU2f && !root.lockU2fControlledByPrimary visible: SettingsData.enableU2f && !root.lockU2fControlledByPrimary
options: [I18n.tr("Alternative (OR)", "U2F mode option: key works as standalone unlock method"), I18n.tr("Second Factor (AND)", "U2F mode option: key required after password or fingerprint")] options: [I18n.tr("Alternative (OR)", "U2F mode option: key works as standalone unlock method"), I18n.tr("Second Factor (AND)", "U2F mode option: key required after password or fingerprint")]
currentValue: SettingsData.u2fMode === "and" ? I18n.tr("Second Factor (AND)", "U2F mode option: key required after password or fingerprint") : I18n.tr("Alternative (OR)", "U2F mode option: key works as standalone unlock method") currentValue: SettingsData.u2fMode === "and" ? I18n.tr("Second Factor (AND)", "U2F mode option: key required after password or fingerprint") : I18n.tr("Alternative (OR)", "U2F mode option: key works as standalone unlock method")
@@ -532,8 +521,8 @@ Item {
SettingsDropdownRow { SettingsDropdownRow {
settingKey: "lockU2fPamPath" settingKey: "lockU2fPamPath"
tags: ["lock", "screen", "pam", "u2f", "security", "key", "source", "service"] tags: ["lock", "screen", "pam", "u2f", "security", "key", "source", "service"]
text: I18n.tr("Security Key PAM Source") text: I18n.tr("Security Key PAM Source", "lock screen dedicated U2F PAM source setting")
description: SettingsData.lockU2fPamPath !== "" ? SettingsData.lockU2fPamPath : I18n.tr("Auto uses an installed or bundled key-only service.") description: SettingsData.lockU2fPamPath !== "" ? SettingsData.lockU2fPamPath : I18n.tr("Auto uses an installed or bundled key-only service.", "lock screen dedicated U2F PAM source setting")
visible: !root.lockU2fControlledByPrimary visible: !root.lockU2fControlledByPrimary
options: [root.authAutoLabel, root.authCustomLabel] options: [root.authAutoLabel, root.authCustomLabel]
currentValue: root.u2fAuthCurrentValue currentValue: root.u2fAuthCurrentValue
@@ -592,7 +581,7 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "lock" iconName: "lock"
title: I18n.tr("Lock Screen behaviour") title: I18n.tr("Behavior")
settingKey: "lockBehavior" settingKey: "lockBehavior"
StyledText { StyledText {
@@ -731,7 +720,7 @@ Item {
SettingsCard { SettingsCard {
width: parent.width width: parent.width
iconName: "monitor" iconName: "monitor"
title: I18n.tr("Lock Screen Display") title: I18n.tr("Display Assignment")
settingKey: "lockDisplay" settingKey: "lockDisplay"
StyledText { StyledText {
+206 -206
View File
@@ -4655,21 +4655,70 @@
] ]
}, },
{ {
"section": "lockPamPath", "section": "lockAppearance",
"label": "Authentication Source", "label": "Appearance",
"tabIndex": 11, "tabIndex": 11,
"category": "Lock Screen", "category": "Lock Screen",
"keywords": [ "keywords": [
"appearance",
"clock",
"date",
"font",
"lock",
"lockscreen",
"login",
"password",
"screen",
"security",
"time",
"typography",
"watch"
],
"icon": "palette",
"description": "Font used for the clock and date on the lock screen"
},
{
"section": "lockAuthSource",
"label": "Authentication",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"authenticate",
"authentication", "authentication",
"lock", "lock",
"lockscreen",
"login", "login",
"pam", "pam",
"password", "password",
"screen", "screen",
"security", "security",
"service", "service",
"source" "source",
] "uses"
],
"icon": "key",
"description": "Which PAM service the lock screen uses to authenticate"
},
{
"section": "lockPamPath",
"label": "Authentication Source",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"authenticate",
"authentication",
"lock",
"lockscreen",
"login",
"pam",
"password",
"screen",
"security",
"service",
"source",
"uses"
],
"description": "Which PAM service the lock screen uses to authenticate"
}, },
{ {
"section": "lockScreenVideoCycling", "section": "lockScreenVideoCycling",
@@ -4696,6 +4745,48 @@
], ],
"description": "Pick a different random video each time from the same folder" "description": "Pick a different random video each time from the same folder"
}, },
{
"section": "lockBehavior",
"label": "Behavior",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"behavior",
"bind",
"dbus",
"disable",
"external",
"integration",
"lock",
"lockscreen",
"login",
"loginctl",
"password",
"screen",
"security",
"signals"
],
"icon": "lock",
"description": "Bind lock screen to dbus signals from loginctl. Disable if using an external lock screen"
},
{
"section": "lockDisplay",
"label": "Display Assignment",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"assignment",
"display",
"lock",
"login",
"monitor",
"output",
"password",
"screen",
"security"
],
"icon": "monitor"
},
{ {
"section": "lockScreenVideoEnabled", "section": "lockScreenVideoEnabled",
"label": "Enable Video Screensaver", "label": "Enable Video Screensaver",
@@ -4737,7 +4828,7 @@
"security", "security",
"source" "source"
], ],
"description": "Managed by the primary PAM source." "description": "Managed by the primary PAM source"
}, },
{ {
"section": "loginctlLockIntegration", "section": "loginctlLockIntegration",
@@ -4784,7 +4875,32 @@
"u2f", "u2f",
"yubikey" "yubikey"
], ],
"description": "Managed by the primary PAM source." "description": "Managed by the primary PAM source"
},
{
"section": "lockLayout",
"label": "Layout",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"actions",
"appear",
"field",
"hidden",
"layout",
"lock",
"login",
"password",
"power",
"pressed",
"reboot",
"screen",
"security",
"shutdown",
"soon"
],
"icon": "lock",
"description": "If the field is hidden, it will appear as soon as a key is pressed."
}, },
{ {
"section": "_tab_11", "section": "_tab_11",
@@ -4801,116 +4917,6 @@
], ],
"icon": "lock" "icon": "lock"
}, },
{
"section": "lockAppearance",
"label": "Lock Screen Appearance",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"appearance",
"clock",
"date",
"font",
"lock",
"lockscreen",
"login",
"password",
"screen",
"security",
"time",
"typography",
"watch"
],
"icon": "palette",
"description": "Font used for the clock and date on the lock screen"
},
{
"section": "lockAuthSource",
"label": "Lock Screen Authentication",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"authentication",
"lock",
"lockscreen",
"login",
"pam",
"password",
"screen",
"security",
"service",
"source"
],
"icon": "key"
},
{
"section": "lockDisplay",
"label": "Lock Screen Display",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"display",
"lock",
"lockscreen",
"login",
"monitor",
"output",
"password",
"screen",
"security"
],
"icon": "monitor"
},
{
"section": "lockBehavior",
"label": "Lock Screen behaviour",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"behaviour",
"bind",
"dbus",
"disable",
"external",
"integration",
"lock",
"lockscreen",
"login",
"loginctl",
"password",
"screen",
"security",
"signals"
],
"icon": "lock",
"description": "Bind lock screen to dbus signals from loginctl. Disable if using an external lock screen"
},
{
"section": "lockLayout",
"label": "Lock Screen layout",
"tabIndex": 11,
"category": "Lock Screen",
"keywords": [
"actions",
"appear",
"field",
"hidden",
"layout",
"lock",
"lockscreen",
"login",
"password",
"power",
"pressed",
"reboot",
"screen",
"security",
"shutdown",
"soon"
],
"icon": "lock",
"description": "If the field is hidden, it will appear as soon as a key is pressed."
},
{ {
"section": "lockAtStartup", "section": "lockAtStartup",
"label": "Lock at startup", "label": "Lock at startup",
@@ -5063,25 +5069,18 @@
"tabIndex": 11, "tabIndex": 11,
"category": "Lock Screen", "category": "Lock Screen",
"keywords": [ "keywords": [
"alternative",
"button",
"factor", "factor",
"fingerprint",
"follows",
"key", "key",
"lock", "lock",
"login", "login",
"mode", "mode",
"passkey",
"password", "password",
"screen", "screen",
"second", "second",
"security", "security",
"u2f", "u2f",
"uses",
"yubikey" "yubikey"
], ]
"description": "Alternative uses the passkey button. Second factor follows password or fingerprint."
}, },
{ {
"section": "lockScreenShowMediaPlayer", "section": "lockScreenShowMediaPlayer",
@@ -5234,10 +5233,8 @@
"policy", "policy",
"screen", "screen",
"security", "security",
"sets",
"system" "system"
], ]
"description": "System PAM sets the authentication policy."
}, },
{ {
"section": "videoScreensaver", "section": "videoScreensaver",
@@ -7909,6 +7906,48 @@
], ],
"description": "Change the locale used for date and time formatting, independent of the interface language." "description": "Change the locale used for date and time formatting, independent of the interface language."
}, },
{
"section": "greeterAppearance",
"label": "Appearance",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"appearance",
"display manager",
"font",
"greetd",
"greeter",
"login",
"screen",
"typography"
],
"icon": "palette",
"description": "Font used on the login screen"
},
{
"section": "greeterAuth",
"label": "Authentication",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"auth",
"authentication",
"block",
"display manager",
"external",
"greetd",
"greeter",
"login",
"managed",
"pam",
"removes",
"services",
"stops",
"write"
],
"icon": "fingerprint",
"description": "DMS removes its managed block from /etc/pam.d/greetd and stops write services"
},
{ {
"section": "greeterAutoLogin", "section": "greeterAutoLogin",
"label": "Auto-login on startup", "label": "Auto-login on startup",
@@ -7942,6 +7981,25 @@
], ],
"description": "Skip the greeter password after boot until you sign out. Lock screen unlock is unchanged. Takes effect on the next reboot after sync." "description": "Skip the greeter password after boot until you sign out. Lock screen unlock is unchanged. Takes effect on the next reboot after sync."
}, },
{
"section": "greeterBehavior",
"label": "Behavior",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"behavior",
"display manager",
"greetd",
"greeter",
"last",
"login",
"remember",
"select",
"session"
],
"icon": "history",
"description": "Pre-select the last used session on the greeter"
},
{ {
"section": "greeterLockDateFormat", "section": "greeterLockDateFormat",
"label": "Date Format", "label": "Date Format",
@@ -7956,7 +8014,7 @@
"login", "login",
"screen" "screen"
], ],
"description": "Greeter only — format for the date on the login screen" "description": "Format the date on the login screen"
}, },
{ {
"section": "greeterDeps", "section": "greeterDeps",
@@ -8019,57 +8077,6 @@
], ],
"icon": "login" "icon": "login"
}, },
{
"section": "greeterAppearance",
"label": "Greeter Appearance",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"appearance",
"display manager",
"font",
"greetd",
"greeter",
"login",
"screen",
"typography"
],
"icon": "palette",
"description": "Font used on the login screen"
},
{
"section": "greeterBehavior",
"label": "Greeter Behavior",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"behavior",
"display manager",
"greetd",
"greeter",
"last",
"login",
"remember",
"select",
"session"
],
"icon": "history",
"description": "Pre-select the last used session on the greeter"
},
{
"section": "greeterStatus",
"label": "Greeter Status",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"display manager",
"greetd",
"greeter",
"login",
"status"
],
"icon": "info"
},
{ {
"section": "greeterFontFamily", "section": "greeterFontFamily",
"label": "Greeter font", "label": "Greeter font",
@@ -8086,29 +8093,6 @@
], ],
"description": "Font used on the login screen" "description": "Font used on the login screen"
}, },
{
"section": "greeterAuth",
"label": "Login Authentication",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"auth",
"authentication",
"block",
"display manager",
"external",
"greetd",
"greeter",
"login",
"managed",
"pam",
"removes",
"stops",
"writing"
],
"icon": "fingerprint",
"description": "DMS removes its managed block from /etc/pam.d/greetd and stops writing to it"
},
{ {
"section": "greeterRememberLastSession", "section": "greeterRememberLastSession",
"label": "Remember last session", "label": "Remember last session",
@@ -8145,27 +8129,43 @@
], ],
"description": "Pre-fill the last successful username on the greeter" "description": "Pre-fill the last successful username on the greeter"
}, },
{
"section": "greeterStatus",
"label": "Status",
"tabIndex": 31,
"category": "Greeter",
"keywords": [
"display manager",
"greetd",
"greeter",
"login",
"status"
],
"icon": "info"
},
{ {
"section": "greeterPamExternallyManaged", "section": "greeterPamExternallyManaged",
"label": "greetd PAM is externally managed", "label": "Use system PAM authentication",
"tabIndex": 31, "tabIndex": 31,
"category": "Greeter", "category": "Greeter",
"keywords": [ "keywords": [
"auth", "auth",
"authentication",
"block", "block",
"display manager", "display manager",
"external", "external",
"externally",
"greetd", "greetd",
"greeter", "greeter",
"login", "login",
"managed", "managed",
"pam", "pam",
"removes", "removes",
"services",
"stops", "stops",
"writing" "system",
"write"
], ],
"description": "DMS removes its managed block from /etc/pam.d/greetd and stops writing to it" "description": "DMS removes its managed block from /etc/pam.d/greetd and stops write services"
}, },
{ {
"section": "muxType", "section": "muxType",