From fea97b4aad61d69722de996445e3fbbd9dc6fc4d Mon Sep 17 00:00:00 2001 From: Jan Greimann <97512206+jgreimann@users.noreply.github.com> Date: Thu, 26 Feb 2026 15:05:06 +0100 Subject: [PATCH] Adjust SystemUpdate process (#1845) This fixes the problem that the system update terminal closes when the package manager encounters a problem (exit code != 0), allowing the user to understand the problem. Signed-off-by: Jan Phillip Greimann --- quickshell/Services/SystemUpdateService.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/quickshell/Services/SystemUpdateService.qml b/quickshell/Services/SystemUpdateService.qml index ecb30c72..fbe47975 100644 --- a/quickshell/Services/SystemUpdateService.qml +++ b/quickshell/Services/SystemUpdateService.qml @@ -259,7 +259,7 @@ Singleton { const terminal = Quickshell.env("TERMINAL") || "xterm"; if (SettingsData.updaterUseCustomCommand && SettingsData.updaterCustomCommand.length > 0) { - const updateCommand = `${SettingsData.updaterCustomCommand} && echo "Updates complete! Press Enter to close..." && read`; + const updateCommand = `${SettingsData.updaterCustomCommand} && echo -n "Updates complete! " ; echo "Press Enter to close..." && read`; const termClass = SettingsData.updaterTerminalAdditionalParams; var finalCommand = [terminal]; @@ -274,7 +274,7 @@ Singleton { } else { const params = packageManagerParams[pkgManager].upgradeSettings.params.join(" "); const sudo = packageManagerParams[pkgManager].upgradeSettings.requiresSudo ? "sudo" : ""; - const updateCommand = `${sudo} ${pkgManager} ${params} && echo "Updates complete! Press Enter to close..." && read`; + const updateCommand = `${sudo} ${pkgManager} ${params} && echo -n "Updates complete! " ; echo "Press Enter to close..." && read`; updater.command = [terminal, "-e", "sh", "-c", updateCommand]; }