Opening the launcher by hovering the frame edge requested the Overlay
layer via CompositorService.framePeerSurfacesUseOverlayForScreen(),
which resolves to whether the frame is configured for the screen and
is true in normal use. DankLauncherV2ModalConnected's
frameOwnsConnectedChrome requires the Top layer, so the overlay
request silently dropped connected-chrome anchoring: the launcher
opened dead-centered with a different animation instead of emerging
from the configured frame side.
The keybind/bar-button path already opens on the Top layer by passing
no overlay argument. The edge-hover trigger only runs in connected
frame mode to begin with (gated by usesConnectedFrameChromeForScreen
in this file's own eligible check), so there's no case where it needs
standalone/overlay behavior. Match the keybind path.
* launcher: add vpn connections as a search provider
Adds a dms_vpn built-in launcher plugin that lists every configured VPN
profile and toggles it on enter. Connected rows show a lock icon and a
Connected badge, in-progress rows show Connecting, everything else shows
a crossed-out key.
Profiles come from the network state the shell already fetches at
startup, so there is no new timer, process or request. The provider
returns nothing when the backend is not NetworkManager.
It ships without a trigger. A trigger prefix replaces the whole result
set, so claiming "vpn" would have hidden every application whenever
someone typed it to find their VPN client. Matching on the vpn keyword
instead keeps apps and profiles in the same list.
Co-Authored-By: Claude Opus 5 <[email protected]>
* launcher: hide vpn profiles on the home view without a trigger
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
* launcher: list vpn profiles when browsing the plugin
The empty query guard also applied when opening VPN from the Browse
section, so the plugin view came up empty. The plugin filter path now
opts out of the guard, while the home view still hides the profiles.
Co-Authored-By: Claude Opus 5 <[email protected]>
* launcher: stop matching vpn profiles on connect and disconnect
Keywords match by substring, so "connect" also matched "disconnect" and
listed connected profiles too. Picking one of those disconnected it.
Co-Authored-By: Claude Opus 5 <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Turn on do not disturb while a screen share is active so notification
popups and their contents stay off the shared screen. The unread dot and
the existing dnd bypasses are unaffected.
Detection reuses the screen sharing privacy indicator: niri cast ipc,
otherwise pipewire and xdg-desktop-portal. Neither source says when it
has finished reporting, so a share reading as gone is only acted on once
it stays gone for four seconds. Engaging stays immediate, and turning the
setting off releases right away since that is a user action rather than a
detection guess.
Turning dnd off by hand during a share is remembered against the sources
that were sharing at the time, so it holds for that share and across a
shell reload. A share started after that one has ended gets a fresh
decision.
Co-authored-by: Claude Opus 5 <[email protected]>
* feat(display): per-output ICC color profiles and color temperature
Rebuild of #3388 on current master: the previous branch was cut from an
older base and reverted unrelated fixes in the gamma stack and the display
settings UI.
ICC profiles:
- core/internal/icc: ICC v2/v4 parser (TRC, LUT8/16 and parametric curves,
vcgt, description/version/color space) plus gamma ramp generation, with
synthetic coverage and optional vendor-profile tests (ICC_TEST_DIR).
- wayland manager: load iccProfiles from the compositor's DMS config dir,
build the ramp from the profile when one is set (falling back to the
temperature ramp when it is missing or unparsable), and re-apply on
output hotplug and after resume.
- ICC ramps apply while the night light schedule is disabled; outputs
without a profile keep an identity ramp.
- desc/mluc offsets are validated before slicing, so a malformed profile
returns an error instead of panicking the daemon.
Per-output temperature:
- outputTemps in the same config; SetOutputTemp accepts 1000-10000K and the
Display Config slider exposes 3000-10000K, which matters for displays
calibrated at a higher white point (e.g. a 7000K profile).
Gamma control lifecycle:
- needsControls() now keeps the controls alive for configured ICC profiles
and per-output temperatures, so toggling the night light off no longer
destroys the controls and drops the ramps.
- Re-apply paths clear the per-output dedup state instead of adding a
manager-level guard, which would have suppressed contrast-only writes and
the post-resume forced resend (#1235), and left a recreated control
without a ramp.
- Monitor sleep/disconnect still re-establishes controls when an output
comes back.
IPC / CLI / UI:
- wayland.icc.{getStatus,apply,remove,listOutputs,setTemp,getTemps}
- dms icc list | info <file> | apply <output> <file> | remove <output> | status
- Display Config output card gains a Color Profile row (browse/apply/remove
with description, version, color space and active state) and a per-output
color temperature slider, backed by Services/ICCService.qml.
Config path:
- DMSConfigDir() follows the compositor layout (niri/dms, hypr/dms,
mango/dms) via the shared compositor detection and utils.XDGConfigHome(),
replacing the hardcoded niri path in both the manager and `dms icc`.
Tests: TZ=UTC go test ./... (60 packages ok), including red/green coverage
for the icc parser bounds checks and needsControls().
* feat(icc): add `dms icc set-temp` and show per-output temps in `status`
The per-output temperature override was reachable from the Display Config
slider and from `wayland.icc.setTemp` over IPC, but not from the CLI.
- `dms icc set-temp <output> <kelvin>` (alias `setTemp`) sets a per-output
override, 1000-10000K, and 0 clears it so the output follows the night
light schedule again. Range checking matches the daemon so an invalid
value fails in the CLI instead of over IPC.
- `dms icc status` gains a Temp column (the override in K, or `schedule`),
so an override can be verified without opening the settings UI.
Verified against a running daemon: `dms icc status` reports 7000K for the
three overridden outputs and `schedule` for the remaining one.
* feat(icc): treat the per-output temperature as the profile's reference white point
The per-output temperature was documented as the white point a profile was
produced at, but an output with a profile ignored it entirely: the ramp was
generated from the profile and the temperature only applied to outputs
without one (or as the fallback when a profile failed to parse). A display
calibrated at 7000K therefore got the profile ramp, and enabling the night
light had no effect on it at all.
- `ProfileRampWithTemp` composes the profile ramp with the ratio between the
target temperature ramp and the reference ramp, so the temperature is the
white point the profile describes and the night light shifts relative to
it.
- `applyGamma` passes the night light temperature as the target, and
`noTempTarget` when the schedule is disabled, which leaves profiled
outputs at their reference white point and drives plain outputs with the
neutral ramp.
- The re-apply sentinel stays 0, so it cannot collide with an applied
temperature.
Covered by TestProfileRampWithTemp (reference == target is a no-op, warmer
and cooler targets move the expected channels).
Also: `dms icc set-temp` help text describes the reference-white-point
semantics.
* fix(icc): load the configured profiles even when controls already exist
Restoring the upstream "output returned, re-establishing controls" branch
made the registry handler establish the gamma controls before the startup
post runs, and that post returned early on `m.controlsInitialized`, so the
configured ICC profiles and per-output temperatures were never attached:
every output reported "(none)" and the night light ran with defaults until
the user re-applied a profile by hand.
- `initializeControlsAndICC` (the startup post) loads the configuration
first and only creates the controls when they are missing.
- The loading is split into `loadConfiguredICC` / `applyConfiguredICCForOutput`
so it can also run per output.
- A hotplugged output now gets its configured profile and temperature as soon
as its name is known (name handler) or when its control is created, which
also makes the "re-applies on hotplug" claim in the description true.
- After attaching, the output's dedup state is cleared so the ramp is written.
Covered by TestManager_LoadConfiguredICCWhenControlsAlreadyExist and
TestManager_AttachConfiguredICCForNamedOutput.
* fix(icc): make the per-output temperature an actual target
The per-output value was treated as the white point a profile was produced
at, which meant a display with a profile never changed when the user set a
temperature: the profile ramp was applied as measured and the value only
mattered when a night light target existed. Per-display temperatures were
therefore unusable on profiled outputs while the night light was disabled,
which is the normal state for users who want each monitor at its own value.
- `effectiveTempTarget` decides per output: a per-output override wins over
the night light schedule, the schedule applies when there is no override,
and `noTempTarget` means neither. `0` is "no override", not 0K.
- `applyGamma` composes the override on top of the profile ramp, treating the
profile as measured at 6500K (D65), and drives outputs without a profile
with the same target so both paths agree.
- `dms icc set-temp` help text and the Display Config slider description go
back to describing an independent per-output temperature.
Covered by TestEffectiveTempTarget (override wins, schedule fallback, none)
and the updated TestProfileRampWithTemp (7000K cools, 5000K warms relative to
the 6500K reference).
* feat(icc): show the profile details in Display Config
The profile row only showed the description, so there was no way to tell
which profile a display actually has applied (whitepoint, curve type, file
provenance) without leaving the settings page.
- `ICCStatus` carries the descriptive metadata: class, tone-curve kind (plus
gamma or table size), vcgt channels/entries, white point chromaticity with
a derived CCT and standard illuminant name, file size and mtime.
- `internal/icc` gains `WhitePointXY`, `WhitePointCCT` (McCamy),
`WhitePointName` (D50/D65) and `TRCKind`, all covered by tests.
- Display Config's Color Profile row gets an info button that opens
`ICCProfileInfoModal` with those fields and the profile path, alongside
the existing browse/remove actions.
- `dms icc info` reports the white point as name/xy/CCT instead of raw XYZ.
* fix(icc): keep the daemon, the state snapshot and the temp slider honest
A malformed profile could still take the daemon down, the ICC getters ran off
the wayland actor goroutine, the pushed state hid a removal, and the
per-output temperature slider dropped wheel changes.
- `internal/icc`: the tag table was sized with `uint32` arithmetic, so
`tagCount*12` wrapped (`0x15555556*12 == 8`) and a 140-byte profile passed
the bounds check, allocated ~4.3 GB and then panicked. `ParseFile` runs on
the wayland actor goroutine, which has no `recover()`, so a bad profile
persisted in `wayland.json` took the daemon down at startup. The count is now
compared against the bytes that are actually left before anything is sized
with it.
- The manager publishes an ICC snapshot (`iccStatus`/`iccTemps`) whenever the
actor changes an output's profile or temperature, and `GetICCStatus`/
`GetOutputTemps` serve that snapshot instead of ranging `m.outputs` and
reading fields the actor owns. That removes the data race reported by
`go test -race` for `dms icc status` running against a hotplug, and keeps the
per-profile `os.Stat` off the night light animation path, where it ran on
every `updateStateFromSchedule` (including each 25 K step).
- `State.ICCProfiles`/`OutputTemps` drop `omitempty`, so removing the last
profile pushes `{}` instead of omitting the key: the QML truthiness guard
then clears `ICCService.status` instead of leaving the removed profile on
screen with a green "active" dot.
- `removeOutputByRegistryName` (extracted from the registry remove handler)
deletes the `outputNames`/`outputRegNames` entries along with the output, so
a disconnected monitor stops being listed by `dms icc status`/`listOutputs`,
and a rebound `wl_output` reusing the released object ID cannot attach the
previous monitor's profile from the stale name.
- The per-output temperature slider sets `wheelEnabled: false` like the other
drag-finished sliders: `DankSlider`'s wheel handler assigns `value` and emits
`sliderValueChanged` without `sliderDragFinished`, so scrolling dropped the
change, froze the label on the scrolled value and destroyed the value binding.
Covered by TestParseBytesTagTableBounds (allocates 4,299,161,600 bytes at
parser.go:138 and dies with an unrecovered fatal error on the previous
commit), TestManager_ICCStatusServesPublishedSnapshot,
TestManager_RemoveOutputByRegistryNamePrunesNames and
TestManager_ICCStatusConcurrentPublishAndRead; a temporary copy of the getter
test against the previous commit reports DATA RACE and passes here.
* fix(icc): keep the attached profile when a gamma control is re-created
`setupOutputControls` stored a fresh `outputState` for every output it touched,
and `createControls` calls it whenever the controls are rebuilt, so recreating a
control dropped the output's `iccPath`/`iccProfile`/`outputTemp` — configured
state that does not belong to the control. The path is dormant today because
`destroyControls` only runs when nothing is configured (`needsControls()` covers
`ICCProfiles`/`OutputTemps`), but the snapshot published after `createControls`
would then report whatever the rebuilt state holds instead of the profile the
display is configured with.
`controlStateFor` reuses the state of a known output and resets only what belongs
to the new control: the ramp bookkeeping and the failure budget (rampSize,
failed, retryCount, lastFailTime, lastTemp, lastGamma, lastContrast). A control
that has not reported gamma_size yet has to receive its ramp again, while the
profile and the per-output temperature survive. An output seen for the first
time still starts from a clean state.
Covered by TestManager_ControlStateReuseKeepsAttachedICC.
* fix(icc): keep the config a real snapshot and make the per-output temperature apply
Third review round.
- `Config` is copied by value all over the manager, but `ICCProfiles` and
`OutputTemps` are maps, so every copy aliased the ones the manager writes under
`configMutex`. `updateStateFromSchedule` stored such a copy in `m.state` and it
was marshalled on the connection writer goroutine while `ApplyICC` stored a
profile from the IPC goroutine (`fatal error: concurrent map iteration and map
write`, which no `recover()` catches); `SaveConfig` marshalled its copy after
the unlock, and `loadConfiguredICC`/`attachConfiguredICC` indexed the maps after
releasing the lock. Every copy that outlives the lock is cloned now
(`cloneConfig`/`configSnapshot`), so a value copy is a snapshot again.
- `SetOutputTemp` never created the gamma controls. On a default install (night
light off, gamma 1.0, contrast 1.0, no profile, no override) they do not exist,
so the `Range` over `m.outputs` matched nothing: the value was written to
`wayland.json`, no ramp was applied, and the settings slider snapped back to
"Default" until a daemon restart. It now persists first, creates the controls
through `ensureOutputControls` (shared with `ApplyICC`), and pushes the state
from the actor, and the published temperatures report the configured value even
before an output is known.
- A TRC is not a video card gamma ramp: `rTRC`/`gTRC`/`bTRC` describe the
display's own transfer function, so a gamma-2.2 profile was written as
`t^(1/2.2)` — mid gray 0.5 became 47909/65535 — washing the display out instead
of correcting it. `ApplyICC` refuses a profile without `vcgt`, the attach path
skips one with a warning, and `GenerateGammaRamp` returns an error instead of
falling back to the TRC or to an identity ramp. TRC stays profile metadata
(`dms icc info`, the settings dialog).
- `icc: applied ICC ramp` was logged at Info on every 25 K animation step; it is
Debug now, which is where a per-step message belongs.
- `I18n.tr("No information available")` in the profile info modal passes its
translator context, like every other string this PR adds.
Covered by TestManager_ConfigSnapshotOwnsItsMaps,
TestManager_ConfigSnapshotConcurrentMarshal (the previous commit dies with
`fatal error: concurrent map iteration and map write`),
TestManager_SetOutputTempWithoutControlsPublishesValue (the previous commit
reports 0 for the value it just stored), TestGenerateGammaRampRequiresVCGT, and
the updated TestProfileRampWithTemp, whose fixture now carries an identity vcgt
table instead of relying on an empty profile.
* fix(icc): push the state when only the ICC part changed
Found while sweeping the same class of problem: `stateChanged` compared only the
schedule fields, so a change that touches nothing else — applying or removing a
profile, `dms icc set-temp` — was treated as "no change" and the notifier never
pushed it. The settings page then only caught up because the UI path calls
`requestStatus()` afterwards, and the CLI path did not catch up at all, which is
the symptom the omitempty fix was meant to remove.
`iccStateChanged` compares the ICC profile status and the per-output
temperatures, so those changes reach the subscribers on their own. Covered by
the new TestStateChanged cases (profile applied, profile removed, profile
description changed, output temp changed, unchanged ICC state); the four
change cases report `stateChanged() = false` on the previous commit.
* fix(icc): keep the night light state, prune names without a control, use a 0 sentinel
Fifth review round.
- `SaveICCConfig` replaces `SaveConfig` on the three ICC paths (apply, remove,
set-temp). Writing the daemon's whole config persisted the night light fields
it happens to hold in memory: with the night light on, applying a profile
stored `"Enabled": true`, and since the shell only ever sends
`wayland.gamma.setEnabled` when the mode is on, turning it off afterwards (an
in-memory change on the daemon side, no write) left that `true` on disk — after
log out/in the daemon came up driving the schedule while the UI showed night
mode off, with no way to resync short of a toggle. The ICC save now reads the
file and rewrites only `iccProfiles`/`outputTemps`, so the fields the shell
owns stay as they are.
- `removeOutputByRegistryName` resolved the output from `m.outputs`, which only
has entries once the gamma controls exist. On a default install (night light
off, no profile, no override) no control is ever created, so a disconnected
monitor kept its `outputNames`/`outputRegNames` entries for the life of the
daemon: `dms icc status`/`listOutputs` listed monitors that were gone, and both
maps grew with every dock/undock cycle. The object ID is resolved from
`m.outputRegNames` (populated for every `wl_output`), the name entries are
dropped before the output state is looked up, and a state that is known without
a registry name still falls back to matching its own.
- The Display Config temperature row used `7000` as its fallback for an output
with no override. `publishICCState` only copies entries with `temp != 0`, so
the value is absent rather than `0` for an unconfigured output: the card claimed
"7000K" while the daemon drove the night light or neutral, and a user who
deliberately set 7000K got the "no override" colouring because the highlight
tested `!== 7000`. The sentinel is `0` now, which is what the `Default` label
branches and the "is overridden" tests were written against.
Covered by TestSaveICCConfigKeepsNightLightFields (the previous commit brings the
night light back on after a restart), TestManager_RemoveOutputByRegistryNameWithoutControl
(the previous commit keeps an unplugged monitor listed) and the existing
TestManager_RemoveOutputByRegistryNamePrunesNames.
* fix(icc): validate the CLI arguments and the IPC parameters of the ICC commands
Sweep of the two surfaces the review has not looked at yet, so the failures are
found here instead of in the next round.
- `dms icc apply` copied the profile into the config directory before asking the
daemon, and only the *parse* was checked locally. A profile the daemon refuses
(no `vcgt` table, non-RGB color space) was therefore left in the profile
directory for `dms icc list` to keep offering, and an IPC failure left the copy
behind as well. The command now checks the same rules the daemon enforces
before copying anything, and removes the copy it just made when the request
fails (a file that was already there is left alone).
- `dms icc list` marks a profile without a `vcgt` table, so the rule that makes
`apply` refuse it is visible where the profiles are listed.
- `ApplyICC`/`RemoveICC`/`SetOutputTemp` reach the manager over IPC with whatever
the caller sent: an empty (or whitespace-padded) output name used to be
persisted as an entry in `wayland.json` that no `wl_output` can ever match, and
a relative profile path was stored to be resolved again on the next start, from
a different working directory. Both are rejected now, before anything is
written.
Verified with the built CLI against the previous binary: with a profile that has
no vcgt table, `dms icc apply` now exits before touching the config directory
(`residual=[]`) where the previous one copied the file and went on to the IPC
(`residual=[nogamma.icc]`); with a valid profile and no daemon reachable, the
previous one leaves `vcgt.icc` behind and this one does not. Covered by
TestManager_RejectsInvalidICCArguments.
* fix(icc): apply the user gamma and contrast on profiled outputs
* fix(icc): recreate failed controls without the night light and allow clearing a per-output temp
* test(icc): cover the recreated control and the cleared temperature override
Follow-up on d55d3d1f, which fixed both points without tests:
- TestManager_RecreateOutputControlFollowsNeedsControls pins the predicate: with
the night light off and nothing configured there is nothing to recreate, and
with a configured profile or a per-output temperature the control has to be
recreated. Both configured cases return nil on 9226251c.
- TestManager_SetOutputTempZeroClearsTheOverride pins what the reset button in
Display Config does end to end: the stored value and the published entry both
disappear, so the row reads "Default" and the output follows the schedule.
Also keeps the reset button's slot instead of revealing it on demand. The
temperature row shares its column with the slider below it, so the height change
between "Default" (no button) and an override moved the slider 14 px under the
pointer while it was being dragged; the button is now always laid out and only
its opacity and enabled state follow the override, which also lets the label
width drop the conditional.
* fix(icc): replicate a one-channel vcgt and keep the temp slider in sync
* fix(icc): release idle gamma controls and push the output list
* fix(icc): dedupe ramps on the effective target
* fix(icc): never overwrite a same-named profile in the config dir
---------
Co-authored-by: bbedward <[email protected]>
Hyprland's workspace refactor (hyprwm/Hyprland#16140) broke
Hyprland.focusedWorkspace.monitor as a way to find the focused screen
(quickshell-mirror/quickshell#1119). Quickshell already exposes
Hyprland.focusedMonitor directly, so read the monitor from there
* fix(battery): report when no charge threshold exists instead of faking success
* fix(battery): hide the charge limit controls when there is no battery
Follow-up to the review on #3385: the new explanation showed on
desktops and VMs with no battery at all, where it reads as a fault
report about hardware the machine was never going to have.
Both the explanation and the apply button now require
BatteryService.batteryAvailable. Hiding the button there is the same
point the pull request makes elsewhere: offering a control that cannot
work is what produced the false success in the first place. A machine
without a battery has no charge threshold to write to, so the limit was
never applicable.
BatteryService.batteryAvailable is already the gate used twice in this
file for the same reason.
* Island: Added option to choose the control center icon to be either
Battery gauge or Connectivity
* Add Control Center to settings search index
* island: keep connectivity dim opacity off the blink target
DankBlink animates opacity and forces it back to 1.0 when it stops,
which broke the icon's binding and left the disabled state fully opaque.
When a backend runs the upgrade in a terminal (paru/yay or a custom
command), the popout unconditionally reopened itself once the terminal
closed. Add an updaterReopenAfterUpgrade setting (default: on, keeping
current behavior) so users can opt out and keep the popout closed after
the terminal exits.
* idle inhibitor: add duration presets and timed expiry
Right-click the bar widget or expand the Control Center pill to keep the
system awake for a set duration rather than only indefinitely. The deadline
is persisted so it survives a shell restart, and is re-checked on resume
because timers stop across suspend.
Adds `dms ipc call inhibit enableFor <minutes>`, and `inhibit status` now
reports the remaining time.
* idle inhibitor: add translator context to new duration strings
* refactor(systemtray): convert overflow menu and context menu to DankPopout
* fix(systemtray): correct window-local anchor position mapping and enable contentHandlesKeys for tray menu keyboard navigation
* fix(systemtray): force active focus on tray menu content
* fix(systemtray): address inline PR review feedback
- Force active focus on open for key navigation
- Unregister menu only if matching active instance
- Map anchor trigger position relative to screen origin
* fix(systemtray): gate onMenuOpenChanged on useOverflowPopup
- Prevent registering overflowPopout in inline expansion mode
* fix(systemtray): correct context menu positioning in overflow popout
- Handle screen global coordinate mapping for both connected and standalone popout modes
* fix(systemtray): handle per-screen backend and vertical bar anchor Y offset
- Use overflowPopout.useConnectedBackend for per-screen discriminator
- Add vertical anchor Y centering offset in showForTrayItem
* fix(systemtray): center overflow popout on vertical bar caret
- Add vertical orientation anchor Y offset in _openOverflowAt
* fix(systemtray): clear submenu entryStack on tray menu open
- Expose entryStack alias on trayMenuContentRoot
- Clear entryStack on trayMenuPopout onOpened to avoid submenu state leakage
* updated dank to support aqueous
* further updates
* aqueous support work
* updated to support workspace options better in aqueous
* added blur to dms shell for aqueous
* added keybinding update
* remove unneeded blur
* clean up per claud review
* swapped to ipc
* aqueous: move IPC integration to QML, delete test fixtures (since we
dont have a QML test structure even setup), delete in-repo docs
* fix staticcheck
* aqueous: consolidate more aqueous specific stuff
* add aqueous logo
---------
Co-authored-by: Zoey <[email protected]>
Root cause: we were creating a `Date` that did not exist in my timezone
(Santiago, Chile) because of DST. The JS engine decided to pick the
previous day, so I ended up with two times 5 September.
Fix: introduce a `DateOnly` object that internally uses UTC (to prevent
DST issues). Other parts of the system still use `Date`, which
probably should be refactored to use `DateOnly` as well (maybe in an
upcoming PR?). In the meantime, we provide a function to export a
`DateOnly` as a `Date`, using noon as the time instead of midnight
(because there are no DST changes at noon AFAIK).
We tested this manually (see the attached screenshots), but didn't find
a suitable place for automated tests.
port 1.6
* fix(dash): dim today button when on current month and hide tooltip on click
* fix(dash): use Theme.shortDuration for calendar today button opacity animation
* refactor(dash): use standard DankActionButton tooltipText for calendar today button
* chore(dash): remove unused todayButton id
* fix(dash): allow returning to today when another day in current month is selected
* fix(bar): keep widget content on whole pixels
Bar widgets centre their content inside a box of
widgetThickness - horizontalPadding * 2, and Qt rounds the offset of a
centred anchor to whole pixels. When the content and that box have
different parity the exact offset falls on a half pixel, Qt rounds it
away from zero and the content renders half a pixel above the centre.
Widgets drawn from rectangles, such as the workspace switcher, compute
their own snapped height and stay exactly centred, which is why they
look right next to everything else in #3074.
With the stock configuration this is the normal case: the bar is 40 px,
the box is 14 px and barIconSize returns round((40 / 48) * 18) = 15.
Two sizes now round to whole pairs of pixels. The icon size, so that it
matches the parity of the box, and widgetThickness, because the box
inherits its parity from there (the padding is doubled, so it never
changes it). Going through every innerPadding from 0 to 16, nine of the
seventeen configurations currently put the icon on a half pixel and none
of them do afterwards. The 48 px default bar is untouched, the sizes
that change do so by one pixel.
Measured in a nested Hyprland at scale 1, ink centroid of the widget
content relative to the centre of its pill, before and after:
launcher -0.50 +0.00
weather -0.81 -0.52
clipboard -1.49 -0.93
notifications +0.03 +0.46
battery -0.63 -0.49
bluetooth -0.53 -0.03
Every icon moves down by half a pixel. What remains matches the ink
asymmetry of the individual glyphs, measured separately at an exact
position, and is not a placement error.
Two things this does not cover. On a fractional or HiDPI scale
horizontalPadding can land on a half pixel, which puts the box back
between the grid lines, and a text only widget such as the clock has a
line box of 15 px at the default font size, which cannot sit exactly on
the centre of a 28 px pill no matter how it is rounded.
Closes#3074
* fix(bar): give bar text a line box that can be centred
A widget without an icon is centred as one line box, and the same parity
rule applies to it as to the icon in the commit before this one. At
fontSizeSmall the line box of the bar font is 15 px tall, so on a 28 px
pill it cannot sit on the centre no matter which way the offset is
rounded, and the clock reads about half a pixel high next to everything
else. One step up the box is 16 px and it lands on the grid.
Only the branch the standard bar uses changes. The 0.9 branch below a
scale of 0.75 already comes out at 14 px, and the fontSizeMedium branch
above 1.25 is left alone because there the next even box is two steps
away, which would be a bigger change than this is worth.
Same session and same measurement as the previous commit, ink centroid
of the widget content relative to the centre of its pill:
clock and date -0.58 +0.05
battery -0.63 -0.05
weather -0.82 -0.28
The bar font goes from 12 px to 13 px, which is the visible part of this
and the reason it is a separate commit. It can be dropped without
touching the icon fix.
* bar: snap widget thickness to even device pixels and pick text sizes by line box parity
* bar: snap bar thickness to even so the pill centres on whole pixels
* bar: share the bar thickness formula so dock, osd and popouts stay in step
* dock: read the bar clearance at the compositor screen scale
---------
Co-authored-by: bbedward <[email protected]>
* feat(theme): add a selectable source color mode for wallpaper palettes
DMS always seeds the palette from matugen's most dominant candidate
(--source-color-index 0, hardcoded at both call sites). When a large
muted region outvotes a smaller vivid one, a visibly warm wallpaper
produces a cold palette: one image here goes to #8ad0ee where the warm
subject is at hue 46.
Adds a Source Color setting with seven values. Dominant is the default
and is byte-identical to today. Colorful is computed in Go before
matugen runs: quantize the image (Wu for the starting clusters, then a
weighted k-means in Lab), score the result the way caelestia-cli does,
and hand matugen the resulting hex. Its scoring walks a chroma/tone bar
down from 20 until something clears it, which biases the pick toward a
colorful, well-lit color rather than whichever muted color covers the
most pixels. The remaining five map to matugen's --prefer.
- core/internal/matugen/sourcecolor.go: extraction, scoring, and the
one helper both matugen call sites now share
- buildOnce resolves the seed once, before the StockColors branch, so
the dry run and the real run cannot disagree about it
- extraction failure logs a warning and falls through to matugen's own
extraction; it never fails a theme build
- --prefer arrived in matugen 4.1, so it is gated separately from the
existing isV4 check; on 4.0.x those five modes degrade to the
dominant color instead of aborting on an unknown argument
- --source-mode on generate and queue, plus sourceMode on the socket
handler
- Source Color dropdown in Theme & Colors, defaulting to Dominant
Adds github.com/Nadim147c/material/v3 (Apache-2.0, no dependencies) for
HCT conversions, Wu quantization and the dislike analyzer. Its
QuantizeCelebi is not used: it returns after one unconverged iteration
and its Lab.DistanceSquared is a dot product rather than a distance, so
it collapses most of an image into a single cluster.
* fix(theme): address review feedback on source color mode
Two points from review on #3020.
The quantize comment pointed at a FOLLOWUPS file that does not exist in
this repository. Replaced the reference with the measurement it was
standing in for, so the claim is self-contained.
setMatugenSourceMode called Theme.generateSystemThemesFromCurrentTheme()
directly on top of the regenSystemThemes onChange hook that Spec.set
already dispatches. Both feed a 100ms debounce so it was one generation
either way, but the direct call was redundant and is gone.
* fix(theme): keep {{image}} resolvable in colorful mode
Colorful resolves the seed itself and calls matugen with a hex source, which
leaves matugen's {{image}} unset: the builtin pywalfox template and any user
template using the keyword render the literal string "Null".
Pass the wallpaper path alongside dank16 in --import-json-string, as suggested
in review, so those templates keep working unedited. The path is made absolute
to match what matugen renders for {{image}} in the other modes.
* fix(theme): cut translator terms on the source color dropdown
Per-mode descriptions were seven of the fifteen new terms this branch adds,
and five of them differed by a single adjective. Drop them: the dropdown row
already describes what the setting does, and the docs cover each mode.
Marlon Kranz