From 83a5e149efa850ccaf9434efa4121a518feb8024 Mon Sep 17 00:00:00 2001 From: barelyprofessional <150058423+barelyprofessional@users.noreply.github.com> Date: Sun, 30 Jun 2024 20:02:05 +0800 Subject: [PATCH] Replaced logging of the disconnection exception as it basically never had any value. Serializing provides a lot more useful information including the reason the server sent --- KfChatDotNetKickBot/KickBot.cs | 1 + KfChatDotNetKickBot/Services/Shuffle.cs | 2 +- KfChatDotNetKickBot/Services/Twitch.cs | 2 +- KfChatDotNetWsClient/ChatClient.cs | 2 +- KickWsClient/KickWsClient.cs | 2 +- ThreeXplWsClient/ThreeXplWsClient.cs | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/KfChatDotNetKickBot/KickBot.cs b/KfChatDotNetKickBot/KickBot.cs index c31c07f..345f239 100644 --- a/KfChatDotNetKickBot/KickBot.cs +++ b/KfChatDotNetKickBot/KickBot.cs @@ -409,6 +409,7 @@ public class KickBot private void OnKfWsDisconnected(object sender, DisconnectionInfo disconnectionInfo) { _logger.Error($"Sneedchat disconnected due to {disconnectionInfo.Type}"); + _logger.Error(JsonSerializer.Serialize(disconnectionInfo)); } private void OnKfWsReconnected(object sender, ReconnectionInfo reconnectionInfo) diff --git a/KfChatDotNetKickBot/Services/Shuffle.cs b/KfChatDotNetKickBot/Services/Shuffle.cs index b671f34..695aae7 100644 --- a/KfChatDotNetKickBot/Services/Shuffle.cs +++ b/KfChatDotNetKickBot/Services/Shuffle.cs @@ -99,7 +99,7 @@ public class Shuffle : IDisposable private void WsDisconnection(DisconnectionInfo disconnectionInfo) { _logger.Error($"Client disconnected from Shuffle (or never successfully connected). Type is {disconnectionInfo.Type}"); - _logger.Error(disconnectionInfo.Exception); + _logger.Error(JsonSerializer.Serialize(disconnectionInfo)); OnWsDisconnection?.Invoke(this, disconnectionInfo); } diff --git a/KfChatDotNetKickBot/Services/Twitch.cs b/KfChatDotNetKickBot/Services/Twitch.cs index f9165e5..24a0f46 100644 --- a/KfChatDotNetKickBot/Services/Twitch.cs +++ b/KfChatDotNetKickBot/Services/Twitch.cs @@ -84,7 +84,7 @@ public class Twitch private void WsDisconnection(DisconnectionInfo disconnectionInfo) { _logger.Error($"Client disconnected from the chat (or never successfully connected). Type is {disconnectionInfo.Type}"); - _logger.Error(disconnectionInfo.Exception); + _logger.Error(JsonSerializer.Serialize(disconnectionInfo)); } private void WsReconnection(ReconnectionInfo reconnectionInfo) diff --git a/KfChatDotNetWsClient/ChatClient.cs b/KfChatDotNetWsClient/ChatClient.cs index 2fd413f..a8db3b6 100644 --- a/KfChatDotNetWsClient/ChatClient.cs +++ b/KfChatDotNetWsClient/ChatClient.cs @@ -101,7 +101,7 @@ public class ChatClient private void WsDisconnection(DisconnectionInfo disconnectionInfo) { _logger.Error($"Client disconnected from the chat (or never successfully connected). Type is {disconnectionInfo.Type}"); - _logger.Error(disconnectionInfo.Exception); + _logger.Error(JsonSerializer.Serialize(disconnectionInfo)); OnWsDisconnection?.Invoke(this, disconnectionInfo); } diff --git a/KickWsClient/KickWsClient.cs b/KickWsClient/KickWsClient.cs index 7a2f7d3..7643124 100644 --- a/KickWsClient/KickWsClient.cs +++ b/KickWsClient/KickWsClient.cs @@ -92,7 +92,7 @@ public class KickWsClient private void WsDisconnection(DisconnectionInfo disconnectionInfo) { _logger.Error($"Client disconnected from the chat (or never successfully connected). Type is {disconnectionInfo.Type}"); - _logger.Error(disconnectionInfo.Exception); + _logger.Error(JsonSerializer.Serialize(disconnectionInfo)); OnWsDisconnection?.Invoke(this, disconnectionInfo); } diff --git a/ThreeXplWsClient/ThreeXplWsClient.cs b/ThreeXplWsClient/ThreeXplWsClient.cs index ae3a4ad..9492608 100644 --- a/ThreeXplWsClient/ThreeXplWsClient.cs +++ b/ThreeXplWsClient/ThreeXplWsClient.cs @@ -125,7 +125,7 @@ public class ThreeXplWsClient private void WsDisconnection(DisconnectionInfo disconnectionInfo) { _logger.Error($"Client disconnected from the chat (or never successfully connected). Type is {disconnectionInfo.Type}"); - _logger.Error(disconnectionInfo.Exception); + _logger.Error(JsonSerializer.Serialize(disconnectionInfo)); OnWsDisconnection?.Invoke(this, disconnectionInfo, _connectionId); }