Salastil/KfChatDotNet
1
0
Fork 0
mirror of https://github.com/barelyprofessional/KfChatDotNet.git synced 2026-05-02 04:22:04 -04:00
Code Issues Packages Projects Releases Wiki Activity

Using a proper cancellation token for commands rather than the shared one, so timeouts should be handled more gracefully and also hopefully maybe actually consistently work. Also added error reporting

Browse Source
This commit is contained in:
barelyprofessional
2025-12-10 20:06:15 -06:00
parent 9ee114c466
commit d83b357ec3
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
KfChatDotNetBot/Services/BotCommands.cs
View File

@@ -122,21 +122,37 @@ internal class BotCommands
private async Task ProcessMessageAsync(ICommand command, MessageModel message, UserDbModel user, GroupCollection arguments) private async Task ProcessMessageAsync(ICommand command, MessageModel message, UserDbModel user, GroupCollection arguments)
{ {
var task = Task.Run(() => command.RunCommand(_bot, message, user, arguments, _cancellationToken), _cancellationToken); var cts = new CancellationTokenSource(command.Timeout);
var task = Task.Run(() => command.RunCommand(_bot, message, user, arguments, cts.Token), cts.Token);
try try
{ {
await task.WaitAsync(command.Timeout, _cancellationToken); await task.WaitAsync(command.Timeout, cts.Token);
}
catch (OperationCanceledException e)
{
_logger.Error($"{command.GetType().Name} invoked by {user.KfUsername} timed out");
_logger.Error(e);
await _bot.SendChatMessageAsync(
$"{user.FormatUsername()}, {command.GetType().Name} failed due to a timeout :(", true,
autoDeleteAfter: TimeSpan.FromSeconds(10));
return;
} }
catch (Exception e) catch (Exception e)
{ {
_logger.Error("Caught an exception while waiting for the command to complete"); _logger.Error($"{command.GetType().Name} invoked by {user.KfUsername} failed");
_logger.Error(e); _logger.Error(e);
await _bot.SendChatMessageAsync(
$"{user.FormatUsername()}, {command.GetType().Name} failed due to a retarded error :(", true,
autoDeleteAfter: TimeSpan.FromSeconds(10));
return; return;
} }
if (task.IsFaulted) if (task.IsFaulted)
{ {
_logger.Error("Command task failed"); _logger.Error($"{command.GetType().Name} invoked by {user.KfUsername} faulted");
_logger.Error(task.Exception); _logger.Error(task.Exception);
await _bot.SendChatMessageAsync(
$"{user.FormatUsername()}, {command.GetType().Name} failed due to shitty coding :(", true,
autoDeleteAfter: TimeSpan.FromSeconds(10));
return; return;
} }