From f895ebe5b9920214d543622ca278bb2ff21fac6c Mon Sep 17 00:00:00 2001
From: barelyprofessional
 <150058423+barelyprofessional@users.noreply.github.com>
Date: Sat, 22 Mar 2025 13:50:12 +0800
Subject: [PATCH] Don't log secrets in the cache miss messages

---
 KfChatDotNetBot/Settings/Helpers.cs | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/KfChatDotNetBot/Settings/Helpers.cs b/KfChatDotNetBot/Settings/Helpers.cs
index 1143968..90eb4af 100644
--- a/KfChatDotNetBot/Settings/Helpers.cs
+++ b/KfChatDotNetBot/Settings/Helpers.cs
@@ -47,8 +47,17 @@ public static class Helpers
             logger.Debug($"{key}'s value is null so returning SettingValue(null)");
             return new SettingValue(null, setting, false);
         }
-        
-        logger.Info($"Cache Miss! Returning '{setting.Value}' for {key}");
+
+        if (setting.IsSecret)
+        {
+            logger.Info($"Cache Miss! Returning secret of length '{setting.Value?.Length}' for {key}");
+
+        }
+        else
+        {
+            logger.Info($"Cache Miss! Returning '{setting.Value}' for {key}");
+
+        }
         return new SettingValue(setting.Value, setting, false);
     }