From 9ca5bf566d033aa0a916640e3e78a30e788fbea5 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 26 Jul 2026 18:50:08 +0000 Subject: [PATCH] Update Widgets tab copy to reflect that disabling actually stops polling The "Hidden" tag, checkbox tooltip, and intro hint previously only described sidebar visibility, which undersold what disabling now does (scheduler.ts gates the actual poller on this flag too). Tag is now "Off", tooltips say "stops polling and hides from the sidebar" / "resumes polling and shows in the sidebar", and the intro hint spells out both effects plus the immediate re-poll on re-enable. Bookmarks (no backend poller) gets its own accurate, narrower wording via a new hasBackendPoller prop on WidgetSection instead of inheriting a claim that doesn't apply to it. --- .../lib/components/admin/WidgetSection.svelte | 25 +++++++++++++++---- .../lib/components/admin/WidgetsTab.svelte | 10 +++++--- 2 files changed, 27 insertions(+), 8 deletions(-) diff --git a/frontend/src/lib/components/admin/WidgetSection.svelte b/frontend/src/lib/components/admin/WidgetSection.svelte index ca697a3..63b39ec 100644 --- a/frontend/src/lib/components/admin/WidgetSection.svelte +++ b/frontend/src/lib/components/admin/WidgetSection.svelte @@ -3,18 +3,24 @@ // Minimized by default — Weather/Stocks/Bookmarks/PoE2 stacked at full height would // make the consolidated "Widgets" tab unwieldy as more get added over time. Enabled - // state is independent of expanded state: disabling a widget only hides it from the - // sidebar (see Sidebar.svelte's widgetsEnabled gate), it doesn't stop the admin from - // expanding this section to keep configuring it. + // state is independent of expanded state: disabling a widget hides it from the + // sidebar AND stops its backend poller from making outbound requests (see + // scheduler.ts's widgets.* gate) — it just doesn't stop the admin from expanding + // this section to keep configuring it while it's off. let { title, enabled, onToggle, + // Weather/Stocks/PoE2 have a backend poller that scheduler.ts gates on this same + // flag (see scheduler.ts); Bookmarks doesn't poll anything, so disabling it only + // ever affects sidebar visibility — the tooltip shouldn't claim otherwise. + hasBackendPoller = true, children }: { title: string; enabled: boolean; onToggle: () => void; + hasBackendPoller?: boolean; children: Snippet; } = $props(); @@ -26,9 +32,18 @@ -