VoiceChannels.tsx:62 renders the Disconnect IconButton inside the row's own <button> - invalid HTML nesting, and a click on Disconnect also fires the row's click handler (joining/opening the channel).
Fix: make the row a non-button container with the join action on its main area, and the Disconnect button a sibling.
Part of the v1.0 UI pass.
`VoiceChannels.tsx:62` renders the Disconnect `IconButton` inside the row's own `<button>` - invalid HTML nesting, and a click on Disconnect also fires the row's click handler (joining/opening the channel).
**Fix:** make the row a non-button container with the join action on its main area, and the Disconnect button a sibling.
_Part of the v1.0 UI pass._
Salastil
added this to the v1.0 milestone 2026-10-07 20:42:56 -04:00
Salastil
added the bug label 2026-10-07 20:42:56 -04:00
The Disconnect button was inside the channel row's own <button> - invalid HTML, and a click on it also reached the row's handler. It is now a sibling of the join button inside a div row. Checked in the test copy with a staged call: 0 buttons nested in buttons on the page, and the Disconnect button is a direct child of the row beside the join button. (No picture: the row looks the same.)
Finished: [6598043](https://git.salastil.com/Salastil/moho/commit/65980434838a52d1a9ad3ae97b84acae2e367de9).
The Disconnect button was inside the channel row's own `<button>` - invalid HTML, and a click on it also reached the row's handler. It is now a sibling of the join button inside a `div` row. Checked in the test copy with a staged call: **0** buttons nested in buttons on the page, and the Disconnect button is a direct child of the row beside the join button. (No picture: the row looks the same.)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
VoiceChannels.tsx:62renders the DisconnectIconButtoninside the row's own<button>- invalid HTML nesting, and a click on Disconnect also fires the row's click handler (joining/opening the channel).Fix: make the row a non-button container with the join action on its main area, and the Disconnect button a sibling.
Part of the v1.0 UI pass.
Finished: 6598043.
The Disconnect button was inside the channel row's own
<button>- invalid HTML, and a click on it also reached the row's handler. It is now a sibling of the join button inside adivrow. Checked in the test copy with a staged call: 0 buttons nested in buttons on the page, and the Disconnect button is a direct child of the row beside the join button. (No picture: the row looks the same.)