Pinned and DM page rows never show the service mark #281

Closed
opened 2026-10-07 20:43:00 -04:00 by Salastil · 1 comment
Owner

BufferRow declares a showServiceIcon prop (BufferList.tsx:796) and uses it (897) to show the Discord/Matrix/IRC mark in place of the kind glyph, but renderRow (288-354) never passes it. On the Pinned and DM pages, #general from Discord and #general from IRC therefore look identical.

Fix: pass showServiceIcon from the pages that mix services.

Part of the v1.0 UI pass.

`BufferRow` declares a `showServiceIcon` prop (BufferList.tsx:796) and uses it (897) to show the Discord/Matrix/IRC mark in place of the kind glyph, but `renderRow` (288-354) never passes it. On the Pinned and DM pages, `#general` from Discord and `#general` from IRC therefore look identical. **Fix:** pass `showServiceIcon` from the pages that mix services. _Part of the v1.0 UI pass._
Salastil added this to the v1.0 milestone 2026-10-07 20:43:00 -04:00
Salastil added the bug label 2026-10-07 20:43:00 -04:00
Author
Owner

Finished: 6598043.

The pinned page now passes showServiceIcon to its rows, so each room leads with its service's mark instead of the same # for every service. Conversations with a person keep their picture. Not photographed: the pinned page needs real pins, which the test copy does not have.

Finished: [6598043](https://git.salastil.com/Salastil/moho/commit/65980434838a52d1a9ad3ae97b84acae2e367de9). The pinned page now passes `showServiceIcon` to its rows, so each room leads with its service's mark instead of the same `#` for every service. Conversations with a person keep their picture. Not photographed: the pinned page needs real pins, which the test copy does not have.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Salastil/moho#281