Add virtual destructors to base classes

This commit is contained in:
Andrzej Rybczak
2017-05-21 15:24:27 +02:00
parent 19d32648ed
commit 0c88287c03
2 changed files with 6 additions and 2 deletions

View File

@@ -189,7 +189,9 @@ extern size_t FooterStartY;
struct BaseAction struct BaseAction
{ {
BaseAction(Type type_, const char *name_): m_name(name_), m_type(type_) { } BaseAction(Type type_, const char *name_): m_name(name_), m_type(type_) { }
virtual ~BaseAction() { }
const std::string &name() const { return m_name; } const std::string &name() const { return m_name; }
Type type() const { return m_type; } Type type() const { return m_type; }

View File

@@ -29,7 +29,9 @@
struct LyricsFetcher struct LyricsFetcher
{ {
typedef std::pair<bool, std::string> Result; typedef std::pair<bool, std::string> Result;
virtual ~LyricsFetcher() { }
virtual const char *name() const = 0; virtual const char *name() const = 0;
virtual Result fetch(const std::string &artist, const std::string &title); virtual Result fetch(const std::string &artist, const std::string &title);