ask if one really wants to clear main playlist (disabled by default)

src/ncmpcpp.cpp

@@ -1694,6 +1694,35 @@ int main(int argc, char *argv[])
 		}
 		else if (Keypressed(input, Key.Clear))
 		{
+			if (myScreen == myPlaylistEditor && myPlaylistEditor->Playlists->Empty())
+				continue;
+			
+			if (myScreen->ActiveWindow() == myPlaylistEditor->Content
+			||  Config.ask_before_clearing_main_playlist)
+			{
+				int in = 0;
+				LockStatusbar();
+				Statusbar() << "Do you really want to clear playlist";
+				if (myScreen->ActiveWindow() == myPlaylistEditor->Content)
+					*wFooter << " \"" << myPlaylistEditor->Playlists->Current() << "\"";
+				*wFooter << " ? [y/n] ";
+				curs_set(1);
+				do
+				{
+					TraceMpdStatus();
+					wFooter->ReadKey(in);
+				}
+				while (in != 'y' && in != 'n');
+				curs_set(0);
+				UnlockStatusbar();
+				
+				if (in != 'y')
+				{
+					ShowMessage("Aborted!");
+					continue;
+				}
+			}
+			
 			if (myPlaylist->Main()->isFiltered())
 			{
 				ShowMessage("Deleting filtered items...");
@@ -1705,38 +1734,16 @@ int main(int argc, char *argv[])
 			}
 			else
 			{
-				if (myScreen == myPlaylistEditor && myPlaylistEditor->Playlists->Empty())
-					continue;
-				int in = 0;
-				if (myScreen == myPlaylistEditor)
+				if (myScreen->ActiveWindow() == myPlaylistEditor->Content)
 				{
-					LockStatusbar();
-					Statusbar() << "Do you really want to clear playlist \"" << myPlaylistEditor->Playlists->Current() << "\" ? [y/n] ";
-					curs_set(1);
-					do
-					{
-						TraceMpdStatus();
-						wFooter->ReadKey(in);
-					}
-					while (in != 'y' && in != 'n');
-					curs_set(0);
-					UnlockStatusbar();
-					
-					if (in == 'y')
-					{
-						Mpd.ClearPlaylist(locale_to_utf_cpy(myPlaylistEditor->Playlists->Current()));
-						myPlaylistEditor->Content->Clear(0);
-					}
-					else
-						ShowMessage("Aborted!");
+					Mpd.ClearPlaylist(locale_to_utf_cpy(myPlaylistEditor->Playlists->Current()));
+					myPlaylistEditor->Content->Clear(0);
 				}
 				else
 				{
 					ShowMessage("Clearing playlist...");
 					Mpd.ClearPlaylist();
 				}
-				if (myScreen != myPlaylistEditor || in == 'y')
-					ShowMessage("Playlist cleared!");
 			}
 			// if playlist is cleared, items list have to be updated, but this
 			// can be blocked if new song was added to playlist less than one

src/settings.cpp

@@ -295,6 +295,7 @@ void DefaultConfiguration(ncmpcpp_config &conf)
 	conf.use_cyclic_scrolling = false;
 	conf.allow_physical_files_deletion = false;
 	conf.allow_physical_directories_deletion = false;
+	conf.ask_before_clearing_main_playlist = false;
 	conf.mouse_support = true;
 	conf.new_design = false;
 	conf.set_window_title = true;
@@ -742,6 +743,10 @@ void ReadConfiguration(ncmpcpp_config &conf)
 			{
 				conf.allow_physical_directories_deletion = v == "yes";
 			}
+			else if (cl.find("ask_before_clearing_main_playlist") != std::string::npos)
+			{
+				conf.ask_before_clearing_main_playlist = v == "yes";
+			}
 			else if (cl.find("mouse_support") != std::string::npos)
 			{
 				conf.mouse_support = v == "yes";

src/settings.h

@@ -190,6 +190,7 @@ struct ncmpcpp_config
 	bool use_cyclic_scrolling;
 	bool allow_physical_files_deletion;
 	bool allow_physical_directories_deletion;
+	bool ask_before_clearing_main_playlist;
 	bool mouse_support;
 	bool new_design;