diff --git a/configure.ac b/configure.ac index b11213aa..3d49c71c 100644 --- a/configure.ac +++ b/configure.ac @@ -90,6 +90,9 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [[auto f = [](auto n) { return n*n; }; f( AC_MSG_ERROR([[Your compiler doesn't seem to support generic lambda expressions, please upgrade (GCC >= 5)]]) ) +# warnings +CXXFLAGS="$CXXFLAGS -Wall -Wextra -Wshadow -Wimplicit-fallthrough" + # boost BOOST_REQUIRE([1.60]) AC_SUBST(BOOST_CPPFLAGS) diff --git a/src/regex_filter.h b/src/regex_filter.h index 31cd9e47..a5372126 100644 --- a/src/regex_filter.h +++ b/src/regex_filter.h @@ -93,7 +93,7 @@ inline Regex make(StringT &&s, template inline bool search(const std::basic_string &s, const Regex &rx, - bool ignore_diacritics) + GNUC_UNUSED bool ignore_diacritics) { try { #ifdef BOOST_REGEX_ICU diff --git a/src/screens/media_library.cpp b/src/screens/media_library.cpp index 1b046117..2cdfceef 100644 --- a/src/screens/media_library.cpp +++ b/src/screens/media_library.cpp @@ -336,9 +336,9 @@ void MediaLibrary::update() for (const auto &album : albums) { auto entry = AlbumEntry( - Album(std::move(std::get<0>(album.first)), - std::move(std::get<1>(album.first)), - std::move(std::get<2>(album.first)), + Album(std::get<0>(album.first), + std::get<1>(album.first), + std::get<2>(album.first), album.second)); if (idx < Albums.size()) Albums[idx].value() = std::move(entry); @@ -435,8 +435,8 @@ void MediaLibrary::update() { auto entry = AlbumEntry( Album(primary_tag, - std::move(std::get<0>(album.first)), - std::move(std::get<1>(album.first)), + std::get<0>(album.first), + std::get<1>(album.first), album.second)); if (idx < Albums.size()) {