Salastil/ncmpcpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix iteration through list from previous commit

Browse Source 
if last item was removed, 'it' would be set to Patterns.end()
and then for loop was incrementing 'it', bypassing conditional
for exit by that.
This commit is contained in:
Andrzej Rybczak
2009-09-09 17:05:36 +02:00
parent deb23548ce
commit 6cc4eac00e
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/tag_editor.cpp
View File

@@ -458,9 +458,13 @@ void TagEditor::EnterPressed()
} }
else if (success) else if (success)
{ {
for (std::list<std::string>::iterator it = Patterns.begin(); it != Patterns.end(); ++it) for (std::list<std::string>::iterator it = Patterns.begin(); ; ++it)
{
if (*it == Config.pattern) if (*it == Config.pattern)
it = Patterns.erase(it); it = Patterns.erase(it);
if (it == Patterns.end())
break;
}
Patterns.insert(Patterns.begin(), Config.pattern); Patterns.insert(Patterns.begin(), Config.pattern);
quit = 1; quit = 1;
} }