Salastil/ncmpcpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't block when executing external commands

Browse Source
This commit is contained in:
Andrzej Rybczak
2021-01-03 23:55:06 +01:00
parent dd0eac69f8
commit b902a2a6bf
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/macro_utilities.cpp
View File

@@ -87,7 +87,7 @@ RunExternalCommand::RunExternalCommand(std::string &&command)
void RunExternalCommand::run() void RunExternalCommand::run()
{ {
runExternalCommand(m_command, false); runExternalCommand(m_command, true);
} }
RunExternalConsoleCommand::RunExternalConsoleCommand(std::string &&command) RunExternalConsoleCommand::RunExternalConsoleCommand(std::string &&command)
@@ -118,5 +118,6 @@ void runExternalCommand(const std::string &cmd, bool block)
if (block) if (block)
std::system(cmd.c_str()); std::system(cmd.c_str());
else else
std::system(("nohup " + cmd + " &").c_str()); // If we don't block, disregard any output.
std::system(("nohup " + cmd + " >/dev/null 2>&1 &").c_str());
} }

6
src/status.cpp
View File

@@ -570,7 +570,11 @@ void Status::Changes::songID(int song_id)
if (!s.empty()) if (!s.empty())
{ {
if (!Config.execute_on_song_change.empty()) if (!Config.execute_on_song_change.empty())
runExternalCommand(Config.execute_on_song_change, false); {
// We need to block to allow sending output to the terminal so a script
// can e.g. set the album art.
runExternalCommand(Config.execute_on_song_change, true);
}
if (Config.fetch_lyrics_in_background) if (Config.fetch_lyrics_in_background)
myLyrics->fetchInBackground(s, false); myLyrics->fetchInBackground(s, false);