Salastil/ncmpcpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

configuration: add mpd_password option (#407)

Browse Source 
Although this can already be set via mpd_host, having a separate option
is cleaner, and doesn't require setting the host when ncmpcpp already
detects it correctly.
This commit is contained in:
V
2021-01-24 19:15:59 +01:00
committed by GitHub
parent 5dfbd3f23a
commit d9c55771bb
5 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@@ -46,3 +46,4 @@ Trygve Aaberge <trygveaa@gmail.com>
Wieland Hoffmann <themineo@gmail.com> Wieland Hoffmann <themineo@gmail.com>
Wojciech Siewierski <wojciech.siewierski@onet.pl> Wojciech Siewierski <wojciech.siewierski@onet.pl>
Yannick LM <yannicklm1337@gmail.com> Yannick LM <yannicklm1337@gmail.com>
V <v@anomalous.eu>

1
CHANGELOG.md
View File

@@ -1,4 +1,5 @@
# ncmpcpp-0.10 (????-??-??) # ncmpcpp-0.10 (????-??-??)
* Add the configuration option `mpd_password`.
# ncmpcpp-0.9.2 (2021-01-24) # ncmpcpp-0.9.2 (2021-01-24)
* Revert suppression of output of all external commands as that makes e.g album * Revert suppression of output of all external commands as that makes e.g album

2
doc/config
View File

@@ -27,6 +27,8 @@
# #
#mpd_port = 6600 #mpd_port = 6600
# #
#mpd_password = ""
#
#mpd_connection_timeout = 5 #mpd_connection_timeout = 5
# #
## Needed for tag editor and file operations to work. ## Needed for tag editor and file operations to work.

3
doc/ncmpcpp.1
View File

@@ -74,6 +74,9 @@ Connect to MPD running on specified host/unix socket. When HOST starts with a '/
.B mpd_port = PORT .B mpd_port = PORT
Connect to MPD on the specified port. Note: MPD_PORT environment variable overrides this setting. Connect to MPD on the specified port. Note: MPD_PORT environment variable overrides this setting.
.TP .TP
.B mpd_password = PASSWORD
Use PASSWORD to authenticate to MPD.
.TP
.B mpd_music_dir = PATH .B mpd_music_dir = PATH
Search for files in specified directory. This is needed for tag editor to work. Search for files in specified directory. This is needed for tag editor to work.
.TP .TP

4
src/settings.cpp
View File

@@ -244,6 +244,10 @@ bool Configuration::read(const std::vector<std::string> &config_paths, bool igno
p.add<void>("mpd_port", nullptr, "6600", [](std::string port) { p.add<void>("mpd_port", nullptr, "6600", [](std::string port) {
Mpd.SetPort(verbose_lexical_cast<unsigned>(port)); Mpd.SetPort(verbose_lexical_cast<unsigned>(port));
}); });
p.add<void>("mpd_password", nullptr, "", [](std::string password) {
if (!password.empty())
Mpd.SetPassword(password);
});
p.add("mpd_music_dir", &mpd_music_dir, "~/music", adjust_directory); p.add("mpd_music_dir", &mpd_music_dir, "~/music", adjust_directory);
p.add("mpd_connection_timeout", &mpd_connection_timeout, "5"); p.add("mpd_connection_timeout", &mpd_connection_timeout, "5");
p.add("mpd_crossfade_time", &crossfade_time, "5"); p.add("mpd_crossfade_time", &crossfade_time, "5");