Salastil/ncmpcpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Suppress output of all external commands

Browse Source
This commit is contained in:
Andrzej Rybczak
2020-12-21 19:43:40 +01:00
parent 89ebfbf73d
commit f3fe45f3ff
5 changed files with 31 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/status.cpp
View File

@@ -28,6 +28,7 @@
#include "format_impl.h"
#include "global.h"
#include "helpers.h"
#include "macro_utilities.h"
#include "screens/lyrics.h"
#include "screens/media_library.h"
#include "screens/outputs.h"
@@ -489,9 +490,9 @@ void Status::Changes::playerState()
}
throw std::logic_error("unreachable");
};
GNUC_UNUSED int res;
setenv("MPD_PLAYER_STATE", stateToEnv(m_player_state), 1);
res = system(Config.execute_on_player_state_change.c_str());
// Since we're setting a MPD_PLAYER_STATE, we need to block.
runExternalCommandNoOutput(Config.execute_on_player_state_change, true);
unsetenv("MPD_PLAYER_STATE");
}
@@ -568,9 +569,8 @@ void Status::Changes::songID(int song_id)
const auto &s = it != pl.endV() ? *it : Mpd.GetCurrentSong();
if (!s.empty())
{
GNUC_UNUSED int res;
if (!Config.execute_on_song_change.empty())
res = system(Config.execute_on_song_change.c_str());
runExternalCommandNoOutput(Config.execute_on_song_change, false);
if (Config.fetch_lyrics_in_background)
myLyrics->fetchInBackground(s, false);