Commit Graph

35 Commits

Author SHA1 Message Date
nick black
302bcca99a Curses: don't iterate through unbound COLORS #369
On DirectColor-capable terminals with the proper terminfo
database in use, COLORS is 2^24. Since the color map is
only 64k entries, this resulted in a segfault. I've
introduced NC::colorCount(), which bounds it by the
previously assumed maximum (and usable range) of 256.
2020-01-12 06:06:29 -05:00
Larson Carter
320d8d0ccb Merge pull request #240 from Polochon-street/album-view
Added a fully working 'Album-only' view
2019-09-30 18:19:21 -05:00
Peter Rice
e1e220c975 Escape single quotes in filenames 2019-08-06 21:41:38 -04:00
Peter Rice
2ff23ed719 Skip sh and pass filename in single quotes 2019-08-05 20:22:55 -04:00
Jan Holthuis
81cb7a4f85 Restore curses after running external command
This allows running TUI tools like vim via run_external_command without
destroying the ncmpcpp curses output.
2018-05-13 18:15:21 +02:00
Andrzej Rybczak
e912a9d0c3 Lyrics: reset position of a window when fetching 2018-03-29 17:00:38 +02:00
Andrzej Rybczak
e6f5179b92 Fix warnings when compiling with GCC 7 2018-03-18 12:32:52 +01:00
Andrzej Rybczak
2f3588edf3 Search engine: properly interact with filtering
See https://github.com/arybczak/ncmpcpp/issues/260
2018-03-18 11:43:59 +01:00
Andrzej Rybczak
464fd318c3 Media library: remove argument to SortSongs contructor to simplify sorting 2017-10-11 19:20:55 +02:00
Andrzej Rybczak
4a6e7d305b Default to sorting songs in media library by their display format instead of name 2017-09-01 11:02:43 +02:00
Andrzej Rybczak
def5c46225 Media library: sort songs by name if there are no track numbers 2017-08-31 09:41:56 +02:00
Arseny Maslennikov
5733c44826 tag_editor.cpp: Fix misleading indentation
Prior to this commit GCC6 throws 2 warnings on lines 1062 and 1161
if the project is compiled with -Wmisleading-indentation.
The code blocks mentioned in the related notes seem to be indented
one tab too much.
2017-08-31 09:22:14 +02:00
Polochon-street
29a90de777 Added a fully working 'Album-only' view 2017-08-10 16:19:57 +02:00
Andrzej Rybczak
19d32648ed Replace highlight colors with prefixes and suffixes 2017-05-21 15:22:54 +02:00
Andrzej Rybczak
66912d73da Add support for ignoring diacritics while searching and filtering lists 2017-03-29 21:38:14 +02:00
Andrzej Rybczak
29403d41ab Include format_impl.h where functions from format.h are used 2017-03-29 11:06:59 +02:00
Andrzej Rybczak
21f0b4acb6 Configure: add more robust checks for boost libraries 2017-03-28 10:01:41 +02:00
Andrzej Rybczak
6f1e2d7516 Add option 'media_library_albums_split_by_date' 2017-03-28 09:01:33 +02:00
Andrzej Rybczak
554895f0f1 Media library: add songs to playlist in the same order they are displayed in 2017-03-26 09:08:32 +02:00
Andrzej Rybczak
c3b996c0e8 Print message only after song is not found in a current playlist 2017-03-12 19:58:58 +01:00
Andrzej Rybczak
86ec51624e Update AUTHORS and copyright line 2017-03-12 15:05:48 +01:00
Andrzej Rybczak
809b1d5b59 Rename requestContentsUpdate to requestContentUpdate 2017-03-12 13:19:21 +01:00
Andrzej Rybczak
b0121227e9 Overhaul jumping to song in playlist editor to clearly show search order 2017-03-12 13:12:14 +01:00
Hugh Wang
743290cf0a Improve detection for songs not in playlists 2017-03-12 12:41:25 +01:00
Hugh Wang
4eae285160 Fix crash when jumping to playing song in playlist editor
By default, PlaylistEditor delays fetching of the content for performance
reasons. If the user switches the playlist then tells ncmpcpp to jump to the
currently playing song within the delay, the update request that fetches the new
content will be ignored. This results in inconsistent content, or crash if the
position of the song in the new content exceeds the length of the stale content.

This fix enforces a fetch even if the update request that fetches the new
content stays within the delay.
2017-03-12 12:41:25 +01:00
Andrzej Rybczak
86d24b26a8 Ignore fetch delay while locating song in media library 2017-03-12 12:40:27 +01:00
Andrzej Rybczak
00cbbe5593 playlist editor: fix jumping from the last occurrence of song in playlists 2017-02-18 11:20:45 +01:00
Hugh Wang
0cdbe31ecb Handle JumpToPlayingSong action in playlist editor 2017-02-18 11:09:33 +01:00
Andrzej Rybczak
22681df199 Add support for fetching lyrics from jah-lyrics.com and plyrics.com 2017-01-28 20:42:23 +01:00
Andrzej Rybczak
ca330bc924 Get rid of intermediate data structure when fetching directory contents 2017-01-06 17:02:23 +01:00
Andrzej Rybczak
6d2ed00e6a Fix highlighting parent directory in filtered browser 2017-01-06 16:49:04 +01:00
Andrzej Rybczak
7d502e42ba Check if songs are in playlist when displaying them, not up-front 2017-01-06 13:58:22 +01:00
Andrzej Rybczak
4cd94cb4b3 Make lyrics and last_fm screens lockable and startup screens 2016-12-25 16:06:38 +01:00
Andrzej Rybczak
a488c2d89d Support attaching format information to selected color variables 2016-12-23 22:52:47 +01:00
Andrzej Rybczak
5445c41aaa Move screens to subdirectory 2016-12-22 15:58:57 +01:00