Commit Graph

537 Commits

Author SHA1 Message Date
Andrzej Rybczak
8e350292ad ...but at first check if there is callback to invoke. 2009-03-22 20:06:03 +01:00
Andrzej Rybczak
9270a83a78 invoke callback immediately after sending update command succesfully 2009-03-22 20:01:39 +01:00
Andrzej Rybczak
ab265f2fdf do not fetch mpd_Stats from mpd as it's unneded 2009-03-22 17:52:27 +01:00
Andrzej Rybczak
ffbcfb7e18 poll mpd once per second, no need to do it more often 2009-03-22 16:11:44 +01:00
Andrzej Rybczak
bf71a01b1c ignore keycodes <10 || >10 && <32 in Window::GetString() 2009-03-22 15:14:12 +01:00
Andrzej Rybczak
cf3746f301 always poll mpd twice per second 2009-03-22 15:10:04 +01:00
Andrzej Rybczak
b58864e682 fix bolding np song with 'repeat one' function enabled 2009-03-21 13:41:53 +01:00
Andrzej Rybczak
b2317df843 provide file with locales and corresponding encodings 2009-03-20 20:33:35 +01:00
Andrzej Rybczak
23567ed4f1 show notification if given value is out of bounds 2009-03-20 18:19:24 +01:00
Andrzej Rybczak
3d5e62aa65 change default behaviour of 'go to given position' function
before that number without any other signs was treated as time
in seconds to go, now it's threated as %. treating a number as
seconds needs you to type 's' after numeric value.
2009-03-20 17:53:32 +01:00
Andrzej Rybczak
eeb1951547 fix for clock misrendering
clearing screen explicitely before displaying it apparently
fixes the problem with last digits being misrendered sometimes.
2009-03-20 17:44:02 +01:00
Andrzej Rybczak
5cfe75a0c2 Revert "limit clear and crop function to playlist/playlist editor"
This was silly idea, I did this so no one could clear the playlist
by accident, but I forgot about the common situation when one can
just clear playlist and add new songs e.g. form browser immediately.

This reverts commit 047dabd41a.
2009-03-19 18:48:58 +01:00
Andrzej Rybczak
a1a2ba4eed show columns' titles if browser displays them at start 2009-03-18 18:42:36 +01:00
Andrzej Rybczak
503c4964d5 Revert "use inline functions instead of macros in charset.h"
This reverts commit 7f2a635ac5.
2009-03-17 23:57:36 +01:00
Andrzej Rybczak
42b11910cc update NEWS / version bump 2009-03-17 19:58:24 +01:00
Andrzej Rybczak
a9bad6863b check if ptr is NULL before dereferencing it in Menu::GetSelected() 2009-03-17 19:48:34 +01:00
Andrzej Rybczak
204189fe33 update man and example config 2009-03-17 19:44:27 +01:00
Andrzej Rybczak
047dabd41a limit clear and crop function to playlist/playlist editor
this will minimize the risk of unwanted clearing of playlist e.g. by
pressing 'c' key accidentaly in other screen than playlist/playlist editor.
2009-03-17 18:25:44 +01:00
Andrzej Rybczak
d1d1011eeb make function 'clear' in playlist editor clear selected playlist 2009-03-17 18:24:35 +01:00
Andrzej Rybczak
b382784f6a notify about selected items being removed from playlist 2009-03-17 16:58:55 +01:00
Andrzej Rybczak
aea0540f16 a few improvements for 'add selected' function 2009-03-17 16:43:33 +01:00
Andrzej Rybczak
a1b08c5776 add ('a') items to currently selected playlist in playlist editor 2009-03-16 17:10:43 +01:00
Andrzej Rybczak
8a1223aa18 enable playlist highlighting after saving playlist 2009-03-16 16:36:48 +01:00
Andrzej Rybczak
20055afac4 call Song::Localize() in Display::SongInColumns() 2009-03-15 22:42:28 +01:00
Andrzej Rybczak
1e511d1d8d fix now playing update if playlist is filtered 2009-03-15 13:35:18 +01:00
Andrzej Rybczak
31ab01cc1c fix prototype of write_data() function used by curl
maybe this works, but I don't want it to suddenly stop working
some day just because curl guys made their library more strict.
2009-03-14 22:15:25 +01:00
Andrzej Rybczak
24fc414826 fix bolding/unbolding items, if screen is filtered 2009-03-14 18:04:31 +01:00
Andrzej Rybczak
aad83e9b6c fix clearing statusbar if playing is stopped 2009-03-13 15:24:12 +01:00
Andrzej Rybczak
1a7fd6d332 update window title only when playlist or songid changed 2009-03-13 15:11:59 +01:00
Andrzej Rybczak
3477c1514d put check for playlist filtering in macro 2009-03-13 14:35:35 +01:00
Andrzej Rybczak
2c1647d57a new feature: reverse playlist 2009-03-13 14:22:43 +01:00
Andrzej Rybczak
d03c4a88b6 fix Menu copy constructor
it has to make deep copy of itsOptions.
2009-03-13 13:26:29 +01:00
Andrzej Rybczak
a20469b403 never get full playlist from mpd, always request for changes 2009-03-13 12:58:17 +01:00
Andrzej Rybczak
c7689d72d6 improve playlist updating
the case when sizes of mpd's and ncmpcpp's are equal is redundant.
what is more, it caused unneded overhead, because it was comparing
whole playlists. plchanges commands returns only songs that have
really changed, so this piece of code was simply wrong.
2009-03-12 21:26:56 +01:00
Andrzej Rybczak
502ce9be6a handle now playing song properly
np song was sometimes wrongly taken, if user was moving items in playlist.
fix this by taking it directly from mpd, but do this as seldom as possible.
2009-03-12 21:24:00 +01:00
Andrzej Rybczak
0aa36f3fb2 move Global::Timer to Playlist class 2009-03-12 20:20:26 +01:00
Andrzej Rybczak
d5a68a1a60 make Keypressed() funcion inline 2009-03-12 19:29:38 +01:00
Andrzej Rybczak
6768e3cdaa change char * to const char * in libmpdclient where appropriate to avoid casts 2009-03-12 18:29:13 +01:00
Andrzej Rybczak
24c37eb592 do not store commands list in MPD::Connection
it should have sent commandlist begin and end commands from the beginning,
having separated functions just to handle queueing commands was plainly ugly.
2009-03-12 17:30:25 +01:00
Andrzej Rybczak
8a4ee22b61 swap songs internally while sorting to keep their properties 2009-03-12 13:46:00 +01:00
Andrzej Rybczak
2bb0aaef18 if selected items are separated, group them while moving 2009-03-12 13:32:24 +01:00
Andrzej Rybczak
c0d227a0c8 move selected items to actual cursor position, not to given one
this is much better as no position couting is needed.
2009-03-11 21:31:41 +01:00
Andrzej Rybczak
fd7ac3b3f5 new feature: move item(s) in playlist to given position 2009-03-11 20:27:55 +01:00
Andrzej Rybczak
a80bf2a7bf use typename keyword instead of class as it's more logical 2009-03-10 22:47:39 +01:00
Andrzej Rybczak
d50dcac5a2 return value, not const reference, if return type is POD or ptr
returning reference to POD types can be in fact slower than returning value.
2009-03-10 22:20:09 +01:00
Andrzej Rybczak
5e29d251c3 add man page 2009-03-10 21:02:47 +01:00
Andrzej Rybczak
1667079b59 do not include misc.h in menu.h as it's redundant there 2009-03-10 17:26:03 +01:00
Andrzej Rybczak
5f114abd2c clear screen only after getting song info to avoid flickering 2009-03-09 11:43:27 +01:00
Andrzej Rybczak
2f68c48eb0 make SearchEngine::CaseSensitive regex flag 2009-03-09 11:23:55 +01:00
Andrzej Rybczak
14a817e83e fix memory leak in search engine
while performing case insensitive and exact match searching Song was
really copied, so clearing its internal mpd_Song ptr resulted in memleak.
2009-03-09 11:09:13 +01:00