bdec1eb009
Merge pull request #373 from wylfen/master
...
Stop using deprecated removeField method
2020-01-12 12:35:13 +01:00
69ec9aef63
Merge pull request #370 from dankamongmen/master
...
Curses: don't iterate through unbound COLORS #369
2020-01-12 12:33:03 +01:00
302bcca99a
Curses: don't iterate through unbound COLORS #369
...
On DirectColor-capable terminals with the proper terminfo
database in use, COLORS is 2^24. Since the color map is
only 64k entries, this resulted in a segfault. I've
introduced NC::colorCount(), which bounds it by the
previously assumed maximum (and usable range) of 256.
2020-01-12 06:06:29 -05:00
d86c965143
Fix lyrics fetchers
2020-01-12 06:43:52 +01:00
5e54cf2ca3
Stop using deprecated removeField method
...
taglib deprecated removeField internally in [1], but did not add the
deprecation warning until about four years later. The original bug
report [2] and pull request commit both mention not wanting to change
the original method's behaviour, but this was done anyway (perhaps by
mistake) in [3].
With that change, removeField(type) will not remove all tags of the
given type anymore, as the default for value has changed from
String::null to String().
This commit replaces explicit calls to removeField(type) with
removeFields(type), which has the correct behaviour. In writeXiph,
removeField is removed entirely, as addField(key, value) will replace
the tag by default.
[1] https://github.com/taglib/taglib/pull/681
[2] https://github.com/taglib/taglib/issues/651
[3] https://github.com/taglib/taglib/commit/c05fa78406fd8ce7382a11c1f63a17c4bfbe83fa
2020-01-11 15:30:08 +01:00
af512a9668
Add ability to not display the "Connected to ..." message at startup
2019-10-19 21:50:33 +02:00
d6315ddcd7
Merge pull request #340 from sticken88/master
...
Changes API for directories creation.
2019-10-01 20:18:01 -05:00
ee79bfd1d7
Move random_exclude_pattern settings to proper place
2019-10-01 19:22:16 +02:00
69f49d558d
Add random_exclude_pattern option for random songs
2019-10-01 19:05:44 +02:00
320d8d0ccb
Merge pull request #240 from Polochon-street/album-view
...
Added a fully working 'Album-only' view
2019-09-30 18:19:21 -05:00
9f6862e627
Merge pull request #338 from mvrozanti/master
...
allow for message_delay_time = "0"
2019-09-30 18:14:18 -05:00
94bfe04994
Merge pull request #327 from FeralHedgehog/expand_with_password
...
Expand '~' in mpd_host when preceded by a password.
2019-09-30 18:12:11 -05:00
6001a639da
Merge pull request #269 from karlicoss/mpd-play
...
Add support for starting playback in stopped state
2019-09-30 18:06:20 -05:00
3a27d15e8e
Merge pull request #312 from ata2001/lyrics-zeneszoveg
...
lyrics fetcher: add support for zeneszoveg.hu
2019-09-30 17:57:19 -05:00
e1e220c975
Escape single quotes in filenames
2019-08-06 21:41:38 -04:00
2ff23ed719
Skip sh and pass filename in single quotes
2019-08-05 20:22:55 -04:00
94c74e50bf
Changes API for directories creation.
2019-05-22 22:57:58 +02:00
444137696e
allow for message_delay_time = "0"
2019-05-04 10:39:16 -03:00
8304cb8e4c
Properly expand '~' in mpd_host when preceded by a password.
2019-01-26 01:40:15 +02:00
156be93d5a
lyrics fetcher: add support for zeneszoveg.hu
2018-10-24 02:07:25 +02:00
81cb7a4f85
Restore curses after running external command
...
This allows running TUI tools like vim via run_external_command without
destroying the ncmpcpp curses output.
2018-05-13 18:15:21 +02:00
e3e35dcbdd
Fix compilation with ICU >= 61, part 2
2018-04-09 11:36:39 +02:00
7a75756ca3
Fix compilation with ICU >= 61
2018-04-09 09:12:25 +02:00
e912a9d0c3
Lyrics: reset position of a window when fetching
2018-03-29 17:00:38 +02:00
51fe8dc2c8
Statusbar: redraw separator after interface switch when MPD is stopped
2018-03-18 12:41:47 +01:00
e6f5179b92
Fix warnings when compiling with GCC 7
2018-03-18 12:32:52 +01:00
2f3588edf3
Search engine: properly interact with filtering
...
See https://github.com/arybczak/ncmpcpp/issues/260
2018-03-18 11:43:59 +01:00
557720061d
Lyrics fetcher: fix metrolyrics.com fetchers
2018-03-18 11:07:51 +01:00
1b98dd71e1
Lyrics fetcher: fix lyricsmania.com and sing365.com fetchers
2018-03-18 10:52:14 +01:00
db619c6159
Make it impossible for MainHeight to overflow
2018-03-18 10:31:08 +01:00
0b04d9ec35
Help: display EoF properly
2018-03-18 09:26:28 +01:00
77f39d4979
Add support for starting playback in stopped state
2017-12-17 15:28:59 +00:00
b7da5d1b9a
Curl: re-enable verification of the SSL certificate against host
2017-10-12 13:29:51 +02:00
fa9838efb2
Do not start prompt with the current search constraint when applying a new one
2017-10-11 19:34:30 +02:00
464fd318c3
Media library: remove argument to SortSongs contructor to simplify sorting
2017-10-11 19:20:55 +02:00
4a6e7d305b
Default to sorting songs in media library by their display format instead of name
2017-09-01 11:02:43 +02:00
c340a6ba9a
Mark songs as added to playlist immediately (media library / playlist editor)
2017-08-31 10:19:13 +02:00
def5c46225
Media library: sort songs by name if there are no track numbers
2017-08-31 09:41:56 +02:00
db28618929
Fix intermittent failures when using --quiet
2017-08-31 09:23:11 +02:00
5733c44826
tag_editor.cpp: Fix misleading indentation
...
Prior to this commit GCC6 throws 2 warnings on lines 1062 and 1161
if the project is compiled with -Wmisleading-indentation.
The code blocks mentioned in the related notes seem to be indented
one tab too much.
2017-08-31 09:22:14 +02:00
29a90de777
Added a fully working 'Album-only' view
2017-08-10 16:19:57 +02:00
a22cd2c68c
Fix crash when colors are disabled
2017-06-15 13:59:03 +02:00
99107c5b39
Fix fetching lyrics from sing365.com and genius.com
2017-05-21 16:10:48 +02:00
0c88287c03
Add virtual destructors to base classes
2017-05-21 15:24:27 +02:00
19d32648ed
Replace highlight colors with prefixes and suffixes
2017-05-21 15:22:54 +02:00
8134e6e23b
configure: check if curses.h exposes wide-char functions
2017-04-23 04:24:57 +02:00
e107edd4cd
bindings: Support a bindings file in $XDG_CONFIG_HOME/ncmpcpp
...
Fixes https://github.com/arybczak/ncmpcpp/issues/91
This also rewrites the intro in doc/bindings to be more like doc/config.
2017-04-23 03:27:29 +02:00
67df6b556b
Fix InternetLyricsFetcher
2017-04-08 14:19:42 +02:00
66912d73da
Add support for ignoring diacritics while searching and filtering lists
2017-03-29 21:38:14 +02:00
29403d41ab
Include format_impl.h where functions from format.h are used
2017-03-29 11:06:59 +02:00
Andrzej Rybczak