mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-06-30 00:22:10 -04:00
fix(cookbook): open() no longer crashes when a task has a diagnosis (#4417)
_showDiagnosis referenced an undefined `body` (left over from the refactor that moved the diagnosis text into the toolbar), throwing a ReferenceError whenever a failed task rendered fix buttons. Because open() wraps its render in try/finally with no catch, the throw escaped before the modal was un-hidden, so the whole Cookbook silently failed to open. - cookbook-diagnosis.js: append the fixes row to `diag` (the in-scope container) instead of the removed `body` element. - cookbook.js: guard the render passes in open() so one broken task card can't leave the entire panel stuck hidden. Fixes #4406
This commit is contained in:
committed by
GitHub
parent
dd20c2bc75
commit
497f455da6
@@ -757,7 +757,7 @@ export function _showDiagnosis(panel, diagnosis, sourceText) {
|
||||
});
|
||||
row.appendChild(btn);
|
||||
}
|
||||
body.appendChild(row);
|
||||
diag.appendChild(row);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user