mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-06-16 17:55:26 -04:00
Fix memory bullet extraction in service copy
Fix services.memory bullet-list extraction by grouping the bullet/number regex before the capture, and cover both memory manager copies in the regression test.
This commit is contained in:
@@ -7,12 +7,22 @@ capture group lives only in the numbered-list branch. A bullet line ("- ...")
|
||||
matches the first branch, so ``group(1)`` is ``None`` and ``.strip()`` raised
|
||||
``AttributeError``, crashing extraction for any assistant message that contains
|
||||
a bullet list (the dominant case).
|
||||
|
||||
There are two copies of ``MemoryManager``: ``src.memory`` and the
|
||||
``services.memory`` package that ``routes/memory_routes.py`` actually imports.
|
||||
The fix first landed only in ``src.memory`` while the live route path kept the
|
||||
broken copy, and this test imported ``src.memory`` so it stayed green. It now
|
||||
exercises both copies so the two cannot drift back apart.
|
||||
"""
|
||||
from src.memory import MemoryManager
|
||||
import pytest
|
||||
|
||||
from src.memory import MemoryManager as SrcMemoryManager
|
||||
from services.memory.memory import MemoryManager as ServiceMemoryManager
|
||||
|
||||
|
||||
def test_extract_memory_from_chat_handles_bullets(tmp_path):
|
||||
mgr = MemoryManager(str(tmp_path))
|
||||
@pytest.mark.parametrize("manager_cls", [SrcMemoryManager, ServiceMemoryManager])
|
||||
def test_extract_memory_from_chat_handles_bullets(manager_cls, tmp_path):
|
||||
mgr = manager_cls(str(tmp_path))
|
||||
chat = [{
|
||||
"role": "assistant",
|
||||
"content": "- User likes coffee\n* Prefers tea in winter\n1. Wakes at 6am",
|
||||
|
||||
Reference in New Issue
Block a user