From 6b5feb0e640a62086f68f339953bf7db87442a57 Mon Sep 17 00:00:00 2001 From: NoodleLDS Date: Tue, 2 Jun 2026 18:56:51 -0300 Subject: [PATCH] log(email_routes): add warnings to silent except Exception blocks - Email alias resolution failure now logs a warning instead of silently returning an empty list, making broken account configs diagnosable. --- routes/email_routes.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/routes/email_routes.py b/routes/email_routes.py index 0f4af19ae..7c332ca98 100644 --- a/routes/email_routes.py +++ b/routes/email_routes.py @@ -79,15 +79,16 @@ def _email_tag_owner_aliases(account_id: str | None, owner: str = "") -> list[st cfg.get("smtp_user") or "", cfg.get("from_address") or "", ]) - except Exception: + except Exception as _e: + logger.warning("Failed to resolve email account alias: %s", _e) resolved_account_id = None row = db.get(_EA, resolved_account_id) if resolved_account_id else None if row: aliases.extend([row.owner or "", row.imap_user or "", row.from_address or ""]) finally: db.close() - except Exception: - pass + except Exception as _e: + logger.warning("Failed to load email aliases: %s", _e) out = [] for a in aliases: a = (a or "").strip()