Isolate HTML popup openers (#2501)

2026-06-17 10:15:27 -04:00 · 2026-06-04 20:52:41 +02:00
parent ca8ca38a32
commit 9964f1382f
3 changed files with 39 additions and 0 deletions
@@ -0,0 +1,37 @@
+import re
+from pathlib import Path
+
+
+ROOT = Path(__file__).resolve().parents[1]
+
+
+def _source(path):
+    return (ROOT / path).read_text(encoding="utf-8")
+
+
+def test_html_code_runner_detaches_opener_before_document_write():
+    src = _source("static/js/codeRunner.js")
+    match = re.search(
+        r"export function runHTML\(code, panel\) \{(?P<body>.*?)showOutput\(panel, 'Opened in new window'",
+        src,
+        re.S,
+    )
+
+    assert match
+    body = match.group("body")
+    assert "win.opener = null" in body
+    assert body.index("win.opener = null") < body.index("win.document.write(code)")
+
+
+def test_compare_print_popup_detaches_opener_before_document_write():
+    src = _source("static/js/compare/index.js")
+    match = re.search(
+        r"function _exportPrint\(\) \{(?P<body>.*?)w\.document\.close\(\);",
+        src,
+        re.S,
+    )
+
+    assert match
+    body = match.group("body")
+    assert "w.opener = null" in body
+    assert body.index("w.opener = null") < body.index("w.document.write(html)")