From 9f47c5ff8714c3d340206c514e95b67440fd4b0e Mon Sep 17 00:00:00 2001 From: Rohithmatham12 Date: Mon, 8 Jun 2026 21:57:54 -0400 Subject: [PATCH] fix: quote kernels repair package spec --- static/js/cookbook-diagnosis.js | 2 +- tests/test_cookbook_diagnosis_js.py | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 tests/test_cookbook_diagnosis_js.py diff --git a/static/js/cookbook-diagnosis.js b/static/js/cookbook-diagnosis.js index 24d5770e7..1ea9ea4b8 100644 --- a/static/js/cookbook-diagnosis.js +++ b/static/js/cookbook-diagnosis.js @@ -406,7 +406,7 @@ export const ERROR_PATTERNS = [ { label: 'Repair kernel package', action: () => { const _vp = (_envState.env === 'venv' && _envState.envPath) ? `${_envState.envPath.replace(/\/+$/, '')}/bin/python3` : 'python3'; - _launchServeTask('repair-kernels', 'pip-update', `${_vp} -m pip install --user --break-system-packages kernels<0.15`); + _launchServeTask('repair-kernels', 'pip-update', `${_vp} -m pip install --user --break-system-packages "kernels<0.15"`); }}, { label: 'Open Dependencies', action: () => _openCookbookDependencies('sglang') }, ], diff --git a/tests/test_cookbook_diagnosis_js.py b/tests/test_cookbook_diagnosis_js.py new file mode 100644 index 000000000..42d7fc982 --- /dev/null +++ b/tests/test_cookbook_diagnosis_js.py @@ -0,0 +1,12 @@ +from pathlib import Path + + +ROOT = Path(__file__).resolve().parent.parent +DIAGNOSIS_JS = ROOT / "static" / "js" / "cookbook-diagnosis.js" + + +def test_repair_kernels_pip_spec_is_shell_quoted(): + source = DIAGNOSIS_JS.read_text(encoding="utf-8") + + assert '"kernels<0.15"' in source + assert " --break-system-packages kernels<0.15" not in source