1 Commits

Author	SHA1	Message	Date
Tal.Yuan	648db61b45	docs(architecture): add Phase 0 runtime inventory document (#4148) ... * docs(architecture): add Phase 0 runtime inventory document Per #4082 requirements, this no-code planning document maps: - Largest runtime modules (Python + frontend) - Import dependency graph and cross-layer violations - Route ownership grouped by feature domain - Tool registry boundaries and split candidates - Risk-ranked candidate slices with recommended first 3 PRs - Safety guardrails and validation commands for follow-up work Closes #4082 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(architecture): correct inventory metrics per review feedback Address @alteixeira20 review on #4148 (CHANGES_REQUESTED): - src/ flat .py: ~60 -> 91; routes/: 52 -> 54 - core/database.py importers: 49 -> 94; src/agent_loop.py: -> 21 - src/ -> routes/ import lines: ~20 -> 38 - src/ subdirs: 3 -> 2 (agent_tools/, search/); drop non-existent agent/ - move main.py and src/agent/ out of current-structure into new section 10 'Future Direction (NOT current state)' - route grouping: frame as one domain per PR, not a broad reorganization (helper imports / registration / test path risk) * docs(architecture): round-2 fixes — move to specs/, correct counts, frame as candidate Per @alteixeira20 + @RaresKeY review on #4148: - Move docs/architecture-runtime-inventory.md -> specs/ (docs/ is GitHub Pages public content, per @RaresKeY) - src/ -> routes/ import lines: 38 -> 30 (direct grep of import lines referencing routes/, matching reviewer's count) - self-caught count drift: tests 552 -> 544; routes->src 349 -> 351; src->core 49 -> 99 - frame section 6 (rankings/package shapes/split order/route grouping) and section 10 (future direction) as candidate proposals pending maintainer agreement, not a committed plan (per @RaresKeY) * docs(architecture): round-3 reviewer fixes — fix tool categorization, counts, appendix Self-review as reviewer found: - §5.2 tool categories were wrong: listed filesystem/shell/email-sending tools that are NOT in tool_implementations.py (they live in src/agent_tools/). Rewrote to the actual 33 do_* functions grouped by domain (system/cookbook/calendar/notes/search/research/contacts/vault/image) - §2.1 builtin_actions.py: 0 -> 2 classes, ~26 -> ~24 functions - §5.1: '33+' -> '33' (exact count) - Appendix A: 'Complete File Listing' -> 'File Listing'; src noted as '61 of 91 shown' (was claiming complete but listed 61) - Last updated date refreshed * docs(architecture): round-4 — verify remaining counts, soften §6.3 framing - task_scheduler ~6 -> 5 funcs; tool_index ~580 -> 542 lines (verified vs dev) - §6.3 'Recommended First 3 Slices' -> 'Candidate' (ownership unsettled, per review) - verified §4 route-domain line counts, §2.2 frontend counts, mcp_servers=4 - full test suite: 3267 passed, 1 skipped, 0 failed * docs(architecture): refresh Phase 0 inventory metrics + document counting method Refresh every count against current dev (b58af42) per review on #4148: - src/ flat .py: 91 -> 95; tests/test_*.py: 544 -> 583 - core.database importers: 94 -> 102; src.agent_loop importers: 21 -> 22 - src/ -> routes/ lines: 30 -> 31; routes/ -> src/: 351 -> 374; src/ -> core/: 99 -> 106 - Last updated: dev@9d7a3d6 -> dev@b58af42 Add a "How the metrics are computed" note under section 3.4 with the exact grep/find command for each count, so the numbers are reproducible and future dev drift is a one-command recheck instead of another review round (per the request to note the counting method). Documentation-only; no code changes. Co-Authored-By: Claude <noreply@anthropic.com> * docs(architecture): refresh remaining counts + add snapshot basis note Reviewer self-audit of the previous refresh caught more stale counts after the rebase onto dev@b58af42: - tool_implementations importers: 18 -> 17 (§3.2, §6.2, Appendix B) - core/database classes: 27 -> 28 (§2.1, §6.2) - mcp_servers .py files: 4 -> 5 (§1.1) - routes/ -> core/ import lines: 124 -> 126 (§3.4) Line counts in §2.1/§2.2 also drifted over the rebased range but are left as-is and covered by a new "Snapshot basis" note in the header: line counts are a snapshot that drifts as dev moves (recompute with wc -l), while the importer/file/import-line counts are the authoritative ones refreshed here. This keeps the inventory honest about live metric vs structural snapshot, so dev drift no longer triggers a review round. Documentation-only; no code changes. Co-Authored-By: Claude <noreply@anthropic.com> * docs(architecture): fix missed tool_implementations importer count in §6.3 Follow-up to the previous refresh: §6.3 Slice 1 still read "18 importers" after the 18->17 update elsewhere. Correct to 17 for consistency. Doc-only. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: yuandonghao <yuandonghao@cohl.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-16 04:57:24 +01:00