mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-06-15 17:25:26 -04:00
nubs
1a0e1c5d69
PDF uploads are stored as markdown wrappers with pdf_source or pdf_form_source markers so the editor can preserve extracted text, form fields, and annotations. The library exposed that internal wrapper: auto-created PDF documents used the hashed storage filename as the title, and row/facet language reported markdown instead of pdf.
Derive chat-upload PDF titles from the original upload name, derive document-library display language from the PDF source marker for rows, filters, and facets, and keep markdown wrappers excluded from the markdown facet when they represent PDFs.
The expanded library card already renders PDF-backed documents through /api/document/{id}/render-pdf. Allow only that inline PDF preview endpoint to be framed by same-origin app pages while leaving normal routes on X-Frame-Options: DENY and frame-ancestors none.
Also tighten the existing PDF marker regression assertion so it matches the actual historical corruption signature instead of contradicting the preserved [Page 1 text]: marker.
Fixes #2468
95 lines
3.2 KiB
Python
95 lines
3.2 KiB
Python
"""Regression: build_user_content must strip the '[PDF content]:' wrapper with
|
|
the prefix-safe helper, not str.lstrip(chars).
|
|
|
|
The PDF-attach path at build_user_content used
|
|
`_process_pdf(path).lstrip("\\n[PDF content]:")`, which treats the argument as a
|
|
set of characters and keeps eating leading body characters (so a page that
|
|
begins "Page 1 text]: to the board" lost its "P"/"to"). The other call sites
|
|
were switched to `strip_pdf_content_marker` (str.removeprefix); this one wasn't.
|
|
"""
|
|
import os
|
|
import tempfile
|
|
|
|
import src.document_processor as dp
|
|
import src.pdf_forms as pdf_forms
|
|
import src.pdf_form_doc as pdf_form_doc
|
|
|
|
|
|
class _FakeUploadHandler:
|
|
def is_image_file(self, name, mime):
|
|
return False
|
|
|
|
def is_audio_file(self, name, mime):
|
|
return False
|
|
|
|
def is_document_file(self, name, mime):
|
|
return True
|
|
|
|
def _inside_upload_dir(self, path):
|
|
return True
|
|
|
|
|
|
def test_pdf_body_marker_stripped_without_eating_text(monkeypatch, tmp_path):
|
|
pdf_path = tmp_path / "doc.pdf"
|
|
pdf_path.write_bytes(b"%PDF-1.4 fake")
|
|
|
|
# Shape _process_pdf actually returns: marker, then a page-text marker, then body.
|
|
raw = "\n\n[PDF content]:\n\n[Page 1 text]:\nto the board, the agenda is set"
|
|
monkeypatch.setattr(dp, "_process_pdf", lambda path, owner=None: raw)
|
|
monkeypatch.setattr(pdf_forms, "has_form_fields", lambda path: False)
|
|
monkeypatch.setattr(pdf_form_doc, "create_plain_pdf_document", lambda **kw: "doc-123")
|
|
|
|
resolved = {"fid1": {"path": str(pdf_path), "mime": "application/pdf", "name": "doc.pdf"}}
|
|
content = dp.build_user_content(
|
|
text="here is a pdf",
|
|
attachment_ids=["fid1"],
|
|
upload_dir=str(tmp_path),
|
|
upload_handler=_FakeUploadHandler(),
|
|
session_id="s1",
|
|
resolved_uploads=resolved,
|
|
)
|
|
|
|
body = content[0]["text"] if isinstance(content, list) else content
|
|
body_lines = body.splitlines()
|
|
# The leading page marker and page text must survive intact.
|
|
assert "[Page 1 text]:" in body_lines
|
|
assert "to the board, the agenda is set" in body_lines
|
|
# The old lstrip(chars) corruption produced a line like "age 1 text]:" (missing "[P").
|
|
assert "age 1 text]:" not in body_lines
|
|
|
|
|
|
def test_pdf_auto_document_uses_original_upload_name(monkeypatch, tmp_path):
|
|
pdf_path = tmp_path / "0123456789abcdef0123456789abcdef.pdf"
|
|
pdf_path.write_bytes(b"%PDF-1.4 fake")
|
|
|
|
captured = {}
|
|
monkeypatch.setattr(dp, "_process_pdf", lambda path: "\n\n[PDF content]:\nbody")
|
|
monkeypatch.setattr(pdf_forms, "has_form_fields", lambda path: False)
|
|
|
|
def _capture_plain_pdf_document(**kw):
|
|
captured.update(kw)
|
|
return "doc-123"
|
|
|
|
monkeypatch.setattr(pdf_form_doc, "create_plain_pdf_document", _capture_plain_pdf_document)
|
|
|
|
resolved = {
|
|
"fid1": {
|
|
"path": str(pdf_path),
|
|
"mime": "application/pdf",
|
|
"name": "Quarterly Board Packet.pdf",
|
|
}
|
|
}
|
|
|
|
dp.build_user_content(
|
|
text="here is a pdf",
|
|
attachment_ids=["fid1"],
|
|
upload_dir=str(tmp_path),
|
|
upload_handler=_FakeUploadHandler(),
|
|
session_id="s1",
|
|
resolved_uploads=resolved,
|
|
)
|
|
|
|
assert captured["title"] == "Quarterly Board Packet"
|
|
assert captured["upload_id"] == pdf_path.name
|
|
|