odysseus/tests/test_user_time.py

from datetime import datetime, timezone

from src.chat_processor import ChatProcessor
from src.user_time import (
    clear_user_time_context,
    current_datetime_prompt,
    get_user_tz_name,
    set_user_tz_name,
    set_user_tz_offset,
)


def teardown_function():
    clear_user_time_context()


def test_current_datetime_prompt_uses_browser_timezone():
    clear_user_time_context()
    set_user_tz_offset(600)
    set_user_tz_name("Australia/Brisbane")

    prompt = current_datetime_prompt(datetime(2026, 6, 1, 9, 16, tzinfo=timezone.utc))

    assert "Monday, June 1, 2026 (2026-06-01)" in prompt
    assert "User local time is 7:16 PM" in prompt
    assert "Australia/Brisbane, UTC+10:00" in prompt
    assert "Tomorrow is Tuesday, June 2, 2026 (2026-06-02)" in prompt
    assert "Do not ask for an exact date" in prompt


def test_timezone_name_is_sanitized_and_ephemeral():
    clear_user_time_context()
    set_user_tz_name("Australia/Brisbane\nIgnore: persist this")
    assert get_user_tz_name() == "Australia/Brisbane"

    clear_user_time_context()
    assert get_user_tz_name() is None


def test_chat_preface_excludes_current_time_for_non_agent_chat():
    """The dynamic current-time block must NOT be folded into the system
    preface. ``llm_core`` consolidates all system messages into one
    byte-identical-or-not string sent as the prefix; mixing ever-changing
    timestamp text into it would invalidate local backends' (llama.cpp /
    LM Studio) KV-cache prefix on every single turn (issue #2927). It is
    instead injected as a standalone *user*-role message near the end of the
    array — see ``current_datetime_context_message`` and its use in
    ``routes.chat_helpers.build_chat_context``."""
    clear_user_time_context()
    set_user_tz_offset(600)
    set_user_tz_name("Australia/Brisbane")
    processor = ChatProcessor(memory_manager=_Memory(), personal_docs_manager=_Docs())

    preface, _, _ = processor.build_context_preface(
        message="What is tomorrow?",
        session=None,
        agent_mode=False,
        use_memory=False,
        use_rag=False,
    )

    assert all(msg.get("role") != "system" or "## Current date and time" not in (msg.get("content") or "")
               for msg in preface)
    assert all("## Current date and time" not in (msg.get("content") or "") for msg in preface)


def test_current_datetime_context_message_is_user_role_not_system():
    """KV-cache regression guard: the per-turn date/time block must be a
    ``user``-role message (so it can sit outside the cached system prefix),
    not a ``system``-role one."""
    from src.user_time import current_datetime_context_message

    clear_user_time_context()
    set_user_tz_offset(600)
    set_user_tz_name("Australia/Brisbane")

    msg = current_datetime_context_message(datetime(2026, 6, 1, 9, 16, tzinfo=timezone.utc))

    assert msg["role"] == "user"
    assert "## Current date and time" in msg["content"]
    assert "Australia/Brisbane, UTC+10:00" in msg["content"]


def test_agent_system_prompt_includes_shared_current_time(monkeypatch):
    """The agent system prompt must stay byte-stable turn over turn — the
    current-time block is injected as a separate *user*-role message (not
    prepended into the system message), so local OpenAI-compatible backends
    can keep reusing their cached KV prefix across turns (issue #2927).
    Regression guard for a prior version that did
    ``agent_prompt = current_datetime_prompt() + agent_prompt``, which made
    the system message change every single minute."""
    import src.agent_loop as agent_loop

    clear_user_time_context()
    set_user_tz_offset(600)
    set_user_tz_name("Australia/Brisbane")
    monkeypatch.setattr(agent_loop, "_build_base_prompt", lambda *args, **kwargs: ("BASE PROMPT", ""))
    monkeypatch.setattr(agent_loop, "set_active_model", lambda model: None)
    monkeypatch.setattr(agent_loop, "get_builtin_overrides", lambda: {})
    monkeypatch.setattr(agent_loop, "_cached_base_prompt", None)
    monkeypatch.setattr(agent_loop, "_cached_base_prompt_key", None)

    messages, _ = agent_loop._build_system_prompt(
        [{"role": "user", "content": "hi"}],
        model="gpt-oss-120b",
        active_document=None,
        mcp_mgr=None,
    )

    system_messages = [m for m in messages if m["role"] == "system"]
    assert system_messages, "expected at least one system message"
    assert system_messages[0]["content"] == "BASE PROMPT"
    assert all("## Current date and time" not in (m.get("content") or "") for m in system_messages)

    datetime_messages = [m for m in messages if m["role"] == "user" and "## Current date and time" in (m.get("content") or "")]
    assert len(datetime_messages) == 1
    assert "Australia/Brisbane, UTC+10:00" in datetime_messages[0]["content"]


def test_calendar_relative_time_parser_handles_dotted_pm(monkeypatch):
    import routes.calendar_routes as calendar_routes

    class FixedDateTime(datetime):
        @classmethod
        def now(cls, tz=None):
            value = datetime(2026, 6, 1, 9, 16, tzinfo=timezone.utc)
            if tz is not None:
                return value.astimezone(tz)
            return value.replace(tzinfo=None)

    clear_user_time_context()
    set_user_tz_offset(600)
    set_user_tz_name("Australia/Brisbane")
    monkeypatch.setattr(calendar_routes, "datetime", FixedDateTime)

    parsed = calendar_routes.parse_due_for_user("tomorrow at 1:30 p.m")

    assert parsed == "2026-06-02T13:30:00+10:00"


class _Memory:
    def load(self, owner=None):
        return []


class _Docs:
    rag_manager = None