Files
odysseus/tests/test_chat_processor_web_search.py
T
Arpit e7c61a75b6 fix(search): use generated query for chat mode web search #4547 (#4557)
* fix(search): use generated query for chat mode web search #4547

* style(search): tidy query generation call

---------

Co-authored-by: Alexandre Teixeira <alexandremagteixeira@gmail.com>
2026-06-27 19:04:46 +01:00

96 lines
3.7 KiB
Python

from unittest.mock import MagicMock
from types import SimpleNamespace
from src.chat_processor import ChatProcessor
def test_build_context_preface_web_search_success(monkeypatch):
"""Test that LLM correctly extracts and uses a web search query."""
mock_llm_call = MagicMock(return_value="extracted query")
monkeypatch.setattr("src.llm_core.llm_call", mock_llm_call)
mock_web_search = MagicMock(return_value=("Search Results", [{"url": "http://mock.com"}]))
monkeypatch.setattr("src.chat_processor.comprehensive_web_search", mock_web_search)
processor = ChatProcessor(memory_manager=MagicMock(), personal_docs_manager=MagicMock())
session = SimpleNamespace(endpoint_url="http://local", model="test", headers={})
processor.build_context_preface(
message="Some text.\n\nSearch for LLMs.",
session=session,
use_web=True,
use_rag=False,
use_memory=False,
use_skills=False
)
mock_web_search.assert_called_with("extracted query", time_filter=None, return_sources=True)
def test_build_context_preface_web_search_fallback_on_llm_failure(monkeypatch):
"""Test fallback to original query if LLM fails."""
def failing_llm(*args, **kwargs):
raise ValueError("LLM down")
monkeypatch.setattr("src.llm_core.llm_call", failing_llm)
mock_web_search = MagicMock(return_value=("Search Results", []))
monkeypatch.setattr("src.chat_processor.comprehensive_web_search", mock_web_search)
processor = ChatProcessor(memory_manager=MagicMock(), personal_docs_manager=MagicMock())
session = SimpleNamespace(endpoint_url="http://local", model="test", headers={})
processor.build_context_preface(
message="First line\nSecond line",
session=session,
use_web=True,
use_rag=False,
use_memory=False,
use_skills=False
)
mock_web_search.assert_called_with("First line", time_filter=None, return_sources=True)
def test_build_context_preface_web_search_fallback_on_empty_generation(monkeypatch):
"""Test fallback to original query if LLM returns empty string."""
mock_llm_call = MagicMock(return_value=" \n ")
monkeypatch.setattr("src.llm_core.llm_call", mock_llm_call)
mock_web_search = MagicMock(return_value=("Search Results", []))
monkeypatch.setattr("src.chat_processor.comprehensive_web_search", mock_web_search)
processor = ChatProcessor(memory_manager=MagicMock(), personal_docs_manager=MagicMock())
session = SimpleNamespace(endpoint_url="http://local", model="test", headers={})
processor.build_context_preface(
message="\n\nFallback line\nNext",
session=session,
use_web=True,
use_rag=False,
use_memory=False,
use_skills=False
)
mock_web_search.assert_called_with("Fallback line", time_filter=None, return_sources=True)
def test_build_context_preface_web_search_query_sanitization(monkeypatch):
"""Test that query is truncated and whitespace collapsed."""
long_query = "word " * 50
mock_llm_call = MagicMock(return_value=long_query)
monkeypatch.setattr("src.llm_core.llm_call", mock_llm_call)
mock_web_search = MagicMock(return_value=("Search Results", []))
monkeypatch.setattr("src.chat_processor.comprehensive_web_search", mock_web_search)
processor = ChatProcessor(memory_manager=MagicMock(), personal_docs_manager=MagicMock())
session = SimpleNamespace(endpoint_url="http://local", model="test", headers={})
processor.build_context_preface(
message="Message",
session=session,
use_web=True,
use_rag=False,
use_memory=False,
use_skills=False
)
called_query = mock_web_search.call_args[0][0]
assert len(called_query) <= 150
assert " " not in called_query