mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-06-28 15:45:22 -04:00
Hinode
a5b60a34ee
* fix: include in-memory templates in group participant character list _getCharacterList() only fetched user templates from the /api/presets/templates endpoint. When a character was just created in the Character tab, the async auto-save to the templates API might not have completed by the time the Group tab loaded its participant dropdown — causing newly created characters to be missing. Now also merges the in-memory userTemplates array from presets.js as a fallback. These are updated as soon as the async save completes (via the loadUserTemplates callback), so they bridge the gap between character creation and API persistence. Fixes #3207 * fix: optimistic userTemplates update on character save Update the in-memory userTemplates array immediately when saveCustomPreset() succeeds, before the fire-and-forget templates API POST completes. This bridges the timing gap where _getCharacterList() calls getUserTemplates() and gets stale data because loadUserTemplates() hasn't been triggered yet. * test: verify group participant dropdown merges in-memory templates Source-level guards for the #3207 fix: - group.js imports and calls getUserTemplates() to merge in-memory templates - presets.js exports getUserTemplates and does optimistic in-memory update on save 5 tests ensuring the fix can't be silently reverted. * fix: generate client-side id for optimistic update, return shallow copy from getUserTemplates 1. New characters now get a 'user-<hex>' id immediately on save, matching the server's convention (uuid.uuid4().hex[:8]). Previously the id was '' which the merge guard in _getCharacterList filtered as falsy. 2. getUserTemplates() now returns [...userTemplates] so callers cannot accidentally mutate module state. * fix(group.js): fix selection drop-downs behavior - add an identifier to the selection drop-downs based on what type it is. - fix behavior of continuously adding a row when a user clicks the "Group" tab button. - fix behavior of not repopulating existing selection drop-downs whenever a user clicks the "Group" tab button. * fix(#3207): remove duplicate of latest persona - fix the duplication of the latest persona or character being shown in selection drop-downs. - remove unnecessary blocks of code in `_getCharacterList()` - add functionality to show error toast if saving a preset template/character fails. - add functionality to revert optimistic update of preset template/character if saving fails. * chore(group.js,preset.js): fix test & format errors remove trailing whitespaces in lines 230 and 232 in /static/group.js add back the expected syntax from tests/test_group_character_dropdown.py * fix(presets.js,group.js): fix runtime errors as stated in a comment by @alteixeira20, runtime errors exist for the applied fixes. fixes: - missing ending `]` querySelectorAll("select.preset-input[data-selection-type=character") in `group.js` - spelling error in `modelSelection.vale` in `group.js` - fix the ordering logic error in optimistic rollback where `Object.assign` is called first before the clone happens in `saveCustomPreset` in `presets.js`. - add tests for the cloning logic bug with the same format as previous tests by checking the order of LOC in `tests/test_group_character_dropdown.py`. --------- Co-authored-by: michaelxer <michaelxer@users.noreply.github.com> Co-authored-by: Alexandre Teixeira <111787685+alteixeira20@users.noreply.github.com>