From da3e4644ee96cc74fb9bf6d816e27dd5aa984cea Mon Sep 17 00:00:00 2001 From: Max Goodhart Date: Sun, 21 Jun 2020 01:34:02 -0700 Subject: [PATCH] Fix requesting cert for wrong hostname --- src/node/server.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/node/server.js b/src/node/server.js index 4c2ba2d..46fb18a 100644 --- a/src/node/server.js +++ b/src/node/server.js @@ -92,9 +92,6 @@ export default async function initWebServer({ if (!port) { port = protocol === 'https' ? 443 : 80 } - if (overrideHostname) { - hostname = overrideHostname - } if (overridePort) { port = overridePort } @@ -114,7 +111,7 @@ export default async function initWebServer({ commonName: hostname, email, production: process.env.NODE_DEV === 'production', - serverHost: hostname, + serverHost: overrideHostname || hostname, }) server = https.createServer({ key, cert }, app.callback()) } else { @@ -122,7 +119,7 @@ export default async function initWebServer({ } const listen = promisify(server.listen).bind(server) - await listen(port, hostname) + await listen(port, overrideHostname || hostname) return { broadcastState } }