1
0
mirror of https://github.com/AvengeMedia/DankMaterialShell.git synced 2025-12-05 21:15:38 -05:00

brightness: dont cap to 1 minimum for non-backlight/ddc

This commit is contained in:
bbedward
2025-11-03 15:39:49 -05:00
parent 3640d8bd24
commit 3f70ca3506
4 changed files with 24 additions and 4 deletions

View File

@@ -310,6 +310,13 @@ Rectangle {
hoverEnabled: true
cursorShape: Qt.PointingHandCursor
onClicked: {
if (screenName && screenName.length > 0 && modelData.name !== currentDeviceName) {
const pins = JSON.parse(JSON.stringify(SettingsData.brightnessDevicePins || {}))
if (pins[screenName]) {
delete pins[screenName]
SettingsData.setBrightnessDevicePins(pins)
}
}
currentDeviceName = modelData.name
deviceNameChanged(modelData.name)
}

View File

@@ -145,7 +145,10 @@ Row {
anchors.verticalCenter: parent.verticalCenter
width: parent.width - (Theme.iconSize + Theme.spacingS * 2)
enabled: DisplayService.brightnessAvailable && targetDeviceName.length > 0
minimum: 1
minimum: {
if (!targetDevice) return 1
return (targetDevice.class === "backlight" || targetDevice.class === "ddc") ? 1 : 0
}
maximum: 100
value: targetBrightness
onSliderValueChanged: function (newValue) {

View File

@@ -60,7 +60,11 @@ DankOSD {
height: 40
x: parent.gap * 2 + Theme.iconSize
anchors.verticalCenter: parent.verticalCenter
minimum: 1
minimum: {
const deviceInfo = DisplayService.getCurrentDeviceInfo()
if (!deviceInfo) return 1
return (deviceInfo.class === "backlight" || deviceInfo.class === "ddc") ? 1 : 0
}
maximum: 100
enabled: DisplayService.brightnessAvailable
showValue: true

View File

@@ -103,7 +103,6 @@ Singleton {
}
function setBrightness(percentage, device, suppressOsd) {
const clampedValue = Math.max(1, Math.min(100, percentage))
const actualDevice = device === "" ? getDefaultDevice() : (device || currentDevice || getDefaultDevice())
if (!actualDevice) {
@@ -111,6 +110,10 @@ Singleton {
return
}
const deviceInfo = getCurrentDeviceInfoByName(actualDevice)
const minValue = (deviceInfo && (deviceInfo.class === "backlight" || deviceInfo.class === "ddc")) ? 1 : 0
const clampedValue = Math.max(minValue, Math.min(100, percentage))
if (!DMSService.isConnected) {
console.warn("DisplayService: Not connected to DMS")
return
@@ -588,13 +591,16 @@ Singleton {
return "Invalid brightness value: " + percentage
}
const clampedValue = Math.max(1, Math.min(100, value))
const targetDevice = device || ""
if (targetDevice && !root.devices.some(d => d.id === targetDevice)) {
return "Device not found: " + targetDevice
}
const deviceInfo = targetDevice ? root.getCurrentDeviceInfoByName(targetDevice) : null
const minValue = (deviceInfo && (deviceInfo.class === "backlight" || deviceInfo.class === "ddc")) ? 1 : 0
const clampedValue = Math.max(minValue, Math.min(100, value))
root.lastIpcDevice = targetDevice
if (targetDevice && targetDevice !== root.currentDevice) {
root.setCurrentDevice(targetDevice, false)