Don't log secrets in the cache miss messages

This commit is contained in:
barelyprofessional
2025-03-22 13:50:12 +08:00
parent 0826ae42ce
commit f895ebe5b9

View File

@@ -47,8 +47,17 @@ public static class Helpers
logger.Debug($"{key}'s value is null so returning SettingValue(null)"); logger.Debug($"{key}'s value is null so returning SettingValue(null)");
return new SettingValue(null, setting, false); return new SettingValue(null, setting, false);
} }
logger.Info($"Cache Miss! Returning '{setting.Value}' for {key}"); if (setting.IsSecret)
{
logger.Info($"Cache Miss! Returning secret of length '{setting.Value?.Length}' for {key}");
}
else
{
logger.Info($"Cache Miss! Returning '{setting.Value}' for {key}");
}
return new SettingValue(setting.Value, setting, false); return new SettingValue(setting.Value, setting, false);
} }