Hide timestamps when no media is playing

.gitignore

@@ -1,6 +1,2 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
-
 CMakeLists.txt.user
 flatpak/flatpak-builder-tools/

.gitlab-ci.yml

@@ -1,6 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
-
-include:
- - 'https://invent.kde.org/sysadmin/ci-tooling/raw/master/invent/ci-reuse.yml'

.reuse/dep5

@@ -1,4 +0,0 @@
-Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: AudioTube
-Upstream-Contact: Jonah Brüchert <[email protected]>
-Source: https://invent.kde.org/plasma-mobile/audiotube

CMakeLists.txt

@@ -1,8 +1,4 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: BSD-2-Clause
-
-cmake_minimum_required(VERSION 3.16.0)
+cmake_minimum_required(VERSION 3.14)
 
 project(audiotube)
 
@@ -16,7 +12,7 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 find_package(ECM ${KF5_MIN_VERSION} REQUIRED NO_MODULE)
 
-set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH} ${CMAKE_SOURCE_DIR}/cmake)
+set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})
 
 include(KDEInstallDirs)
 include(KDECMakeSettings)
@@ -28,10 +24,8 @@ include(ECMPoQmTools)
 kde_enable_exceptions()
 
 find_package(Qt5 ${QT5_MIN_VERSION} REQUIRED COMPONENTS Core Gui Qml QuickControls2 Svg)
-find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Kirigami2 I18n CoreAddons Crash)
+find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Kirigami2 I18n)
 find_package(pybind11 REQUIRED)
-find_package(YoutubeDL REQUIRED RUNTIME)
-find_package(YTMusicAPI REQUIRED RUNTIME)
 
 add_subdirectory(src)
 

LICENSES/BSD-2-Clause.txt

@@ -1,22 +0,0 @@
-Copyright (c) <year> <owner>. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without modification,
-are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice,
-this list of conditions and the following disclaimer.
-
-2. Redistributions in binary form must reproduce the above copyright notice,
-this list of conditions and the following disclaimer in the documentation
-and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
-LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
-SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
-CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
-OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
-USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

LICENSES/CC0-1.0.txt

@@ -1,119 +0,0 @@
-Creative Commons Legal Code
-
-CC0 1.0 Universal CREATIVE COMMONS CORPORATION IS NOT A LAW FIRM AND DOES
-NOT PROVIDE LEGAL SERVICES. DISTRIBUTION OF THIS DOCUMENT DOES NOT CREATE
-AN ATTORNEY-CLIENT RELATIONSHIP. CREATIVE COMMONS PROVIDES THIS INFORMATION
-ON AN "AS-IS" BASIS. CREATIVE COMMONS MAKES NO WARRANTIES REGARDING THE USE
-OF THIS DOCUMENT OR THE INFORMATION OR WORKS PROVIDED HEREUNDER, AND DISCLAIMS
-LIABILITY FOR DAMAGES RESULTING FROM THE USE OF THIS DOCUMENT OR THE INFORMATION
-OR WORKS PROVIDED HEREUNDER.
-
-Statement of Purpose
-
-The laws of most jurisdictions throughout the world automatically confer exclusive
-Copyright and Related Rights (defined below) upon the creator and subsequent
-owner(s) (each and all, an "owner") of an original work of authorship and/or
-a database (each, a "Work").
-
-Certain owners wish to permanently relinquish those rights to a Work for the
-purpose of contributing to a commons of creative, cultural and scientific
-works ("Commons") that the public can reliably and without fear of later claims
-of infringement build upon, modify, incorporate in other works, reuse and
-redistribute as freely as possible in any form whatsoever and for any purposes,
-including without limitation commercial purposes. These owners may contribute
-to the Commons to promote the ideal of a free culture and the further production
-of creative, cultural and scientific works, or to gain reputation or greater
-distribution for their Work in part through the use and efforts of others.
-
-For these and/or other purposes and motivations, and without any expectation
-of additional consideration or compensation, the person associating CC0 with
-a Work (the "Affirmer"), to the extent that he or she is an owner of Copyright
-and Related Rights in the Work, voluntarily elects to apply CC0 to the Work
-and publicly distribute the Work under its terms, with knowledge of his or
-her Copyright and Related Rights in the Work and the meaning and intended
-legal effect of CC0 on those rights.
-
-1. Copyright and Related Rights. A Work made available under CC0 may be protected
-by copyright and related or neighboring rights ("Copyright and Related Rights").
-Copyright and Related Rights include, but are not limited to, the following:
-
-i. the right to reproduce, adapt, distribute, perform, display, communicate,
-and translate a Work;
-
-      ii. moral rights retained by the original author(s) and/or performer(s);
-
-iii. publicity and privacy rights pertaining to a person's image or likeness
-depicted in a Work;
-
-iv. rights protecting against unfair competition in regards to a Work, subject
-to the limitations in paragraph 4(a), below;
-
-v. rights protecting the extraction, dissemination, use and reuse of data
-in a Work;
-
-vi. database rights (such as those arising under Directive 96/9/EC of the
-European Parliament and of the Council of 11 March 1996 on the legal protection
-of databases, and under any national implementation thereof, including any
-amended or successor version of such directive); and
-
-vii. other similar, equivalent or corresponding rights throughout the world
-based on applicable law or treaty, and any national implementations thereof.
-
-2. Waiver. To the greatest extent permitted by, but not in contravention of,
-applicable law, Affirmer hereby overtly, fully, permanently, irrevocably and
-unconditionally waives, abandons, and surrenders all of Affirmer's Copyright
-and Related Rights and associated claims and causes of action, whether now
-known or unknown (including existing as well as future claims and causes of
-action), in the Work (i) in all territories worldwide, (ii) for the maximum
-duration provided by applicable law or treaty (including future time extensions),
-(iii) in any current or future medium and for any number of copies, and (iv)
-for any purpose whatsoever, including without limitation commercial, advertising
-or promotional purposes (the "Waiver"). Affirmer makes the Waiver for the
-benefit of each member of the public at large and to the detriment of Affirmer's
-heirs and successors, fully intending that such Waiver shall not be subject
-to revocation, rescission, cancellation, termination, or any other legal or
-equitable action to disrupt the quiet enjoyment of the Work by the public
-as contemplated by Affirmer's express Statement of Purpose.
-
-3. Public License Fallback. Should any part of the Waiver for any reason be
-judged legally invalid or ineffective under applicable law, then the Waiver
-shall be preserved to the maximum extent permitted taking into account Affirmer's
-express Statement of Purpose. In addition, to the extent the Waiver is so
-judged Affirmer hereby grants to each affected person a royalty-free, non
-transferable, non sublicensable, non exclusive, irrevocable and unconditional
-license to exercise Affirmer's Copyright and Related Rights in the Work (i)
-in all territories worldwide, (ii) for the maximum duration provided by applicable
-law or treaty (including future time extensions), (iii) in any current or
-future medium and for any number of copies, and (iv) for any purpose whatsoever,
-including without limitation commercial, advertising or promotional purposes
-(the "License"). The License shall be deemed effective as of the date CC0
-was applied by Affirmer to the Work. Should any part of the License for any
-reason be judged legally invalid or ineffective under applicable law, such
-partial invalidity or ineffectiveness shall not invalidate the remainder of
-the License, and in such case Affirmer hereby affirms that he or she will
-not (i) exercise any of his or her remaining Copyright and Related Rights
-in the Work or (ii) assert any associated claims and causes of action with
-respect to the Work, in either case contrary to Affirmer's express Statement
-of Purpose.
-
-   4. Limitations and Disclaimers.
-
-a. No trademark or patent rights held by Affirmer are waived, abandoned, surrendered,
-licensed or otherwise affected by this document.
-
-b. Affirmer offers the Work as-is and makes no representations or warranties
-of any kind concerning the Work, express, implied, statutory or otherwise,
-including without limitation warranties of title, merchantability, fitness
-for a particular purpose, non infringement, or the absence of latent or other
-defects, accuracy, or the present or absence of errors, whether or not discoverable,
-all to the greatest extent permissible under applicable law.
-
-c. Affirmer disclaims responsibility for clearing rights of other persons
-that may apply to the Work or any use thereof, including without limitation
-any person's Copyright and Related Rights in the Work. Further, Affirmer disclaims
-responsibility for obtaining any necessary consents, permissions or other
-rights required for any use of the Work.
-
-d. Affirmer understands and acknowledges that Creative Commons is not a party
-to this document and has no duty or obligation with respect to this CC0 or
-use of the Work.

README.md.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: CC0-1.0

audiotube.kdev4

@@ -1,4 +0,0 @@
-[Project]
-CreatedFrom=CMakeLists.txt
-Manager=KDevCMakeManager
-Name=audiotube

audiotube.kdev4.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: CC0-1.0

cmake/FindYTMusicAPI.cmake

@@ -1,11 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: BSD-2-Clause
-
-find_package(Python3 REQUIRED COMPONENTS Interpreter)
-
-execute_process(COMMAND ${Python3_EXECUTABLE} -c "import ytmusicapi" RESULT_VARIABLE YTMUSICAPI_CHECK_RESULT)
-
-if (${YTMUSICAPI_CHECK_RESULT} EQUAL 0)
-	set(YTMusicAPI_FOUND TRUE)
-endif()

cmake/FindYoutubeDL.cmake

@@ -1,11 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: BSD-2-Clause
-
-find_package(Python3 REQUIRED COMPONENTS Interpreter)
-
-execute_process(COMMAND ${Python3_EXECUTABLE} -c "import youtube_dl" RESULT_VARIABLE YTDL_CHECK_RESULT)
-
-if (${YTDL_CHECK_RESULT} EQUAL 0)
-	set(YoutubeDL_FOUND TRUE)
-endif()

flatpak/python3-youtube_dl.json

@@ -7,8 +7,8 @@
     "sources": [
         {
             "type": "file",
-            "url": "https://files.pythonhosted.org/packages/c6/75/05979677d9abc76851d13d8db3951e39017ac223545adab6e8576fa0cbe7/youtube_dl-2021.6.6.tar.gz",
-            "sha256": "cb2d3ee002158ede783e97a82c95f3817594df54367ea6a77ce5ceea4772f0ab"
+            "url": "https://files.pythonhosted.org/packages/94/a0/b8325b524700daae1c04a6156473ab7091d44071353f1d7c9e66b9c7f019/youtube_dl-2021.4.26.tar.gz",
+            "sha256": "6f311ffaf8b88cdcf27a2301a2272455e213bdb780aa447246933a3da4532879"
         }
     ]
 }

flatpak/python3-youtube_dl.json.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

flatpak/python3-ytmusicapi.json

@@ -7,8 +7,8 @@
     "sources": [
         {
             "type": "file",
-            "url": "https://files.pythonhosted.org/packages/4f/5a/597ef5911cb8919efe4d86206aa8b2658616d676a7088f0825ca08bd7cb8/urllib3-1.26.6.tar.gz",
-            "sha256": "f57b4c16c62fa2760b7e3d97c35b255512fb6b59a259730f36ba32ce9f8e342f"
+            "url": "https://files.pythonhosted.org/packages/cb/cf/871177f1fc795c6c10787bc0e1f27bb6cf7b81dbde399fd35860472cecbc/urllib3-1.26.4.tar.gz",
+            "sha256": "e7b021f7241115872f92f43c6508082facffbd1c048e3c6e2bb9c2a157e28937"
         },
         {
             "type": "file",
@@ -22,8 +22,8 @@
         },
         {
             "type": "file",
-            "url": "https://files.pythonhosted.org/packages/6d/78/f8db8d57f520a54f0b8a438319c342c61c22759d8f9a1cd2e2180b5e5ea9/certifi-2021.5.30.tar.gz",
-            "sha256": "2bbf76fd432960138b3ef6dda3dde0544f27cbf8546c458e60baf371917ba9ee"
+            "url": "https://files.pythonhosted.org/packages/06/a9/cd1fd8ee13f73a4d4f491ee219deeeae20afefa914dfb4c130cfc9dc397a/certifi-2020.12.5.tar.gz",
+            "sha256": "1a4995114262bffbc2413b159f2a1a480c969de6e6eb13ee966d470af86af59c"
         },
         {
             "type": "file",
@@ -32,8 +32,8 @@
         },
         {
             "type": "file",
-            "url": "https://files.pythonhosted.org/packages/1b/8e/2bc4c8160083bbfaac215637f1e9f4a43263833c2e81212cba3073aeaa25/ytmusicapi-0.17.3.tar.gz",
-            "sha256": "9a249cc53efd6408034f401a9a4375272a9b339e8eb64f3a2e713a1ccd06d55b"
+            "url": "https://files.pythonhosted.org/packages/61/b5/da439d5f75db7ff17790b19136c835f9a315530436ee7bc9d75aeea2f6e5/ytmusicapi-0.16.0.tar.gz",
+            "sha256": "ffde3fb5a78123ac59dee37fc1f32793f34f9a4fa3d3e69a1fc08064112c2b5d"
         }
     ]
 }

flatpak/python3-ytmusicapi.json.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

flatpak/regenerate-sources.sh

@@ -1,9 +1,5 @@
 #!/usr/bin/env bash
 
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
-
 set -e
 
 export GIT_CLONE_ARGS="--depth 1 --single-branch"

logo.png.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Mathis Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

org.kde.audiotube.appdata.xml

@@ -1,31 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!--
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: CC0-1.0
--->
 <component type="desktop-application">
   <id>org.kde.audiotube</id>
   <name>AudioTube</name>
   <name xml:lang="ca">AudioTube</name>
   <name xml:lang="ca-valencia">AudioTube</name>
-  <name xml:lang="cs">AudioTube</name>
   <name xml:lang="de">AudioTube</name>
-  <name xml:lang="en-GB">AudioTube</name>
   <name xml:lang="es">AudioTube</name>
-  <name xml:lang="eu">AudioTube</name>
-  <name xml:lang="fi">AudioTube</name>
-  <name xml:lang="fr">AudioTube</name>
-  <name xml:lang="hi">ओडियो-ट्यूब</name>
-  <name xml:lang="it">AudioTube</name>
   <name xml:lang="ko">AudioTube</name>
   <name xml:lang="nl">AudioTube</name>
-  <name xml:lang="pa">ਆਡੀਓ-ਟਿਊਬ</name>
-  <name xml:lang="pl">AudioTube</name>
-  <name xml:lang="pt">AudioTube</name>
-  <name xml:lang="pt-BR">AudioTube</name>
-  <name xml:lang="sk">AudioTube</name>
-  <name xml:lang="sl">AudioTube</name>
   <name xml:lang="sv">AudioTube</name>
   <name xml:lang="uk">AudioTube</name>
   <name xml:lang="x-test">xxAudioTubexx</name>
@@ -33,19 +15,9 @@ SPDX-License-Identifier: CC0-1.0
   <summary xml:lang="ca">Client convergent per a la música de YouTube</summary>
   <summary xml:lang="ca-valencia">Client convergent per a la música de YouTube</summary>
   <summary xml:lang="de">Konvergentes YouTube-Musikprogramm</summary>
-  <summary xml:lang="en-GB">Convergent YouTube Music client</summary>
   <summary xml:lang="es">Cliente de música de YouTube convergente</summary>
-  <summary xml:lang="eu">YouTube Music bezero konbergentea</summary>
-  <summary xml:lang="fi">Mukautuva YouTube Music -asiakas</summary>
-  <summary xml:lang="fr">Client convergent pour musique sur YouTube</summary>
-  <summary xml:lang="hi">अभिसृत यूट्यूब संगीत क्लाएंट</summary>
-  <summary xml:lang="it">Client YouTube Music convergente</summary>
   <summary xml:lang="ko">올인원 YouTube Music 클라이언트</summary>
   <summary xml:lang="nl">Convergente muziekclient van YouTube</summary>
-  <summary xml:lang="pl">Całościowy program do muzyki z YouTube</summary>
-  <summary xml:lang="pt">Cliente de música do YouTube convergente</summary>
-  <summary xml:lang="pt-BR">Um cliente convergente para o YouTube Music</summary>
-  <summary xml:lang="sl">Konvergentni odjemalec glasbe YouTube</summary>
   <summary xml:lang="sv">Konvergent YouTube-musikprogram</summary>
   <summary xml:lang="uk">Зручний музичний клієнт YouTube</summary>
   <summary xml:lang="x-test">xxConvergent YouTube Music clientxx</summary>
@@ -54,60 +26,21 @@ SPDX-License-Identifier: CC0-1.0
   <developer_name>KDE Community</developer_name>
   <developer_name xml:lang="ca">La comunitat KDE</developer_name>
   <developer_name xml:lang="ca-valencia">La comunitat KDE</developer_name>
-  <developer_name xml:lang="cs">Komunita KDE</developer_name>
   <developer_name xml:lang="de">KDE-Gemeinschaft</developer_name>
-  <developer_name xml:lang="en-GB">KDE Community</developer_name>
   <developer_name xml:lang="es">Comunidad KDE</developer_name>
-  <developer_name xml:lang="eu">KDE komunitatea</developer_name>
-  <developer_name xml:lang="fi">KDE-yhteisö</developer_name>
-  <developer_name xml:lang="fr">Communauté de KDE</developer_name>
-  <developer_name xml:lang="hi">केडीई समुदाय</developer_name>
-  <developer_name xml:lang="it">Comunità KDE</developer_name>
   <developer_name xml:lang="ko">KDE 커뮤니티</developer_name>
   <developer_name xml:lang="nl">KDE-gemeenschap</developer_name>
-  <developer_name xml:lang="pa">ਕੇਡੀਈ ਕਮਿਊਨਟੀ</developer_name>
-  <developer_name xml:lang="pl">Społeczność KDE</developer_name>
-  <developer_name xml:lang="pt">Comunidade do KDE</developer_name>
-  <developer_name xml:lang="pt-BR">A Comunidade KDE</developer_name>
-  <developer_name xml:lang="sk">KDE komunita</developer_name>
-  <developer_name xml:lang="sl">Skupnost KDE</developer_name>
   <developer_name xml:lang="sv">KDE-gemenskapen</developer_name>
   <developer_name xml:lang="uk">Спільнота KDE</developer_name>
   <developer_name xml:lang="x-test">xxKDE Communityxx</developer_name>
-  <content_rating type="oars-1.0"/>
-  <url type="homepage">https://apps.kde.org/en/audiotube</url>
-  <launchable type="desktop-id">org.kde.audiotube.desktop</launchable>
-  <screenshots>
-    <screenshot>
-      <image>https://cdn.kde.org/screenshots/audiotube/desktop.png</image>
-    </screenshot>
-    <screenshot>
-      <image>https://cdn.kde.org/screenshots/audiotube/mobile_playlist.png</image>
-    </screenshot>
-  </screenshots>
-  <recommends>
-    <control>pointing</control>
-    <control>keyboard</control>
-    <control>touch</control>
-  </recommends>
   <description>
     <p>AudioTube can search YouTube Music, list albums and artists, play automatically generated playlists, albums and allows to put your own playlist together.</p>
     <p xml:lang="ca">L'AudioTube pot cercar música a YouTube, llistar àlbums i artistes, reproduir llistes de reproducció generades automàticament, àlbums i permet crear la vostra pròpia llista de reproducció.</p>
     <p xml:lang="ca-valencia">L'AudioTube pot cercar música a YouTube, llistar àlbums i artistes, reproduir llistes de reproducció generades automàticament, àlbums i permet crear la vostra pròpia llista de reproducció.</p>
     <p xml:lang="de">AudioTube kann Musik auf YouTube durchsuchen, Alben und Interpreten auflisten, automatisch generierte Wiedergabelisten und Alben abspielen und erlaubt es, eine eigene Wiedergabeliste zusammenzustellen.</p>
-    <p xml:lang="en-GB">AudioTube can search YouTube Music, list albums and artists, play automatically generated playlists, albums and allows to put your own playlist together.</p>
     <p xml:lang="es">AudioTube puede buscar música de YouTube, listar álbumes y artistas, reproducir las listas de reproducción generadas, álbumes y le permite crear su propia lista de reproducción.</p>
-    <p xml:lang="eu">AudioTube-k YouTube Music-en bilatu dezake, albumak eta artistak zerrendatu, automatikoki sortutako jotze-zerrendak eta albumak jo, eta zure jotze-zerrenda osatzeko aukera eskaintzen dizu.</p>
-    <p xml:lang="fi">AudioTube osaa etsiä YouTube Music -haun, albumien ja artistien luettelun, luotujen soittolistojen automaattisen toiston ja omien soittolistojen kokoamisen.</p>
-    <p xml:lang="fr">AudioTube peut effectuer des recherches de musiques sur YouTube Music, établir une liste d'albums et d'artistes, lire des listes de lecture générées automatiquement, des albums et permet de composer sa propre liste de lecture.</p>
-    <p xml:lang="hi">ऑडियोट्यूब यूट्यूब संगीत खोज सकता है, एल्बम और कलाकारों की सूची बना सकता है, स्वचालित रूप से उत्पन्न की गई गीतसूची, एल्बम बजा सकता है और आपकी अपनी खुद की प्लेलिस्ट को एक साथ रखने में मदद करता है।</p>
-    <p xml:lang="it">AudioTube può eseguire ricerche su YouTube Music, elencare album e artisti, riprodurre scalette e album generati automaticamente e ti consente di creare la tua scaletta.</p>
     <p xml:lang="ko">AudioTube는 YouTube Music을 검색하고, 앨범과 아티스트를 표시하고, 자동 생성된 재생 목록, 앨범을 재생하고, 사용자 정의 재생 목록을 만들 수 있습니다.</p>
     <p xml:lang="nl">AudioTube kan in YouTube Music zoeken, een lijst maken van albums en artiesten, automatically gegenereerde afspeellijsten, albums afspelen en biedt u het samenstellen van uw eigen afspeellijst.</p>
-    <p xml:lang="pl">AudioTube może wyszukać muzyki na YouTube, wypisać albumy i wykonawców, odtwarzać samoczynnie utworzone listy odtwarzania, albumy oraz umożliwia tworzenie własnych list odtwarzania.</p>
-    <p xml:lang="pt">O AudioTube consegue pesquisar no YouTube Music, enumerar os álbuns e artistas, reproduzir listas geradas automaticamente, álbuns e permite-lhe reproduzir as suas próprias listas de reprodução.</p>
-    <p xml:lang="pt-BR">O AudioTube pode pesquisar no YouTube Music, listar álbuns e artistas, rodar listas de reprodução geradas automaticamente, álbuns inteiros, e criar a sua própria lista de reprodução.</p>
-    <p xml:lang="sl">AudioTube lahko išče po YouTube Music, izdela sezname albumov in avtorjev, samodejno predvaja generirane sezname, albume in sestavlja vaše sezname predvajanja.</p>
     <p xml:lang="sv">AudioTube kan söka på YouTube Music, lista album och artister, spela upp automatiskt genererade spellistor, albums och låter dig sammanställa egna spellistor.</p>
     <p xml:lang="uk">AudioTube може виконувати пошук на YouTube Music, показувати списки альбомів та виконавців, відтворювати створені автоматично списки відтворення, альбоми та надає вам змогу створювати власні списки відворення.</p>
     <p xml:lang="x-test">xxAudioTube can search YouTube Music, list albums and artists, play automatically generated playlists, albums and allows to put your own playlist together.xx</p>

org.kde.audiotube.desktop

@@ -2,46 +2,20 @@
 Name=AudioTube
 Name[ca]=AudioTube
 Name[ca@valencia]=AudioTube
-Name[cs]=AudioTube
 Name[de]=AudioTube
-Name[en_GB]=AudioTube
 Name[es]=AudioTube
-Name[eu]=AudioTube
-Name[fi]=AudioTube
-Name[fr]=AudioTube
-Name[hi]=ओडियो-ट्यूब
-Name[it]=AudioTube
 Name[ko]=AudioTube
 Name[nl]=AudioTube
-Name[pa]=ਆਡੀਓ-ਟਿਊਬ
-Name[pl]=AudioTube
-Name[pt]=AudioTube
-Name[pt_BR]=AudioTube
-Name[sk]=AudioTube
-Name[sl]=AudioTube
 Name[sv]=AudioTube
 Name[uk]=AudioTube
 Name[x-test]=xxAudioTubexx
 Comment=YouTube Music client
 Comment[ca]=Client de música de YouTube
 Comment[ca@valencia]=Client de música de YouTube
-Comment[cs]=Hudební klient YouTube
 Comment[de]=YouTube-Musikprogramm
-Comment[en_GB]=YouTube Music client
 Comment[es]=Cliente de música de YouTube
-Comment[eu]=YouTube Music bezeroa
-Comment[fi]=YouTube Music -asiakas
-Comment[fr]=Client de musique sur Youtube
-Comment[hi]=यूट्यूब संगीत क्लाएंट
-Comment[it]=Client YouTube Music
 Comment[ko]=YouTube Music 클라이언트
 Comment[nl]=Muziekclient van YouTube
-Comment[pa]=ਯੂਟਿਊਬ ਸੰਗੀਤ ਕਲਾਈਂਟ
-Comment[pl]=Program do muzyki z YouTube
-Comment[pt]=Cliente do YouTube Music
-Comment[pt_BR]=Cliente YouTube Music
-Comment[sk]=Hudobný klient YouTube
-Comment[sl]=Glasbeni odjemalec Youtube
 Comment[sv]=YouTube-musikprogram
 Comment[uk]=Музичний клієнт YouTube
 Comment[x-test]=xxYouTube Music clientxx

org.kde.audiotube.desktop.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

org.kde.audiotube.json.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

org.kde.audiotube.svg.license

@@ -1,3 +0,0 @@
-SPDX-FileCopyrightText: 2021 Mathis Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

requirements.txt

@@ -1,7 +1,2 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-# SPDX-FileCopyrightText: 2021 Kuba Prussak <[email protected]>
-#
-# SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
-
-ytmusicapi==0.17.3
+ytmusicapi==0.16.0
 youtube_dl

src/CMakeLists.txt

@@ -1,7 +1,3 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: BSD-2-Clause
-
 add_library(ytm STATIC
     ytmusic.cpp
 )
@@ -23,7 +19,6 @@ add_executable(audiotube
     playlistmodel.cpp
     playlistutils.cpp
     errorhandler.cpp
-    playerutils.cpp
     multiiterableview.h
     resources.qrc
 )
@@ -36,8 +31,6 @@ target_link_libraries(audiotube
     Qt5::QuickControls2
     Qt5::Svg
     KF5::I18n
-    KF5::CoreAddons
-    KF5::Crash
     ytm
 )
 target_compile_definitions(audiotube PRIVATE -DQT_NO_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING)

src/Messages.sh

@@ -1,4 +0,0 @@
-#! /usr/bin/env bash
-# SPDX-FileCopyrightText: 2020 Tobias Fella <[email protected]>
-# SPDX-License-Identifier: CC0-1.0
-$XGETTEXT `find -name \*.cpp -o -name \*.qml -o -name \*.js` -o $podir/audiotube.pot

src/artistmodel.cpp

@@ -24,16 +24,10 @@ ArtistModel::ArtistModel(QObject *parent)
         beginResetModel();
         m_artist = artist;
         std::sort(m_artist.thumbnails.begin(), m_artist.thumbnails.end());
-
-        auto albums = m_artist.albums ? m_artist.albums->results : std::vector<artist::Artist::Album>();
-        auto singles = m_artist.singles ? m_artist.singles->results : std::vector<artist::Artist::Single>();
-        auto songs = m_artist.songs ? m_artist.songs->results : std::vector<artist::Artist::Song>();
-        auto videos = m_artist.videos ? m_artist.videos->results : std::vector<artist::Artist::Video>();
-
-        m_view = std::optional(MultiIterableView(std::move(albums),
-                                                 std::move(singles),
-                                                 std::move(songs),
-                                                 std::move(videos)));
+        m_view = std::optional(MultiIterableView(m_artist.albums->results,
+                                                 m_artist.singles->results,
+                                                 m_artist.songs->results,
+                                                 m_artist.videos->results));
         endResetModel();
 
 
@@ -174,7 +168,7 @@ void ArtistModel::triggerItem(int row)
             } else if constexpr(std::is_same_v<T, artist::Artist::Song>) {
                 Q_EMIT openSong(QString::fromStdString(item.video_id));
             } else if constexpr(std::is_same_v<T, artist::Artist::Video>) {
-                Q_EMIT openVideo(QString::fromStdString(item.video_id), QString::fromStdString(item.title));
+                Q_EMIT openVideo(QString::fromStdString(item.video_id));
             } else {
                 Q_UNREACHABLE();
             }

src/artistmodel.h

@@ -62,7 +62,7 @@ public:
 
     Q_SIGNAL void openAlbum(const QString &browseId);
     Q_SIGNAL void openSong(const QString &videoId);
-    Q_SIGNAL void openVideo(const QString &videoId, const QString &title);
+    Q_SIGNAL void openVideo(const QString &videoId);
 
 private:
     QString m_channelId;

src/asyncytmusic.h

@@ -37,7 +37,6 @@ public:
         if (!m_item) {
             m_item = std::make_unique<T>();
         }
-        Q_ASSERT(m_item);
         return m_item;
     }
 
@@ -108,14 +107,14 @@ private:
     Q_SIGNAL void startFetchWatchPlaylist(const std::optional<QString> &videoId, const std::optional<QString> &playlistId);
     Q_SLOT void internalFetchWatchPlaylist(const std::optional<QString> &videoId, const std::optional<QString> &playlistId);
 
-    // Python interpreter will be initialized from the thread calling the methods
+    // Python interpreter will be ininitalized from the thread calling the methods
     Lazy<YTMusic> m_ytm;
 };
 
 class YTMusicThread : private QThread {
 public:
     static YTMusicThread &instance();
-    ~YTMusicThread() override;
+    ~YTMusicThread();
 
     AsyncYTMusic *operator->();
     AsyncYTMusic &get();

src/contents/ui/AlbumPage.qml

@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
 
-import QtQuick 2.15
+import QtQuick 2.1
 import org.kde.kirigami 2.14 as Kirigami
 import QtQuick.Controls 2.14 as Controls
 import QtQuick.Layouts 1.3
@@ -29,8 +29,6 @@ Kirigami.ScrollablePage {
             title: albumModel.title
         }
 
-        reuseItems: true
-
         model: AlbumModel {
             id: albumModel
         }
@@ -58,12 +56,12 @@ Kirigami.ScrollablePage {
             actions: [
                 Kirigami.Action {
                     icon.name: "go-next"
-                    text: i18n("Play Next")
+                    text: i18n("Play next")
                     onTriggered: UserPlaylistModel.playNext(delegateItem.videoId, delegateItem.title, delegateItem.artists)
                 },
                 Kirigami.Action {
                     icon.name: "media-playlist-append"
-                    text: i18n("Add to Playlist")
+                    text: i18n("Add to playlist")
                     onTriggered: UserPlaylistModel.append(delegateItem.videoId, delegateItem.title, delegateItem.artists)
                 }
             ]

src/contents/ui/ArtistPage.qml

@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
 
-import QtQuick 2.15
+import QtQuick 2.1
 import org.kde.kirigami 2.14 as Kirigami
 import QtQuick.Controls 2.14 as Controls
 import QtQuick.Layouts 1.3
@@ -19,9 +19,6 @@ Kirigami.ScrollablePage {
             backgroundImage.source: artistModel.thumbnailUrl
             title: artistModel.title
         }
-
-        reuseItems: true
-
         model: ArtistModel {
             id: artistModel
 
@@ -35,8 +32,8 @@ Kirigami.ScrollablePage {
                 play(videoId)
             }
 
-            onOpenVideo: (videoId, title) => {
-                askPlayVideoAudio(videoId, title)
+            onOpenVideo: (videoId) => {
+                askPlayVideoAudio(videoId)
             }
         }
         section.property: "type"
@@ -90,13 +87,13 @@ Kirigami.ScrollablePage {
             actions: [
                 Kirigami.Action {
                     icon.name: "go-next"
-                    text: i18n("Play Next")
+                    text: i18n("Play next")
                     visible: type === ArtistModel.Song
                     onTriggered: UserPlaylistModel.playNext(delegateItem.videoId, delegateItem.title, delegateItem.artists)
                 },
                 Kirigami.Action {
                     icon.name: "media-playlist-append"
-                    text: i18n("Add to Playlist")
+                    text: i18n("Add to playlist")
                     visible: type === ArtistModel.Song
                     onTriggered: UserPlaylistModel.append(delegateItem.videoId, delegateItem.title, delegateItem.artists)
                 }

src/contents/ui/PlayerFooter.qml

@@ -29,8 +29,8 @@ ColumnLayout {
         visible: footerLayout.maximized
 
         Item {
-            Layout.fillWidth: info.thumbnail
-            Layout.fillHeight: info.thumbnail
+            Layout.fillWidth: true
+            Layout.fillHeight: true
             Image {
                 anchors.fill: parent
 
@@ -93,7 +93,7 @@ ColumnLayout {
 
                         actions: [
                             Kirigami.Action {
-                                text: i18n("Remove Track")
+                                text: i18n("Remove track")
                                 icon.name: "list-remove"
                                 onTriggered: UserPlaylistModel.remove(delegateItem.videoId)
                             }
@@ -110,12 +110,10 @@ ColumnLayout {
                             }
 
                             Controls.ToolButton {
-                                text: i18n("Clear")
                                 icon.name: "edit-clear-all"
                                 onClicked: UserPlaylistModel.clear()
                             }
                             Controls.ToolButton {
-                                text: i18n("Shuffle")
                                 icon.name: "media-playlist-shuffle"
                                 onClicked: UserPlaylistModel.shufflePlaylist()
                             }
@@ -196,8 +194,22 @@ ColumnLayout {
             RowLayout{
 
                 Controls.Label{
-                    visible: info.title
-                    text: PlayerUtils.formatTimestamp(audio.position)
+                    visible: audio.duration > 0
+                    text: {
+                        var hours = new Date(audio.position).getUTCHours()
+                        if(hours>0)
+                            hours = (("0"+hours).slice(-2)) + ":"
+                        else
+                            hours = ""
+
+                        var minutes = new Date(audio.position).getUTCMinutes()
+                        minutes = ("0"+minutes).slice(-2)
+
+                        var seconds = new Date(audio.position).getUTCSeconds()
+                        seconds = ("0"+seconds).slice(-2)
+
+                        return hours+minutes+":"+seconds;
+                    }
                 }
 
                 Controls.Slider {
@@ -220,8 +232,22 @@ ColumnLayout {
                 }
 
                 Controls.Label{
-                    visible: info.title
-                    text: PlayerUtils.formatTimestamp(audio.duration)
+                    visible: audio.duration > 0
+                    text: {
+                        var hours = new Date(audio.duration).getUTCHours()
+                        if(hours>0)
+                            hours = (("0"+hours).slice(-2)) + ":"
+                        else
+                            hours = ""
+
+                        var minutes = new Date(audio.duration).getUTCMinutes()
+                        minutes = ("0"+minutes).slice(-2)
+
+                        var seconds = new Date(audio.duration).getUTCSeconds()
+                        seconds = ("0"+seconds).slice(-2)
+
+                        return hours+minutes+":"+seconds;
+                    }
                 }
 
             }

src/contents/ui/PlaylistPage.qml

@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
 
-import QtQuick 2.15
+import QtQuick 2.0
 import QtQuick.Layouts 1.12
 import QtQuick.Controls 2.12 as Controls
 import org.kde.kirigami 2.12 as Kirigami
@@ -38,14 +38,11 @@ Kirigami.ScrollablePage {
         model: PlaylistModel {
             id: playlistModel
         }
-
-        reuseItems: true
-
         delegate: Kirigami.SwipeListItem {
             id: delegateItem
             required property string title
             required property string videoId
-            required property var artists
+            required property string artists
 
             RowLayout {
                 Layout.fillHeight: true
@@ -64,17 +61,15 @@ Kirigami.ScrollablePage {
             actions: [
                 Kirigami.Action {
                     icon.name: "go-next"
-                    text: i18n("Play Next")
+                    text: i18n("Play next")
                     onTriggered: UserPlaylistModel.playNext(delegateItem.videoId, delegateItem.title, delegateItem.artists)
                 },
                 Kirigami.Action {
                     icon.name: "media-playlist-append"
-                    text: i18n("Add to Playlist")
+                    text: i18n("Add to playlist")
                     onTriggered: UserPlaylistModel.append(delegateItem.videoId, delegateItem.title, delegateItem.artists)
                 }
             ]
-
-            onClicked: play(videoId)
         }
 
         Controls.BusyIndicator {

src/contents/ui/SearchPage.qml

@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
 
-import QtQuick 2.15
+import QtQuick 2.0
 import QtQuick.Layouts 1.3
 import QtQuick.Controls 2.14 as Controls
 import org.kde.kirigami 2.14 as Kirigami
@@ -10,13 +10,20 @@ import org.kde.kirigami 2.14 as Kirigami
 import org.kde.ytmusic 1.0
 
 Kirigami.ScrollablePage {
-    property alias searchQuery: searchModel.searchQuery
+    title: i18n("Youtube Music")
 
-    title: searchQuery
+    header: Controls.Control {
+        padding: Kirigami.Units.largeSpacing
+        contentItem: Kirigami.SearchField {
+            delaySearch: true
+            selectByMouse: true
+            onAccepted: {
+                searchModel.searchQuery = text
+            }
+        }
+    }
 
     ListView {
-        reuseItems: true
-
         model: SearchModel {
             id: searchModel
 
@@ -42,8 +49,8 @@ Kirigami.ScrollablePage {
                 play(videoId)
             }
 
-            onOpenVideo: (videoId, title) => {
-                askPlayVideoAudio(videoId, title)
+            onOpenVideo: (videoId) => {
+                askPlayVideoAudio(videoId)
             }
         }
         delegate: Kirigami.SwipeListItem {
@@ -53,7 +60,6 @@ Kirigami.ScrollablePage {
             required property int type
             required property string videoId
             required property var artists
-            required property string radioPlaylistId
 
             RowLayout {
                 Layout.fillHeight: true
@@ -91,15 +97,9 @@ Kirigami.ScrollablePage {
                 },
                 Kirigami.Action {
                     icon.name: "media-playlist-append"
-                    text: i18n("Add to Playlist")
+                    text: i18n("Add to playlist")
                     visible: delegateItem.type === SearchModel.Song
                     onTriggered: UserPlaylistModel.append(delegateItem.videoId, delegateItem.title, delegateItem.artists)
-                },
-                Kirigami.Action {
-                    icon.name: "radio"
-                    text: i18n("Radio")
-                    visible: delegateItem.type === SearchModel.Artist && delegateItem.radioPlaylistId
-                    onTriggered: playPlaylist(delegateItem.radioPlaylistId)
                 }
             ]
 
@@ -109,18 +109,5 @@ Kirigami.ScrollablePage {
             anchors.centerIn: parent
             visible: searchModel.loading
         }
-        Kirigami.PlaceholderMessage {
-            anchors.centerIn: parent
-            width: parent.width - (Kirigami.Units.largeSpacing * 4)
-
-            visible: parent.count === 0 && !searchModel.loading
-
-            text: i18n("Find music on YouTube Music")
-            helpfulAction: Kirigami.Action {
-                onTriggered: searchField.forceActiveFocus()
-                text: "Search"
-                icon.name: "search"
-            }
-        }
     }
 }

src/contents/ui/main.qml

@@ -3,8 +3,6 @@
 // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
 
 import QtQuick 2.1
-import QtQuick.Controls 2.12 as Controls
-import QtQuick.Layouts 1.3
 import org.kde.kirigami 2.14 as Kirigami
 
 import org.kde.ytmusic 1.0
@@ -12,41 +10,6 @@ import org.kde.ytmusic 1.0
 Kirigami.ApplicationWindow {
     id: root
 
-    property alias searchField: searchField
-
-    header: Controls.Control {
-        padding: Kirigami.Units.largeSpacing
-
-        background: Rectangle {
-             width: parent.width
-             height: parent.height
-             anchors.fill: parent
-             Kirigami.Theme.inherit: false
-             Kirigami.Theme.colorSet: Kirigami.Theme.Header
-             color:  Kirigami.Theme.backgroundColor
-         }
-        contentItem: RowLayout{
-            Item {
-                Layout.fillWidth: true
-            }
-            Kirigami.SearchField {
-                id: searchField
-                delaySearch: true
-                selectByMouse: true
-                Layout.fillWidth: true
-                Layout.maximumWidth: 400
-                onAccepted: {
-                    pageStack.clear()
-                    pageStack.push("qrc:/SearchPage.qml", {
-                               "searchQuery": text})
-                }
-            }
-            Item {
-                Layout.fillWidth: true
-            }
-        }
-    }
-
     title: i18n("AudioTube")
 
     controlsVisible: !footer.maximized
@@ -70,10 +33,10 @@ Kirigami.ApplicationWindow {
         UserPlaylistModel.playlistId = playlistId
     }
 
-    function askPlayVideoAudio(videoId, title) {
-        showPassiveNotification(i18n("Video playback is not supported yet. Do you want to play only the audio of \"%1\"?", title),
+    function askPlayVideoAudio(videoId) {
+        showPassiveNotification(i18n("Video playback is not supported yet."),
                             "long",
-                            i18n("Play only Audio"),
+                            i18n("Play only audio"),
                             function() {
                                 play(videoId)
                             })

src/example/CMakeLists.txt

@@ -1,6 +1,2 @@
-# SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-#
-# SPDX-License-Identifier: BSD-2-Clause
-
 add_executable(ytm_example main.cpp)
 target_link_libraries(ytm_example PRIVATE ytm)

src/example/main.cpp

@@ -8,7 +8,7 @@
 
 int main() {
     const auto ytm = YTMusic();
-    const auto results = ytm.search("Thomas Bangalter");
+    const auto results = ytm.search("arte concert");
 
     std::cout << "Found " << results.size() << " results." << std::endl;
 
@@ -42,7 +42,7 @@ int main() {
             } else if constexpr (std::is_same_v<T, search::Video>) {
                 std::cout << arg.title << std::endl;
             } else {
-                std::cout << "non exaustive visitor";
+                std::cout << "non excaustive visitor";
             }
         }, result);
     }

src/main.cpp

@@ -7,9 +7,6 @@
 #include <QtQml>
 #include <QUrl>
 #include <KLocalizedContext>
-#include <KLocalizedString>
-#include <KCrash>
-#include <KAboutData>
 
 #include "searchmodel.h"
 #include "albummodel.h"
@@ -18,7 +15,6 @@
 #include "userplaylistmodel.h"
 #include "errorhandler.h"
 #include "playlistmodel.h"
-#include "playerutils.h"
 
 constexpr auto URI = "org.kde.ytmusic";
 
@@ -30,11 +26,6 @@ Q_DECL_EXPORT int main(int argc, char *argv[])
     QCoreApplication::setOrganizationDomain(QStringLiteral("kde.org"));
     QCoreApplication::setApplicationName(QStringLiteral("audiotube"));
 
-    KLocalizedString::setApplicationDomain("audiotube");
-
-    KAboutData::setApplicationData(KAboutData(QStringLiteral("audiotube"), QStringLiteral("AudioTube")));
-    KCrash::initialize();
-
     QQmlApplicationEngine engine;
 
     qmlRegisterType<SearchModel>(URI, 1, 0, "SearchModel");
@@ -48,9 +39,6 @@ Q_DECL_EXPORT int main(int argc, char *argv[])
     qmlRegisterSingletonType<ErrorHandler>(URI, 1, 0, "ErrorHandler", [](QQmlEngine *, QJSEngine *) {
         return new ErrorHandler();
     });
-    qmlRegisterSingletonType<PlayerUtils>(URI, 1, 0, "PlayerUtils", [](QQmlEngine *, QJSEngine *) {
-        return new PlayerUtils();
-    });
 
     engine.rootContext()->setContextObject(new KLocalizedContext(&engine));
     engine.load(QUrl(QStringLiteral("qrc:///main.qml")));

src/multiiterableview.h

@@ -52,7 +52,7 @@ private:
         }
     }
 public:
-    explicit MultiIterableView(std::vector<Arguments> &&...lists)
+    explicit MultiIterableView(const std::vector<Arguments> &...lists)
         : m_vectors(std::make_tuple(lists...))
     {
     }

src/playerutils.cpp

@@ -1,15 +0,0 @@
-// SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-//
-// SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
-
-#include "playerutils.h"
-
-PlayerUtils::PlayerUtils(QObject *parent) : QObject(parent)
-{
-
-}
-
-QString PlayerUtils::formatTimestamp(quint64 stamp)
-{
-    return m_format.formatDuration(stamp, KFormat::FoldHours);
-}

src/playerutils.h

@@ -1,22 +0,0 @@
-// SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-//
-// SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
-
-#pragma once
-
-#include <QObject>
-
-#include <KFormat>
-
-class PlayerUtils : public QObject
-{
-    Q_OBJECT
-public:
-    explicit PlayerUtils(QObject *parent = nullptr);
-
-    Q_INVOKABLE QString formatTimestamp(quint64 stamp);
-
-private:
-    KFormat m_format;
-};
-

src/playlistmodel.cpp

@@ -49,7 +49,7 @@ QVariant PlaylistModel::data(const QModelIndex &index, int role) const
     case Title:
         return QString::fromStdString(m_playlist.tracks[index.row()].title);
     case Artists:
-        return QVariant::fromValue(m_playlist.tracks[index.row()].artists);
+        return PlaylistUtils::artistsToString(m_playlist.tracks[index.row()].artists);
     case VideoId:
         if (m_playlist.tracks[index.row()].video_id) {
             return QString::fromStdString(*m_playlist.tracks[index.row()].video_id);

src/playlistutils.cpp

@@ -10,9 +10,7 @@
 
 #include <ytmusic.h>
 
-namespace PlaylistUtils {
-
-QString artistsToString(const std::vector<meta::Artist> &artists)
+QString PlaylistUtils::artistsToString(const std::vector<meta::Artist> &artists)
 {
     if (!artists.empty()) {
         return std::accumulate(artists.begin() + 1, artists.end(),
@@ -24,5 +22,3 @@ QString artistsToString(const std::vector<meta::Artist> &artists)
 
     return {};
 }
-
-}

src/playlistutils.h

@@ -11,6 +11,10 @@ namespace meta {
 struct Artist;
 }
 
-namespace PlaylistUtils {
-    QString artistsToString(const std::vector<meta::Artist> &artists);
+class PlaylistUtils
+{
+public:
+    PlaylistUtils() = delete;
+
+    static QString artistsToString(const std::vector<meta::Artist> &artists);
 };

src/resources.qrc

@@ -1,9 +1,3 @@
-<!--
-SPDX-FileCopyrightText: 2021 Jonah Brüchert <[email protected]>
-
-SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
--->
-
 <RCC>
     <qresource prefix="/">
         <file alias="main.qml">contents/ui/main.qml</file>

src/searchmodel.cpp

@@ -105,18 +105,6 @@ QVariant SearchModel::data(const QModelIndex &index, int role) const
                 Q_UNREACHABLE();
             }
         }, m_searchResults.at(index.row())));
-    case RadioPlaylistId:
-        return std::visit([&](auto &&arg) {
-            using T = std::decay_t<decltype(arg)>;
-
-            if constexpr (std::is_same_v<T, search::Artist>) {
-                if (arg.radio_id) {
-                    return QString::fromStdString(*arg.radio_id);
-                }
-            }
-
-            return QString();
-        }, m_searchResults.at(index.row()));
     }
 
     Q_UNREACHABLE();
@@ -130,8 +118,7 @@ QHash<int, QByteArray> SearchModel::roleNames() const
         {Title, "title"},
         {Type, "type"},
         {VideoId, "videoId"},
-        {Artists, "artists"},
-        {RadioPlaylistId, "radioPlaylistId"},
+        {Artists, "artists"}
     };
 }
 
@@ -170,7 +157,7 @@ void SearchModel::triggerItem(int row)
         } else if constexpr (std::is_same_v<T, search::Song>) {
             Q_EMIT openSong(QString::fromStdString(arg.video_id));
         } else if constexpr (std::is_same_v<T, search::Video>) {
-            Q_EMIT openVideo(QString::fromStdString(arg.video_id), QString::fromStdString(arg.title));
+            Q_EMIT openVideo(QString::fromStdString(arg.video_id));
         } else {
             Q_UNREACHABLE();
         }

src/searchmodel.h

@@ -30,8 +30,7 @@ public:
         Title = Qt::UserRole + 1,
         Type,
         VideoId,
-        Artists,
-        RadioPlaylistId
+        Artists
     };
 
     explicit SearchModel(QObject *parent = nullptr);
@@ -54,7 +53,7 @@ public:
     Q_SIGNAL void openArtist(const QString &browseId);
     Q_SIGNAL void openPlaylist(const QString &browseId);
     Q_SIGNAL void openSong(const QString &videoId);
-    Q_SIGNAL void openVideo(const QString &videoId, const QString &title);
+    Q_SIGNAL void openVideo(const QString &videoId);
 
 private:
     QString m_searchQuery;

src/videoinfoextractor.cpp

@@ -33,6 +33,7 @@ VideoInfoExtractor::VideoInfoExtractor(QObject *parent)
     });
 }
 
+
 QUrl VideoInfoExtractor::audioUrl() const
 {
     if (m_videoInfo.formats.empty()) {

src/videoinfoextractor.h

@@ -21,7 +21,7 @@ class VideoInfoExtractor : public QObject
     Q_PROPERTY(bool loading READ loading WRITE setLoading NOTIFY loadingChanged)
 
 public:
-    explicit VideoInfoExtractor(QObject *parent = nullptr);
+    VideoInfoExtractor(QObject *parent = nullptr);
 
     QUrl audioUrl() const;
     Q_SIGNAL void audioUrlChanged();

src/ytmusic.cpp

@@ -15,46 +15,11 @@ using namespace py::literals;
 
 #define UNEXPORT __attribute__ ((visibility("hidden")))
 
-constexpr auto TESTED_YTMUSICAPI_VERSION = "0.17.3";
+constexpr auto TESTED_YTMUSICAPI_VERSION = "0.16.0";
 
 struct UNEXPORT YTMusicPrivate {
     py::scoped_interpreter guard {};
-
-    std::optional<std::string> auth;
-    std::optional<std::string> user;
-    std::optional<bool> requests_session;
-    std::optional<std::map<std::string, std::string> > proxies;
-    std::string language;
-
-    py::object get_ytmusic() {
-        if (ytmusic.is_none()) {
-            const auto module = py::module::import("ytmusicapi");
-            ytmusic = module.attr("YTMusic")(auth, user, requests_session, proxies, language);
-
-            // Some of the called python code randomly fails if the encoding is not utf8
-            setenv("LC_ALL", "en_US.utf8", true);
-
-            const auto version = module.attr("_version").attr("__version__").cast<std::string>();
-            if (version != TESTED_YTMUSICAPI_VERSION) {
-                std::cerr << "Running with untested version of ytmusicapi." << std::endl;
-                std::cerr << "The currently tested and supported version is " << TESTED_YTMUSICAPI_VERSION << std::endl;
-            }
-        }
-
-        return ytmusic;
-    }
-
-    py::object get_ytdl() {
-        // lazy initialization
-        if (ytdl.is_none()) {
-             ytdl = py::module::import("youtube_dl").attr("YoutubeDL")(py::dict());
-        }
-
-        return ytdl;
-    }
-
-private:
-    py::object ytmusic = py::none();
+    py::object ytmusic;
     py::object ytdl = py::none();
 };
 
@@ -107,10 +72,6 @@ watch::Playlist::Track extract_watch_track(py::handle track);
 
 template <typename T>
 inline auto extract_py_list(py::handle obj) {
-    if (obj.is_none()) {
-        return std::vector<T>();
-    }
-
     const auto list = obj.cast<py::list>();
     std::vector<T> output;
 
@@ -312,11 +273,16 @@ YTMusic::YTMusic(
         const std::string &language)
     : d(std::make_unique<YTMusicPrivate>())
 {
-    d->auth = auth;
-    d->user = user;
-    d->requests_session = requests_session;
-    d->proxies = proxies;
-    d->language = language;
+    const auto module = py::module::import("ytmusicapi");
+    d->ytmusic = module.attr("YTMusic")(auth, user, requests_session, proxies, language);
+
+    setenv("LC_ALL", "en_US.utf8", true);
+
+    const auto version = module.attr("_version").attr("__version__").cast<std::string>();
+    if (version != TESTED_YTMUSICAPI_VERSION) {
+        std::cerr << "Running with untested version of ytmusicapi." << std::endl;
+        std::cerr << "The currently tested and supported version is " << TESTED_YTMUSICAPI_VERSION << std::endl;
+    }
 }
 
 YTMusic::~YTMusic() = default;
@@ -327,7 +293,7 @@ std::vector<search::SearchResultItem> YTMusic::search(
         const int limit,
         const bool ignore_spelling) const
 {
-    const auto results = d->get_ytmusic().attr("search")(query, filter, limit, ignore_spelling).cast<py::list>();
+    const auto results = d->ytmusic.attr("search")(query, filter, limit, ignore_spelling).cast<py::list>();
 
     std::vector<search::SearchResultItem> output;
     for (const auto &result : results) {
@@ -341,7 +307,7 @@ std::vector<search::SearchResultItem> YTMusic::search(
 
 artist::Artist YTMusic::get_artist(const std::string &channel_id) const
 {
-    const auto artist = d->get_ytmusic().attr("get_artist")(channel_id);
+    const auto artist = d->ytmusic.attr("get_artist")(channel_id);
     return artist::Artist {
         artist["description"].cast<std::optional<std::string>>(),
         artist["views"].cast<std::optional<std::string>>(),
@@ -359,7 +325,7 @@ artist::Artist YTMusic::get_artist(const std::string &channel_id) const
 
 album::Album YTMusic::get_album(const std::string &browseId) const
 {
-    const auto album = d->get_ytmusic().attr("get_album")(browseId);
+    const auto album = d->ytmusic.attr("get_album")(browseId);
 
     return {
         album["title"].cast<std::string>(),
@@ -382,7 +348,7 @@ album::Album YTMusic::get_album(const std::string &browseId) const
 
 song::Song YTMusic::get_song(const std::string &video_id) const
 {
-    const auto song = d->get_ytmusic().attr("get_song")(video_id);
+    const auto song = d->ytmusic.attr("get_song")(video_id);
 
     return {
         song["videoId"].cast<std::string>(),
@@ -414,7 +380,7 @@ song::Song YTMusic::get_song(const std::string &video_id) const
 
 playlist::Playlist YTMusic::get_playlist(const std::string &playlist_id, int limit) const
 {
-    const auto playlist = d->get_ytmusic().attr("get_playlist")(playlist_id, limit);
+    const auto playlist = d->ytmusic.attr("get_playlist")(playlist_id, limit);
 
     return {
         playlist["id"].cast<std::string>(),
@@ -431,7 +397,7 @@ playlist::Playlist YTMusic::get_playlist(const std::string &playlist_id, int lim
 
 std::vector<artist::Artist::Album> YTMusic::get_artist_albums(const std::string &channel_id, const std::string &params) const
 {
-    const auto py_albums = d->get_ytmusic().attr("get_artist_albums")(channel_id, params);
+    const auto py_albums = d->ytmusic.attr("get_artist_albums")(channel_id, params);
     std::vector<artist::Artist::Album> albums;
 
     std::transform(py_albums.begin(), py_albums.end(), std::back_inserter(albums), [](py::handle album) {
@@ -451,7 +417,15 @@ video_info::VideoInfo YTMusic::extract_video_info(const std::string &video_id) c
 {
     using namespace pybind11::literals;
 
-    const auto info = d->get_ytdl().attr("extract_info")(video_id, "download"_a=py::bool_(false));
+    // lazy initialization
+    if (d->ytdl.is_none()) {
+        const auto module = py::module::import("youtube_dl");
+        py::dict options;
+        d->ytdl = module.attr("YoutubeDL")(options);
+    }
+
+    const auto info = d->ytdl.attr("extract_info")(video_id, "download"_a=py::bool_(false));
+    //py::print(py::module::import("json").attr("dumps")(info, "indent"_a=4));
 
     return {
         info["id"].cast<std::string>(),
@@ -466,7 +440,7 @@ watch::Playlist YTMusic::get_watch_playlist(const std::optional<std::string> &vi
                                             int limit,
                                             const std::optional<std::string> &params) const
 {
-    const auto playlist = d->get_ytmusic().attr("get_watch_playlist")("videoId"_a = videoId,
+    const auto playlist = d->ytmusic.attr("get_watch_playlist")("videoId"_a = videoId,
                                                                 "playlistId"_a = playlistId,
                                                                 "limit"_a = py::int_(limit),
                                                                 "params"_a = params);