Commit Graph

2332 Commits

Author SHA1 Message Date
Alex Balgavy
f76dd085b2 Fix crash when background-fetching lyrics for streams (#561)
When `fetch_lyrics_for_current_song_in_background` is set to `yes`, and
an HTTP(S) stream is loaded with a long URL, ncmpcpp crashes due to the
length of the filename generated to store lyrics. This commit makes the
background lyrics fetcher ignore such streams, preventing the crash.
Addresses issue #380.
2024-07-24 17:57:38 +02:00
Denys Tynok
e87c104dd6 fix: update obsolete macros in autoconf (#582)
* fix: update obsolete macros in autoconf

* fix: update obsolete macro 'AC_PROG_LIBTOOL' in autoconf
2024-07-24 17:56:14 +02:00
Andrzej Rybczak
afb150138d Change visibility of orig_termios 2024-07-24 17:55:35 +02:00
Drew Marino
51ebe9e52d Fixed bug related to readline.h (#592)
Terminals that don't restore the terminal state when a program exits display stdin incorrectly after quitting. This is not a bug in readline.h as its examples use termios in the same way.
2024-07-24 17:54:12 +02:00
Andrzej Rybczak
9c396d7ef0 Fix removal of XiphComments 2024-07-24 17:25:03 +02:00
Andrzej Rybczak
81e5cf58b4 extras: fix compilation with taglib 2.0 2024-05-30 14:58:44 +02:00
Andrzej Rybczak
dc46f7a49b Fix compilation with taglib 2.0 2024-02-07 14:29:09 +01:00
Larson Carter
9f44edf0b1 Merge pull request #560 from zaidhaan/fix-mpd-block
Fix unresponsive stall when server error occurs
2022-12-31 12:52:39 -06:00
Zaidhaan Hussain
d96e3e514d Fix MPD blocking when server error occurs by handling directly without blocking further execution by throwing 2022-11-21 23:05:31 +08:00
Robert Kaspar
417d7172e5 Read Performer from TPE4, not TPE3 (#497) 2022-02-14 00:48:11 +01:00
leg7
727ca95ca5 Increase the framerate limit for the visualizer. (#490)
* Update settings.cpp

* Update settings.cpp
2022-02-14 00:47:32 +01:00
squigz
26ee24a938 Add italic text support (#527) 2022-02-14 00:42:13 +01:00
Jeffrey Paul
02754534fd update homepage link to https (#529)
modern browsers don't support http
2022-02-08 15:50:38 +01:00
Andrzej Rybczak
40e4f98ee8 Support sockets without a socket inode 2021-08-25 02:37:54 +02:00
Andrzej Rybczak
b023c737e3 Remove options deprecated in 0.9 2021-07-29 13:19:54 +02:00
Andrzej Rybczak
70ca94f739 Curl: stop setting user agent to ncmpcpp 2021-07-27 00:47:46 +02:00
Andrzej Rybczak
df1c4d7d7d Fix genius lyrics fetcher 2021-07-26 23:44:36 +02:00
Andrzej Rybczak
35f9262a6e Fix compilation 2021-04-25 23:57:56 +02:00
Jinwoo Park
f47cf7f37c Configurable Column Widths (#360)
* add configurable column widths

* reorder to match config file

* fix possibly misleading documentation

* fix crash when integer out of bounds

* parse config string during initial processing

* use std::bind with length of list

* fix division by zero error

* use list_of

* change escaped_list_separator variable names
2021-04-25 19:42:56 +02:00
Jonathan Neidel
22fd919ce4 Fix separator between albums with the same name, to check for album artist instead of artist (#472) 2021-04-25 19:41:07 +02:00
John Ferguson
71970fa73c Fix overflow errors and allow small terminal sizes (#473)
* In #259 users request the ability to have ncmpcpp remain open when the
  terminal has a small size. Previously ncmpcpp would exit when there
  were less than 30 columns or 5 rows.
* After removing this constraint, ncmpcpp would freeze when terminal
  sizes went below those thresholds.
* Upon debugging, it became clear that ncmpcpp wasn't frozen, it was
  stuck in a very long for loop because it thought the display was
  unreasonably large (resulting from integer overflow).
* Preventing that overflow allows ncmpcpp to handle small sizes
  gracefully. No other changes to the rendering code were necessary.

Fixes #259
2021-04-25 19:39:52 +02:00
John Ferguson
295663fc1c update .gitignore to ignore more build artifacts (#475) 2021-04-25 19:37:27 +02:00
tibequadorian
231c0970c9 Fix vorbis comment and add support for Opus (#463)
* fix multiple values for vorbis comment

* add vorbis comment support for opus
2021-04-08 22:56:14 +02:00
Andrzej Rybczak
689771c2f7 Separate chunks of lyrics with a double newline 2021-01-26 19:06:55 +01:00
V
d9c55771bb configuration: add mpd_password option (#407)
Although this can already be set via mpd_host, having a separate option
is cleaner, and doesn't require setting the host when ncmpcpp already
detects it correctly.
2021-01-24 19:15:59 +01:00
Andrzej Rybczak
5dfbd3f23a Bump version to 0.10_dev 2021-01-24 17:11:27 +01:00
Andrzej Rybczak
2d96361862 Fix release year 2021-01-24 17:06:17 +01:00
Andrzej Rybczak
38a3084487 Bump version to 0.9.2 2021-01-24 16:50:24 +01:00
Andrzej Rybczak
541b8d7aab Gracefully handle failures when asking for a password
Fix for #446 and #447.
2021-01-24 16:39:55 +01:00
Andrzej Rybczak
07cc7aa4f3 SampleBuffer: rename move to get 2021-01-11 20:56:43 +01:00
Andrzej Rybczak
b902a2a6bf Don't block when executing external commands 2021-01-03 23:55:06 +01:00
Andrzej Rybczak
dd0eac69f8 Revert suppression of output of all external commands 2021-01-03 17:53:39 +01:00
Andrzej Rybczak
94198a79fe Release 0.9.1 2020-12-23 16:10:45 +01:00
Andrzej Rybczak
75f1ffaf1a Revert change from previous commit 2020-12-23 16:10:45 +01:00
Andrzej Rybczak
901542ee8e Tiny visualizer improvements 2020-12-23 15:32:58 +01:00
Andrzej Rybczak
11e3ba562a Fix fetching information about artists from last.fm 2020-12-23 01:11:14 +01:00
Andrzej Rybczak
7e4f3b1917 Bind Play to Backspace by default 2020-12-23 00:17:50 +01:00
Andrzej Rybczak
e0fe49e3e3 Enable full sorting of items in the local browser if it's not 2020-12-22 23:50:29 +01:00
Andrzej Rybczak
03f046802a Fix toggle of a sorting mode in the browser 2020-12-22 23:50:15 +01:00
Andrzej Rybczak
628f7ee1c4 Enable Link Time Optimization by default 2020-12-22 20:26:11 +01:00
Andrzej Rybczak
d402df8eeb Reduce CPU usage of the frequency spectrum visualizer 2020-12-22 19:35:51 +01:00
Andrzej Rybczak
def7ea42f6 Consider mouse support when pausing and unpausing curses interface 2020-12-21 19:49:02 +01:00
Andrzej Rybczak
f3fe45f3ff Suppress output of all external commands 2020-12-21 19:43:40 +01:00
Andrzej Rybczak
89ebfbf73d Draw a separator between albums with the same name, but a different artist 2020-12-21 18:58:48 +01:00
Andrzej Rybczak
88025e2e93 Better fix for showing visualiser immediately after startup 2020-12-21 16:55:19 +01:00
Andrzej Rybczak
679cc7a2cb Show the Visualizer immediately if it's the initial screen 2020-12-21 13:46:34 +01:00
Andrzej Rybczak
40c40d8c7f Fix crash on startup with Browser as the initial screen 2020-12-21 11:14:26 +01:00
Andrzej Rybczak
3d5d1f4d54 Fix crash on startup with Visualizer as the initial screen 2020-12-21 10:55:46 +01:00
Andrzej Rybczak
37af7d8052 Fix intermittent failures of the Genius fetcher 2020-12-21 01:04:57 +01:00
Andrzej Rybczak
ba2a4533ab Remove separators between parts of lyrics 2020-12-21 01:04:57 +01:00