Fix: CORS preflight 401'd by AuthMiddleware before CORSMiddleware (#3262)

AuthMiddleware is the outermost middleware, so a credential-less CORS preflight
(OPTIONS + Access-Control-Request-Method) was rejected with 401 before
CORSMiddleware could answer it. That blocks every cross-origin browser/WebView
client: the preflight fails, so the real request is never sent.

Let a genuine preflight through at the top of AuthMiddleware.dispatch via a pure,
unit-tested predicate (core.middleware.is_cors_preflight). Precise -- only
OPTIONS carrying Access-Control-Request-Method; a credentialed request is never
matched -- and no data access.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Marius
2026-06-07 14:23:23 +01:00
committed by GitHub
parent a3784da172
commit 04d6a5ccaa
3 changed files with 49 additions and 1 deletions
+30
View File
@@ -0,0 +1,30 @@
"""Regression test for the CORS-preflight auth bypass.
AuthMiddleware is the outermost middleware, so it used to 401 the credential-less
OPTIONS preflight before CORSMiddleware could answer it -- which blocks every
cross-origin browser/WebView client before the real request is ever sent. The
fix lets a genuine preflight through; `is_cors_preflight` is the pure predicate
it uses. Guard it so the bypass can't silently regress.
"""
import os
import sys
sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
from core.middleware import is_cors_preflight
def test_genuine_preflight_is_detected():
assert is_cors_preflight("OPTIONS", {"access-control-request-method": "POST"}) is True
def test_bare_options_is_not_a_preflight():
# OPTIONS without Access-Control-Request-Method must NOT bypass auth.
assert is_cors_preflight("OPTIONS", {}) is False
def test_real_methods_are_never_preflight():
headers = {"access-control-request-method": "POST"}
for method in ("GET", "POST", "PUT", "DELETE", "PATCH"):
assert is_cors_preflight(method, headers) is False