Merge verified Odysseus fixes

.env.example

@@ -189,7 +189,6 @@ SEARXNG_INSTANCE=http://localhost:8080
 # ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES=26214400       # email compose attachment (25 MB)
 # ODYSSEUS_STT_MAX_AUDIO_BYTES=26214400                  # speech-to-text audio (25 MB)
 # ODYSSEUS_ICS_MAX_BYTES=10485760                        # calendar .ics import (10 MB)
-# ODYSSEUS_TTS_CACHE_MAX_BYTES=524288000                 # TTS cache (500 MB)
 
 # ============================================================
 # Host Docker access (explicit opt-in)

.github/scripts/check-issue-description.js

@@ -153,16 +153,6 @@ module.exports = async ({ github, context, core }) => {
     }
   }
 
-  const LABEL_BAD  = 'needs more info';
-  const LABEL_GOOD = 'ready for review';
-
-  // Closed issues are no longer awaiting review.
-  // This also prevents later edits to closed issues from restoring the label.
-  if (issue.state === 'closed') {
-    await dropLabel(LABEL_GOOD);
-    return;
-  }
-
   // ── Find existing bot comment to update in-place ──────────────────────────
   const MARKER = '<!-- issue-description-check -->';
   const { data: comments } = await github.rest.issues.listComments({
@@ -170,6 +160,9 @@ module.exports = async ({ github, context, core }) => {
   });
   const existing = comments.find(c => c.user.type === 'Bot' && c.body.includes(MARKER));
 
+  const LABEL_BAD  = 'needs more info';
+  const LABEL_GOOD = 'ready for review';
+
   if (failures.length === 0) {
     if (existing) {
       await github.rest.issues.deleteComment({ owner, repo, comment_id: existing.id });

.github/workflows/issue-description-check.yml

@@ -2,7 +2,7 @@ name: ci / issue description check
 
 on:
   issues:
-    types: [opened, edited, reopened, closed]
+    types: [opened, edited, reopened]
 
 permissions:
   issues: write

app.py

@@ -692,7 +692,7 @@ from routes.history.history_routes import setup_history_routes
 app.include_router(setup_history_routes(session_manager, upload_handler=upload_handler))
 
 # Search
-from routes.search.search_routes import setup_search_routes
+from routes.search_routes import setup_search_routes
 app.include_router(setup_search_routes(config))
 
 # Presets

docker-compose.gpu-amd.yml

@@ -67,7 +67,6 @@ services:
       - ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES=${ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES:-26214400}
       - ODYSSEUS_STT_MAX_AUDIO_BYTES=${ODYSSEUS_STT_MAX_AUDIO_BYTES:-26214400}
       - ODYSSEUS_ICS_MAX_BYTES=${ODYSSEUS_ICS_MAX_BYTES:-10485760}
-      - ODYSSEUS_TTS_CACHE_MAX_BYTES=${ODYSSEUS_TTS_CACHE_MAX_BYTES}
       - DATA_BRAVE_API_KEY=${DATA_BRAVE_API_KEY:-}
       - GOOGLE_API_KEY=${GOOGLE_API_KEY:-}
       - GOOGLE_PSE_CX=${GOOGLE_PSE_CX:-}

docker-compose.gpu-nvidia.yml

@@ -66,7 +66,6 @@ services:
       - ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES=${ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES:-26214400}
       - ODYSSEUS_STT_MAX_AUDIO_BYTES=${ODYSSEUS_STT_MAX_AUDIO_BYTES:-26214400}
       - ODYSSEUS_ICS_MAX_BYTES=${ODYSSEUS_ICS_MAX_BYTES:-10485760}
-      - ODYSSEUS_TTS_CACHE_MAX_BYTES=${ODYSSEUS_TTS_CACHE_MAX_BYTES}
       - DATA_BRAVE_API_KEY=${DATA_BRAVE_API_KEY:-}
       - GOOGLE_API_KEY=${GOOGLE_API_KEY:-}
       - GOOGLE_PSE_CX=${GOOGLE_PSE_CX:-}

docker-compose.yml

@@ -55,7 +55,6 @@ services:
       - ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES=${ODYSSEUS_EMAIL_COMPOSE_UPLOAD_MAX_BYTES:-26214400}
       - ODYSSEUS_STT_MAX_AUDIO_BYTES=${ODYSSEUS_STT_MAX_AUDIO_BYTES:-26214400}
       - ODYSSEUS_ICS_MAX_BYTES=${ODYSSEUS_ICS_MAX_BYTES:-10485760}
-      - ODYSSEUS_TTS_CACHE_MAX_BYTES=${ODYSSEUS_TTS_CACHE_MAX_BYTES}
       - DATA_BRAVE_API_KEY=${DATA_BRAVE_API_KEY:-}
       - GOOGLE_API_KEY=${GOOGLE_API_KEY:-}
       - GOOGLE_PSE_CX=${GOOGLE_PSE_CX:-}

requirements-optional.txt

@@ -33,4 +33,4 @@ PyMuPDF
 # magika (onnxruntime), already a core dep via fastembed. We avoid the
 # [all]/Azure/audio extras (cloud + heavy). Pinned to a release >30 days old per
 # the dependency-age discussion in issue #485.
-markitdown[docx,pptx,xlsx,xls]==0.1.7
+markitdown[docx,pptx,xlsx,xls]==0.1.6

requirements.txt

@@ -3,9 +3,9 @@ uvicorn
 python-multipart
 python-dotenv
 httpx
-httpcore>=1.0.9,<2.0
+httpcore>=1.0,<2.0
 pydantic>=2.13.4
-pydantic-settings>=2.14.2
+pydantic-settings>=2.14.1
 SQLAlchemy
 pypdf
 beautifulsoup4
@@ -38,10 +38,7 @@ python-dateutil
 caldav
 cryptography
 bcrypt
-# Built-in servers use the v1 low-level Server decorator API. MCP SDK v2 is a
-# breaking rewrite, so keep fresh installs on the maintained v1 line until the
-# servers are migrated together.
-mcp<3
+mcp
 pyotp
 qrcode[pil]
 croniter

routes/search/__init__.py

@@ -1,5 +0,0 @@
-"""Search route domain package (slice 2j, #4082/#4071).
-
-Contains search_routes.py, migrated from the flat routes/ directory.
-Backward-compat shim at routes/search_routes.py re-exports from here.
-"""

routes/search/search_routes.py

@@ -1,111 +0,0 @@
-"""Search routes — /api/search/config GET, /api/search POST."""
-
-import logging
-from typing import Dict, Any
-
-from fastapi import APIRouter, Request
-
-import time
-
-from services.search import get_search_config, comprehensive_web_search, PROVIDER_INFO
-from services.search.core import _call_provider
-from services.search.providers import _get_provider_key, _get_search_instance
-
-logger = logging.getLogger(__name__)
-
-
-async def _request_values(request: Request) -> Dict[str, Any]:
-    """Accept JSON, form data, or query params for search endpoints.
-
-    The browser UI posts FormData, while the agent's generic app_api tool
-    posts JSON. FastAPI Form(...) rejects JSON with a 422 before our handler
-    runs, which made the model think SearXNG was broken.
-    """
-    values: Dict[str, Any] = dict(request.query_params)
-    content_type = (request.headers.get("content-type") or "").lower()
-    try:
-        if "application/json" in content_type:
-            body = await request.json()
-            if isinstance(body, dict):
-                values.update(body)
-        else:
-            form = await request.form()
-            values.update(dict(form))
-    except Exception:
-        pass
-    return values
-
-
-def setup_search_routes(config) -> APIRouter:
-    router = APIRouter(tags=["search"])
-
-    @router.get("/api/search/config")
-    async def get_search_settings() -> Dict[str, Any]:
-        return get_search_config()
-
-    @router.post("/api/search")
-    async def do_web_search(request: Request) -> Dict[str, Any]:
-        """Standalone web search — returns context string + source list.
-
-        Used by Compare mode to pre-search once and share results across panes.
-        """
-        values = await _request_values(request)
-        query = str(values.get("query") or values.get("q") or "").strip()
-        if not query:
-            return {"context": "", "sources": [], "error": "query is required"}
-        time_filter = values.get("time_filter") or values.get("freshness")
-        if time_filter is not None:
-            time_filter = str(time_filter).strip() or None
-        try:
-            context, sources = comprehensive_web_search(
-                query, return_sources=True, time_filter=time_filter,
-            )
-            return {"context": context, "sources": sources}
-        except Exception as e:
-            logger.error(f"Standalone web search failed: {e}")
-            return {"context": "", "sources": [], "error": str(e)}
-
-    @router.get("/api/search/providers")
-    async def list_search_providers():
-        """Return available search providers with config status."""
-        providers = []
-        for pid, (label, needs_key, needs_url) in PROVIDER_INFO.items():
-            if pid == "disabled":
-                continue
-            available = True
-            if needs_key and not _get_provider_key(pid):
-                available = False
-            if needs_url and pid == "searxng" and not _get_search_instance():
-                available = False
-            providers.append({
-                "id": pid,
-                "label": label,
-                "available": available,
-            })
-        return providers
-
-    @router.post("/api/search/query")
-    async def search_with_provider(request: Request) -> Dict[str, Any]:
-        """Search using a specific provider. Used by compare search mode."""
-        values = await _request_values(request)
-        query = str(values.get("query") or values.get("q") or "").strip()
-        provider = str(values.get("provider") or "").strip()
-        try:
-            count = int(values.get("count") or values.get("limit") or 10)
-        except Exception:
-            count = 10
-        if not query:
-            return {"results": [], "provider": provider, "error": "query is required"}
-        if provider not in PROVIDER_INFO or provider == "disabled":
-            return {"results": [], "provider": provider, "error": "Unknown provider"}
-        t0 = time.time()
-        try:
-            results = _call_provider(provider, query, min(count, 20))
-            elapsed = round(time.time() - t0, 2)
-            return {"results": results, "provider": provider, "time": elapsed}
-        except Exception as e:
-            elapsed = round(time.time() - t0, 2)
-            logger.error(f"Search provider {provider} failed: {e}")
-            return {"results": [], "provider": provider, "time": elapsed, "error": str(e)}
-
-    return router

routes/search_routes.py

@@ -1,13 +1,111 @@
-"""Backward-compat shim — canonical location is routes/search/search_routes.py.
+"""Search routes — /api/search/config GET, /api/search POST."""
 
-This module is replaced in ``sys.modules`` by the canonical module object so
-that ``import routes.search_routes`` and ``from routes.search_routes import X``
-keep resolving to the canonical module. Keeps existing import paths working
-after slice 2j (#4082/#4071).
-"""
+import logging
+from typing import Dict, Any
 
-import sys as _sys
+from fastapi import APIRouter, Request
 
-from routes.search import search_routes as _canonical  # noqa: F401
+import time
 
-_sys.modules[__name__] = _canonical
+from services.search import get_search_config, comprehensive_web_search, PROVIDER_INFO
+from services.search.core import _call_provider
+from services.search.providers import _get_provider_key, _get_search_instance
+
+logger = logging.getLogger(__name__)
+
+
+async def _request_values(request: Request) -> Dict[str, Any]:
+    """Accept JSON, form data, or query params for search endpoints.
+
+    The browser UI posts FormData, while the agent's generic app_api tool
+    posts JSON. FastAPI Form(...) rejects JSON with a 422 before our handler
+    runs, which made the model think SearXNG was broken.
+    """
+    values: Dict[str, Any] = dict(request.query_params)
+    content_type = (request.headers.get("content-type") or "").lower()
+    try:
+        if "application/json" in content_type:
+            body = await request.json()
+            if isinstance(body, dict):
+                values.update(body)
+        else:
+            form = await request.form()
+            values.update(dict(form))
+    except Exception:
+        pass
+    return values
+
+
+def setup_search_routes(config) -> APIRouter:
+    router = APIRouter(tags=["search"])
+
+    @router.get("/api/search/config")
+    async def get_search_settings() -> Dict[str, Any]:
+        return get_search_config()
+
+    @router.post("/api/search")
+    async def do_web_search(request: Request) -> Dict[str, Any]:
+        """Standalone web search — returns context string + source list.
+
+        Used by Compare mode to pre-search once and share results across panes.
+        """
+        values = await _request_values(request)
+        query = str(values.get("query") or values.get("q") or "").strip()
+        if not query:
+            return {"context": "", "sources": [], "error": "query is required"}
+        time_filter = values.get("time_filter") or values.get("freshness")
+        if time_filter is not None:
+            time_filter = str(time_filter).strip() or None
+        try:
+            context, sources = comprehensive_web_search(
+                query, return_sources=True, time_filter=time_filter,
+            )
+            return {"context": context, "sources": sources}
+        except Exception as e:
+            logger.error(f"Standalone web search failed: {e}")
+            return {"context": "", "sources": [], "error": str(e)}
+
+    @router.get("/api/search/providers")
+    async def list_search_providers():
+        """Return available search providers with config status."""
+        providers = []
+        for pid, (label, needs_key, needs_url) in PROVIDER_INFO.items():
+            if pid == "disabled":
+                continue
+            available = True
+            if needs_key and not _get_provider_key(pid):
+                available = False
+            if needs_url and pid == "searxng" and not _get_search_instance():
+                available = False
+            providers.append({
+                "id": pid,
+                "label": label,
+                "available": available,
+            })
+        return providers
+
+    @router.post("/api/search/query")
+    async def search_with_provider(request: Request) -> Dict[str, Any]:
+        """Search using a specific provider. Used by compare search mode."""
+        values = await _request_values(request)
+        query = str(values.get("query") or values.get("q") or "").strip()
+        provider = str(values.get("provider") or "").strip()
+        try:
+            count = int(values.get("count") or values.get("limit") or 10)
+        except Exception:
+            count = 10
+        if not query:
+            return {"results": [], "provider": provider, "error": "query is required"}
+        if provider not in PROVIDER_INFO or provider == "disabled":
+            return {"results": [], "provider": provider, "error": "Unknown provider"}
+        t0 = time.time()
+        try:
+            results = _call_provider(provider, query, min(count, 20))
+            elapsed = round(time.time() - t0, 2)
+            return {"results": results, "provider": provider, "time": elapsed}
+        except Exception as e:
+            elapsed = round(time.time() - t0, 2)
+            logger.error(f"Search provider {provider} failed: {e}")
+            return {"results": [], "provider": provider, "time": elapsed, "error": str(e)}
+
+    return router

routes/skills_routes.py

@@ -1409,7 +1409,7 @@ def setup_skills_routes(skills_manager: SkillsManager) -> APIRouter:
 
         # Prefer the configured DEFAULT (→ Utility) model — not the current chat
         # session's model. Fall back to the caller's session model only if unset.
-        url, model, headers = resolve_endpoint("utility", owner=user)
+        url, model, headers = resolve_endpoint("default", owner=user)
         if not url or not model:
             url = url or ((body.get("endpoint_url") or "").strip() or None)
             model = model or ((body.get("model") or "").strip() or None)

services/memory/skill_format.py

@@ -50,7 +50,7 @@ import json
 import logging
 import re
 from dataclasses import dataclass, field
-from datetime import datetime, timezone
+from datetime import datetime
 from typing import Any, Dict, List, Optional
 
 logger = logging.getLogger(__name__)
@@ -441,4 +441,4 @@ class Skill:
 
 
 def _now_iso() -> str:
-    return datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
+    return datetime.utcnow().strftime("%Y-%m-%dT%H:%M:%SZ")

services/tts/tts_service.py

@@ -2,7 +2,6 @@
 """Multi-provider TTS service — dispatches to local Kokoro, OpenAI-compatible API, or browser."""
 
 import io
-import os
 import wave
 import logging
 import hashlib
@@ -42,11 +41,6 @@ class TTSService:
         self.cache_dir = Path(cache_dir)
         self.cache_dir.mkdir(parents=True, exist_ok=True)
         self._kokoro = None  # lazy-init
-        
-        try:
-            self.max_cache_bytes = int(os.getenv("ODYSSEUS_TTS_CACHE_MAX_BYTES", 500 * 1024 * 1024))
-        except ValueError:
-            self.max_cache_bytes = 500 * 1024 * 1024
 
     # ── Settings ──
 
@@ -95,53 +89,6 @@ class TTSService:
         ext = ".mp3" if (len(data) >= 3 and (data[:3] == b'ID3' or (data[0] == 0xff and (data[1] & 0xe0) == 0xe0))) else ".wav"
         (self.cache_dir / f"{key}{ext}").write_bytes(data)
 
-        self._enforce_cache_limit()
-
-    def _enforce_cache_limit(self):
-            """Evicts oldest files if the cache exceeds the configured byte limit."""
-            if self.max_cache_bytes <= 0:
-                return
-
-            try:
-                files = []
-                total_size = 0
-
-                # Safely scan files and sum sizes, ignoring files deleted mid-scan
-                for f in self.cache_dir.iterdir():
-                    try:
-                        if f.is_file() and f.suffix.lower() in (".mp3", ".wav"):
-                            files.append(f)
-                            total_size += f.stat().st_size
-                    except OSError:
-                        continue
-
-                if total_size > self.max_cache_bytes:
-                    logger.info(
-                        f"TTS cache ({total_size} bytes) exceeded limit ({self.max_cache_bytes} bytes). Evicting oldest files."
-                    )
-
-                    # Sort files by modification time (oldest first)
-                    try:
-                        files.sort(key=lambda f: f.stat().st_mtime)
-                    except OSError as e:
-                        logger.warning(f"Failed to sort cache files by mtime: {e}")
-
-                    # Trim down to 80% of max capacity
-                    target_size = self.max_cache_bytes * 0.8
-
-                    while files and total_size > target_size:
-                        f = files.pop(0)
-                        try:
-                            size = f.stat().st_size
-                            f.unlink()
-                            total_size -= size
-                        except OSError as e:
-                            logger.warning(f"Failed to evict cache file {f}: {e}")
-                            continue
-
-            except Exception as e:
-                logger.warning(f"Error enforcing TTS cache limit: {e}", exc_info=True)
-
     def clear_cache(self):
         count = 0
         for f in self.cache_dir.glob("*.*"):

src/agent_loop.py

@@ -12,7 +12,7 @@ import json
 import re
 import time
 import logging
-from typing import Any, AsyncGenerator, List, Dict, Optional, Set
+from typing import AsyncGenerator, List, Dict, Optional, Set
 from urllib.parse import urlparse
 
 from src.llm_core import (

src/llm_core.py

@@ -1237,27 +1237,15 @@ def _anthropic_rejects_temperature(model: str) -> bool:
         return False
     # `(?<![a-z])` anchors "opus" to a word boundary so a substring match like
     # `oct-opus`/`octopus-4-8` can't be read as Opus (it would otherwise strip
-    # temperature). Both version components are capped at 1-2 digits and forbid a
-    # trailing digit, so an 8-digit date can never be read as a version number:
-    # `claude-opus-4-20250514` (Opus 4.0) parses as major-only rather than reading
-    # `20250514` as a giant minor, and `claude-3-opus-20240229` (legacy Claude 3
-    # Opus, date directly after "opus-") fails to match at all rather than reading
-    # the date as a giant major. Dated 4.7+ snapshots (`claude-opus-4-7-20260201`)
-    # keep their explicit minor and are still matched.
-    #
-    # The minor is optional and a missing minor reads as `.0`, so major-only ids
-    # like `claude-opus-5` are correctly treated as >= 4.7 (issue #5753). Without
-    # this, every Opus 5 call kept `temperature` and failed with HTTP 400 — visible
-    # only on paths that pass a temperature, e.g. scheduled tasks inheriting
-    # `stream_agent_loop`'s 0.3 default, which returned empty responses.
-    match = re.search(
-        r"(?<![a-z])opus[-_]?(\d{1,2})(?!\d)(?:[-_.](\d{1,2})(?!\d))?", model.lower()
-    )
+    # temperature). Cap the minor at 1-2 digits and forbid a trailing digit so a
+    # dated id like `claude-opus-4-20250514` (Opus 4.0) parses as major-only (no
+    # minor match, kept) instead of reading the date `20250514` as a giant minor
+    # that would falsely test >= 4.7. Dated 4.7+ snapshots (`claude-opus-4-7-
+    # 20260201`) keep their explicit minor and are still matched.
+    match = re.search(r"(?<![a-z])opus[-_]?(\d+)[-_.](\d{1,2})(?!\d)", model.lower())
     if not match:
         return False
-    major = int(match.group(1))
-    minor = int(match.group(2)) if match.group(2) else 0
-    return (major, minor) >= (4, 7)
+    return (int(match.group(1)), int(match.group(2))) >= (4, 7)
 
 # Reasoning effort level sent to Mistral thinking-capable models. Mistral's
 # API accepts "high", "medium", "low", "none" — see

static/js/markdown.js

@@ -758,36 +758,30 @@ export function mdToHtml(src, opts) {
   // Remove empty paragraphs
   s = s.replace(/<p><\/p>/g, '');
 
-  // Every restore below passes a function replacer rather than the block string
-  // itself. With a string replacement, `String.replace` reads `$&`, `` $` ``,
-  // `$'` and `$$` in the *replacement* as substitution patterns, so a restored
-  // block containing them is corrupted: `$&` re-inserts the placeholder, `` $` ``
-  // and `$'` splice in the surrounding document, and `$$` collapses to `$`. Those
-  // sequences are ordinary content in fenced code (`perl -pe 's/x/$& y/'`,
-  // `echo "$$USD"`). A function replacer inserts its return value verbatim.
-
   // CRITICAL: Restore allowed HTML blocks first
   allowedHtmlBlocks.forEach((block, index) => {
-    s = s.replace(`___ALLOWED_HTML_${index}___`, () => block);
+    s = s.replace(`___ALLOWED_HTML_${index}___`, block);
   });
 
   // Restore math blocks
   mathBlocks.forEach((block, index) => {
-    s = s.replace(`___MATH_BLOCK_${index}___`, () => block);
+    s = s.replace(`___MATH_BLOCK_${index}___`, block);
   });
 
   // Restore mermaid diagram blocks
   mermaidBlocks.forEach((block, index) => {
-    s = s.replace(`___MERMAID_BLOCK_${index}___`, () => block);
+    s = s.replace(`___MERMAID_BLOCK_${index}___`, block);
   });
 
   // CRITICAL: Restore code blocks at the end
   codeBlocks.forEach((block, index) => {
-    s = s.replace(`___CODE_BLOCK_${index}___`, () => block);
+    s = s.replace(`___CODE_BLOCK_${index}___`, block);
   });
 
   // Restore inline code spans last, so placeholders carried inside restored
-  // <a>/allowed-HTML blocks are resolved too.
+  // <a>/allowed-HTML blocks are resolved too. The function replacer keeps the
+  // escaped code literal — e.g. a shell snippet like `echo $1` is not treated
+  // as a regex back-reference.
   inlineCodeBlocks.forEach((block, index) => {
     s = s.replace(`___INLINE_CODE_${index}___`, () => block);
   });

static/js/settings.js

@@ -3031,14 +3031,12 @@ async function initEmailAccountsSettings() {
       const body = {
         name: el('eaf-name').value.trim() || el('eaf-from').value.trim(),
         from_address: el('eaf-from').value.trim(),
-        display_name: el('eaf-display-name').value.trim(),
         imap_host: el('eaf-imap-host').value.trim(),
         imap_port: parseInt(el('eaf-imap-port').value) || 993,
         imap_user: el('eaf-imap-user').value.trim(),
         imap_starttls: el('eaf-imap-starttls').checked,
         smtp_host: el('eaf-smtp-host').value.trim(),
         smtp_port: parseInt(el('eaf-smtp-port').value) || 587,
-        smtp_security: el('eaf-smtp-security').value,
         smtp_user: el('eaf-imap-user').value.trim(),
       };
       if (!body.name) { el('eaf-msg').textContent = 'Enter a Name or Email first'; el('eaf-msg').style.color = 'var(--red)'; return; }
@@ -5790,30 +5788,29 @@ export function close() {
   window.history.replaceState(null, '', clean);
   const success = sp.has('email_oauth_success');
   const errMsg = sp.get('email_oauth_error') || '';
-  // Open settings → integrations once the document is ready. This module owns
-  // the open() API, so it does not need to wait for a window-level alias.
-  function _showResult() {
-    open('integrations');
-    // Brief toast-style banner.
-    const banner = document.createElement('div');
-    banner.textContent = success
-      ? 'Google account connected — email is ready'
-      : `Google OAuth failed: ${errMsg || 'unknown error'}`;
-    Object.assign(banner.style, {
-      position: 'fixed', bottom: '24px', left: '50%', transform: 'translateX(-50%)',
-      background: success ? 'var(--accent, #50fa7b)' : 'var(--red, #ff5555)',
-      color: '#000', padding: '8px 18px', borderRadius: '6px', fontSize: '12px',
-      fontWeight: '600', zIndex: '99999', pointerEvents: 'none',
-      boxShadow: '0 2px 12px rgba(0,0,0,0.3)',
-    });
-    document.body.appendChild(banner);
-    setTimeout(() => banner.remove(), 4000);
-  }
-  if (document.readyState === 'loading') {
-    document.addEventListener('DOMContentLoaded', _showResult, { once: true });
-  } else {
-    _showResult();
+  // Open settings → integrations after the app has initialised.
+  function _tryOpen() {
+    if (window.settingsModule && typeof window.settingsModule.open === 'function') {
+      window.settingsModule.open('integrations');
+      // Brief toast-style banner.
+      const banner = document.createElement('div');
+      banner.textContent = success
+        ? '✓ Google account connected — email is ready'
+        : `Google OAuth failed: ${errMsg || 'unknown error'}`;
+      Object.assign(banner.style, {
+        position: 'fixed', bottom: '24px', left: '50%', transform: 'translateX(-50%)',
+        background: success ? 'var(--accent, #50fa7b)' : 'var(--red, #ff5555)',
+        color: '#000', padding: '8px 18px', borderRadius: '6px', fontSize: '12px',
+        fontWeight: '600', zIndex: '99999', pointerEvents: 'none',
+        boxShadow: '0 2px 12px rgba(0,0,0,0.3)',
+      });
+      document.body.appendChild(banner);
+      setTimeout(() => banner.remove(), 4000);
+    } else {
+      setTimeout(_tryOpen, 100);
+    }
   }
+  _tryOpen();
 })();
 
 const settingsModule = { open, close, initIntegrations, initUnifiedIntegrations, syncAdminVisibility, refreshAiModelEndpoints };

tests/test_email_oauth_connect_smtp_security.py

@@ -1,15 +0,0 @@
-"""Regression coverage for SMTP security saved before Google OAuth."""
-
-from pathlib import Path
-
-
-_REPO = Path(__file__).resolve().parents[1]
-
-
-def test_email_tab_oauth_connect_persists_selected_smtp_security():
-    source = (_REPO / "static" / "js" / "settings.js").read_text(encoding="utf-8")
-    start = source.index("el('eaf-oauth-btn').addEventListener")
-    handler_body = source[start:source.index("if (!body.name)", start)]
-
-    assert "smtp_security: el('eaf-smtp-security').value" in handler_body
-    assert "display_name: el('eaf-display-name').value.trim()" in handler_body

tests/test_email_oauth_settings_redirect.py

@@ -1,19 +0,0 @@
-"""Regression coverage for the settings UI after Google OAuth redirects."""
-
-from pathlib import Path
-
-
-_REPO = Path(__file__).resolve().parents[1]
-
-
-def test_oauth_redirect_uses_the_module_local_settings_api():
-    source = (_REPO / "static" / "js" / "settings.js").read_text(encoding="utf-8")
-    handler = source[
-        source.index("(function _handleOauthRedirect"):
-        source.index("const settingsModule =")
-    ]
-
-    assert "open('integrations');" in handler
-    assert "window.settingsModule" not in handler
-    assert "window.__odysseusAppStarted" not in handler
-    assert "document.addEventListener('DOMContentLoaded', _showResult, { once: true })" in handler

tests/test_issue_description_check.py

@@ -1,86 +0,0 @@
-"""Regression coverage for issue-description label lifecycle events."""
-
-import json
-import shutil
-import subprocess
-from pathlib import Path
-
-import pytest
-
-
-_REPO = Path(__file__).resolve().parent.parent
-_CHECKER = _REPO / ".github" / "scripts" / "check-issue-description.js"
-_WORKFLOW = _REPO / ".github" / "workflows" / "issue-description-check.yml"
-pytestmark = pytest.mark.skipif(not shutil.which("node"), reason="node not on PATH")
-
-
-def _run_closed_issue(action):
-    harness = r"""
-const checkIssueDescription = require(process.argv[1]);
-const action = process.argv[2];
-const calls = [];
-const unexpected = (name) => async () => {
-  throw new Error(`${name} should not be called for a closed issue`);
-};
-
-const github = {
-  rest: {
-    issues: {
-      removeLabel: async (params) => calls.push({ method: 'removeLabel', params }),
-      getLabel: unexpected('getLabel'),
-      addLabels: unexpected('addLabels'),
-      listComments: unexpected('listComments'),
-      createComment: unexpected('createComment'),
-      updateComment: unexpected('updateComment'),
-      deleteComment: unexpected('deleteComment'),
-    },
-  },
-};
-const context = {
-  payload: {
-    action,
-    issue: { number: 42, state: 'closed', body: '', labels: [] },
-  },
-  repo: { owner: 'odysseus-dev', repo: 'odysseus' },
-};
-const core = {
-  warning: unexpected('core.warning'),
-  setFailed: unexpected('core.setFailed'),
-};
-
-checkIssueDescription({ github, context, core })
-  .then(() => process.stdout.write(JSON.stringify(calls)))
-  .catch((error) => {
-    console.error(error);
-    process.exitCode = 1;
-  });
-"""
-    proc = subprocess.run(
-        ["node", "-e", harness, str(_CHECKER), action],
-        capture_output=True,
-        text=True,
-        cwd=str(_REPO),
-        timeout=30,
-    )
-    assert proc.returncode == 0, proc.stderr
-    return json.loads(proc.stdout)
-
-
-def test_workflow_handles_issue_closures():
-    workflow = _WORKFLOW.read_text()
-    assert "types: [opened, edited, reopened, closed]" in workflow
-
-
-@pytest.mark.parametrize("action", ["closed", "edited"])
-def test_closed_issue_only_drops_ready_for_review(action):
-    assert _run_closed_issue(action) == [
-        {
-            "method": "removeLabel",
-            "params": {
-                "owner": "odysseus-dev",
-                "repo": "odysseus",
-                "issue_number": 42,
-                "name": "ready for review",
-            },
-        }
-    ]

tests/test_llm_core_anthropic_temp_omit.py

@@ -29,13 +29,6 @@ from src.llm_core import _anthropic_rejects_temperature, _build_anthropic_payloa
         "anthropic/claude-opus-4-7",  # tolerate a provider-prefixed id
         "claude-opus-4-10",  # future minor still >= 4.7
         "claude-opus-5-0",  # future major
-        # Major-only ids: a missing minor reads as `.0`, so these are >= 4.7 too
-        # (issue #5753). Before the fix the version pattern required a minor, so
-        # these fell through to "accepts temperature" and every call 400'd.
-        "claude-opus-5",
-        "claude-opus-5-20260101",  # major-only + dated snapshot
-        "anthropic/claude-opus-5",  # major-only behind a provider prefix
-        "claude-opus-6",  # future major-only
     ],
 )
 def test_opus_47_plus_rejects_temperature(model):
@@ -55,10 +48,7 @@ def test_opus_47_plus_rejects_temperature(model):
         "claude-opus-4-6-20251201",  # dated 4.6 snapshot — older, still keeps temperature
         "claude-sonnet-4-6",
         "claude-3-5-sonnet",
-        "claude-3-opus-20240229",  # legacy Claude 3 Opus — date directly after
-        # "opus-", so the major must not swallow it as version 20240229 (that is
-        # what makes capping the major at 1-2 digits necessary once the minor
-        # became optional in #5753).
+        "claude-3-opus-20240229",  # legacy Claude 3 Opus — no opus-N-M pattern, kept
         "claude-haiku-4-5",
         "claude-x",
         "octopus-4-8",  # "opus" only as a substring of another word — must not match
@@ -97,20 +87,6 @@ def test_payload_keeps_temperature_for_older_models():
     assert _payload("claude-3-5-sonnet", 1.2)["temperature"] == 1.0
 
 
-def test_payload_omits_temperature_for_major_only_opus_5():
-    # Issue #5753: the scheduled-task path calls stream_agent_loop() without a
-    # temperature and inherits its 0.3 default, so `claude-opus-5` 400'd on every
-    # run and surfaced as "the model returned an empty response". Interactive chat
-    # leaves temperature None and never hit it.
-    assert "temperature" not in _payload("claude-opus-5", 0.3)
-
-
-def test_payload_keeps_temperature_for_legacy_claude_3_opus():
-    # Guards the major-digit cap: `opus-20240229` must not parse as version
-    # 20240229, or Claude 3 Opus would silently lose the caller's temperature.
-    assert _payload("claude-3-opus-20240229", 0.5)["temperature"] == 0.5
-
-
 def test_payload_keeps_temperature_for_dated_opus_4_0():
     # Anthropic's dated id for Opus 4.0 (claude-opus-4-20250514) is in this repo's
     # ANTHROPIC_MODELS list. The date must not be misread as a >= 4.7 minor, or the

tests/test_markdown_rendering_js.py

@@ -214,50 +214,6 @@ def test_inline_code_content_is_html_escaped(node_available):
     assert "<b>" not in html
 
 
-def test_fenced_code_keeps_dollar_ampersand(node_available):
-    # Issue #5663: the block-restore pass used a string replacement, so `$&` in a
-    # restored block was read as "the matched text" and re-inserted the
-    # placeholder. `perl -pe 's/world/$& again/'` rendered as
-    # "s/world/___CODE_BLOCK_0___amp; again/" — the trailing "amp;" is the orphan
-    # left behind after `$&` consumed the `$&` of the escaped `$&amp;`.
-    html = _run_markdown_case(
-        "```sh\necho \"hello world\" | perl -pe 's/world/$& again/'\n```"
-    )
-
-    assert "___CODE_BLOCK_" not in html
-    assert "s/world/$&amp; again/" in html
-    assert "amp; again" not in html.replace("$&amp; again", "")
-
-
-def test_fenced_code_keeps_dollar_backtick_and_quote(node_available):
-    # `` $` `` and `$'` splice the text before/after the placeholder into the
-    # block. Unlike `$&` these leave no placeholder behind — the characters just
-    # vanish — so assert the content survives verbatim.
-    html = _run_markdown_case("```sh\nsed \"s/$`/x/\" && sed \"s/$'/y/\"\n```")
-
-    assert "___CODE_BLOCK_" not in html
-    assert "s/$`/x/" in html
-    assert "s/$&#39;/y/" in html
-
-
-def test_fenced_code_keeps_double_dollar(node_available):
-    # `$$` collapsed to a single `$` in the restored block.
-    html = _run_markdown_case('```sh\necho "$$USD and $$"\n```')
-
-    assert "$$USD and $$" in html
-
-
-def test_mermaid_block_keeps_dollar_ampersand(node_available):
-    # The mermaid restore site had the same hazard: a node label containing `$&`
-    # re-inserted the ___MERMAID_BLOCK_n___ placeholder into the diagram source,
-    # which then fails to parse. The math and allowed-HTML sites are fixed the
-    # same way; they need KaTeX/sanitizer conditions this harness doesn't set up.
-    html = _run_markdown_case('```mermaid\ngraph TD; A["$&"] --> B;\n```')
-
-    assert "___MERMAID_BLOCK_" not in html
-    assert "$&amp;" in html
-
-
 def test_currency_dollar_amounts_are_not_rendered_as_math(node_available):
     # "$5 to $10" used to pair the two dollar signs as inline-math delimiters
     # and render "5 to" through KaTeX. Pandoc-style rules now reject it: the

tests/test_mcp_dependency_compatibility.py

@@ -1,15 +0,0 @@
-"""Regression coverage for the built-in MCP servers' SDK compatibility line."""
-
-from pathlib import Path
-
-
-REQUIREMENTS = Path(__file__).resolve().parents[1] / "requirements.txt"
-
-
-def test_mcp_requirement_excludes_breaking_v2_sdk():
-    requirements = [
-        line.split("#", 1)[0].strip().replace(" ", "")
-        for line in REQUIREMENTS.read_text(encoding="utf-8").splitlines()
-    ]
-
-    assert "mcp<2" in requirements

tests/test_search_routes_shim.py

@@ -1,11 +0,0 @@
-"""Regression test for the search route shim (slice 2j, #4082/#4071)."""
-
-import importlib
-
-import routes.search_routes as _shim_search  # noqa: F401
-
-
-def test_legacy_and_canonical_search_module_are_same_object():
-    legacy = importlib.import_module("routes.search_routes")
-    canonical = importlib.import_module("routes.search.search_routes")
-    assert legacy is canonical

tests/test_skill_format_timestamp.py

@@ -1,58 +0,0 @@
-"""Regression for issue #5697 — skill timestamps must not use ``datetime.utcnow()``.
-
-``_now_iso()`` builds the ``created`` value in skill frontmatter. ``utcnow()``
-returns a *naive* datetime and has been deprecated since Python 3.12, scheduled
-for removal. The replacement must stay timezone-aware while keeping the
-serialized ``YYYY-MM-DDTHH:MM:SSZ`` shape, so skill files written by older
-versions keep parsing.
-
-The UTC check matters on its own: a bare ``datetime.now()`` also produces the
-right shape, but emits local wall time, which would silently backdate or
-postdate skills for every user outside UTC.
-"""
-
-import os
-import re
-import time
-import warnings
-from datetime import datetime, timezone
-
-import pytest
-
-from services.memory.skill_format import _now_iso
-
-_ISO_Z = re.compile(r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$")
-
-
-def test_now_iso_keeps_serialized_shape():
-    assert _ISO_Z.match(_now_iso())
-
-
-def test_now_iso_emits_no_deprecation_warning():
-    with warnings.catch_warnings(record=True) as caught:
-        warnings.simplefilter("always")
-        _now_iso()
-    assert not [w for w in caught if issubclass(w.category, DeprecationWarning)]
-
-
-@pytest.mark.skipif(
-    not hasattr(time, "tzset"),
-    reason="time.tzset is unavailable on this platform",
-)
-def test_now_iso_is_utc_not_local_time():
-    """Pin UTC under a non-UTC local timezone, where the two visibly diverge."""
-    original_tz = os.environ.get("TZ")
-    os.environ["TZ"] = "Asia/Amman"  # UTC+3, never UTC
-    time.tzset()
-    try:
-        emitted = datetime.strptime(_now_iso(), "%Y-%m-%dT%H:%M:%SZ").replace(
-            tzinfo=timezone.utc
-        )
-        drift = abs((emitted - datetime.now(timezone.utc)).total_seconds())
-        assert drift < 60, f"timestamp is {drift}s off UTC — local time leaked in"
-    finally:
-        if original_tz is None:
-            os.environ.pop("TZ", None)
-        else:
-            os.environ["TZ"] = original_tz
-        time.tzset()

tests/test_tts_service_enforce_cache_limit.py

@@ -1,97 +0,0 @@
-import os
-import time
-from pathlib import Path
-import pytest
-
-# Adjust the import path if your file is directly in ./services instead of ./services/tts
-from services.tts.tts_service import TTSService
-
-def test_cache_under_limit(tmp_path, monkeypatch):
-    """Test that writing a file under the size limit does not trigger eviction."""
-    # Set a tiny limit: 100 bytes
-    monkeypatch.setenv("ODYSSEUS_TTS_CACHE_MAX_BYTES", "100")
-    
-    # Initialize service with pytest's temporary directory
-    service = TTSService(cache_dir=str(tmp_path))
-    
-    # Write a 40-byte file (under the 100-byte limit)
-    service._put_cache("test_key", b"x" * 40)
-    
-    # Verify the file was written and nothing was deleted
-    files = list(tmp_path.glob("*.*"))
-    assert len(files) == 1
-    assert sum(f.stat().st_size for f in files) == 40
-
-def test_cache_exceeds_limit_triggers_eviction(tmp_path, monkeypatch):
-    """Test that exceeding the limit evicts the oldest files down to 80% capacity."""
-    # Set limit to 100 bytes. 80% target capacity will be 80 bytes.
-    monkeypatch.setenv("ODYSSEUS_TTS_CACHE_MAX_BYTES", "100")
-    service = TTSService(cache_dir=str(tmp_path))
-    
-    # 1. Setup: Manually create two older files (40 bytes each)
-    file1 = tmp_path / "oldest.wav"
-    file2 = tmp_path / "middle.wav"
-    
-    file1.write_bytes(b"a" * 40)
-    file2.write_bytes(b"b" * 40)
-    
-    # Spoof timestamps so file1 is explicitly older than file2
-    now = time.time()
-    os.utime(file1, (now - 100, now - 100)) # 100 seconds ago
-    os.utime(file2, (now - 50, now - 50))   # 50 seconds ago
-    
-    # 2. Action: Write a 3rd file using the service method (40 bytes)
-    # Total cache is now 120 bytes, which exceeds 100.
-    # It should delete oldest (file1) to drop to 80 bytes (which matches the 80% target).
-    service._put_cache("newest", b"c" * 40)
-    
-    # 3. Assertions
-    # The newest file should exist (saved as .wav because it lacks MP3 magic bytes)
-    newest_file = tmp_path / "newest.wav"
-    
-    assert not file1.exists(), "The oldest file should have been evicted."
-    assert file2.exists(), "The middle file should still exist."
-    assert newest_file.exists(), "The newest file should have been saved."
-    
-    # Verify the final directory size is <= 80 bytes
-    total_size = sum(f.stat().st_size for f in tmp_path.glob("*.*"))
-    assert total_size <= 80
-
-def test_cache_limit_disabled(tmp_path, monkeypatch):
-    """Test that setting max bytes to 0 disables eviction."""
-    monkeypatch.setenv("ODYSSEUS_TTS_CACHE_MAX_BYTES", "0")
-    service = TTSService(cache_dir=str(tmp_path))
-    
-    # Write 3 large files that would normally trigger eviction
-    service._put_cache("file1", b"x" * 1000)
-    service._put_cache("file2", b"x" * 1000)
-    service._put_cache("file3", b"x" * 1000)
-    
-    # Ensure nothing was deleted
-    files = list(tmp_path.glob("*.*"))
-    assert len(files) == 3
-    assert sum(f.stat().st_size for f in files) == 3000
-
-def test_cache_eviction_handles_unlink_error_gracefully(tmp_path, monkeypatch):
-    """Test that if unlinking a file fails, _put_cache still succeeds without raising."""
-    service = TTSService(cache_dir=str(tmp_path))
-    service.max_cache_bytes = 50
-
-    # Create a file to evict
-    old_file = tmp_path / "old.wav"
-    old_file.write_bytes(b"x" * 40)
-
-    # Monkeypatch unlink on Path objects to simulate a PermissionError / file-lock failure
-    def mock_unlink(self_path):
-        raise OSError("Permission denied / file locked")
-
-    monkeypatch.setattr(Path, "unlink", mock_unlink)
-
-    # Writing a new file triggers eviction which encounters the mocked unlink error
-    try:
-        service._put_cache("new_key", b"y" * 40)
-    except Exception as e:
-        pytest.fail(f"_put_cache raised an exception during failed eviction: {e}")
-
-    # The new file should still be written successfully
-    assert (tmp_path / "new_key.wav").exists()