mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-06-16 01:35:36 -04:00
Kenny Van de Maele
8ce945d338
* feat: Add plan mode to the chat agent
Adds a plan mode: the agent investigates read-only, proposes a checklist, and
waits for approval before changing anything. On approval it runs with full
tools and checks items off as it goes. Enforcement reuses the existing
disabled_tools gate.
Includes a slash command: `/plan [on|off]` (and `/toggle plan`) to flip the
plan toggle from the chat input.
- src/tool_security.py, src/mcp_manager.py: read-only allowlist (tools + MCP).
- src/agent_loop.py, routes/chat_routes.py: union the disabled set, prepend the
plan directive, force agent mode.
- static/: plan toggle pill, Approve & Run, dockable plan window, task-list
checkboxes, and the /plan slash command.
- tests/test_plan_mode.py.
* Plan mode: persistent re-referenceable plan + agent write-back
Three improvements so a long plan survives a weak model and stays in reach:
1. Re-reference the plan (out-of-context fix). On the execution turn the frontend
sends the approved checklist back (`approved_plan`); the backend pins it as a
top-of-context `## ACTIVE PLAN` system note (kept by the context trimmer), so
the agent can always re-read the plan instead of losing the thread on a long
run. New `build_active_plan_note()` (unit-tested).
2. Re-open / dock the plan anytime. The plan checklist is stored per-session
(localStorage). When a plan exists, the plan-mode button opens a small menu
("Show plan" / "Plan mode: On/Off") that re-opens the side-dockable plan
window — so it can stay docked while the agent works. The window live-refreshes
as the plan changes.
3. Agent write-back: new `update_plan` tool. The agent calls it to tick steps
`- [x]` after finishing them, or to revise steps when the user asks. Marker
tool (no I/O) → `plan_update` SSE event → the stored plan + docked window
update live. The ACTIVE PLAN note instructs the agent to use it.
Backend: src/agent_loop.py (param + pin + note builder + emit + prompt blurb),
src/tool_execution.py (update_plan handler), routes/chat_routes.py (parse
`approved_plan`, relay `plan_update`), registration in tool_schemas / agent_tools
/ tool_index (always-available, not admin-gated).
Frontend: static/js/chat.js (plan store, send `approved_plan`, handle
`plan_update`, capture restated checklists), static/app.js (plan-button menu),
static/js/planWindow.js (`isPlanWindowOpen`), static/js/storage.js (PLAN key).
Tests: tests/test_plan_mode.py (plan-note), tests/test_update_plan_tool.py.
* Plan mode: drop bash/python, rely on read-only discovery tools
Shell can mutate (write files, hit the network) and can't be constrained to
read-only at the tool layer, so plan mode no longer relies on a prompt to keep
it well-behaved — bash/python are removed from the read-only allowlist and added
to the fail-closed block set. Discovery is covered by the dedicated read-only
tools (read_file, grep, glob, ls) instead.
Rewrites the plan-mode directive to state shell is disabled and lists the
available read-only tools positively. Addresses review feedback on #638.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* Comment: note _MCP_READONLY_VERBS are prefixes not whole words
Clarifies that entries like "summar" are intentional stems matched via
startswith (covers summarise/summarize/summary), not typos. Addresses review
feedback on #638.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* Plan mode: clarify why gating inverts the allowlist into a denylist
Rename _PLAN_MODE_FALLBACK_BLOCK -> _PLAN_MODE_KNOWN_MUTATORS and rewrite the
comments. The tool gate is a denylist (disabled_tools); plan mode's policy is an
allowlist, so it returns the inverse (all known tool names minus the allowlist).
The static mutator set is a backstop for the schema-derived name list, which
misses XML-only tools and can fail to import. Addresses review feedback on #638.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* Plan mode: stop hardcoding the read-only tool list in the directive
The model is already shown its available (read-only) tools by _assemble_prompt,
which removes every disabled tool. Enumerating them again in the directive only
duplicated that list and would drift as tools change. Point at the tools listed
below instead. Addresses review feedback on #638.
80 lines
3.5 KiB
JavaScript
80 lines
3.5 KiB
JavaScript
// static/js/planWindow.js
|
|
//
|
|
// Plan mode: show a proposed plan in a draggable, side-dockable window —
|
|
// reusing the same modal + makeWindowDraggable framework the calendar, email,
|
|
// and document panels use. Approving from here runs the plan with full tools.
|
|
|
|
import uiModule from './ui.js';
|
|
import markdownModule from './markdown.js';
|
|
import { makeWindowDraggable } from './windowDrag.js';
|
|
|
|
let _modal = null;
|
|
let _onApprove = null;
|
|
|
|
function _getModal() {
|
|
if (_modal) return _modal;
|
|
_modal = document.createElement('div');
|
|
_modal.id = 'plan-window';
|
|
_modal.className = 'modal';
|
|
_modal.style.display = 'none';
|
|
_modal.innerHTML = `
|
|
<div class="modal-content plan-window-content">
|
|
<div class="modal-header">
|
|
<h4><svg width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" style="vertical-align:-2px;margin-right:6px"><path d="M9 11l3 3L22 4"/><path d="M21 12v7a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h11"/></svg><span id="plan-window-title">Proposed plan</span></h4>
|
|
<button class="close-btn" id="plan-window-close">✖</button>
|
|
</div>
|
|
<div class="modal-body plan-window-body" id="plan-window-body"></div>
|
|
<div class="modal-footer plan-window-footer">
|
|
<button type="button" class="plan-approve-btn" id="plan-window-approve">Approve & Run</button>
|
|
</div>
|
|
</div>`;
|
|
document.body.appendChild(_modal);
|
|
_modal.querySelector('#plan-window-close').addEventListener('click', closePlanWindow);
|
|
_modal.querySelector('#plan-window-approve').addEventListener('click', () => {
|
|
const cb = _onApprove;
|
|
closePlanWindow();
|
|
if (typeof cb === 'function') cb();
|
|
});
|
|
// Draggable + side-dockable, same one-call helper as the other windows.
|
|
const content = _modal.querySelector('.modal-content');
|
|
const header = _modal.querySelector('.modal-header');
|
|
if (content && header) makeWindowDraggable(_modal, { content, header });
|
|
return _modal;
|
|
}
|
|
|
|
/**
|
|
* Open the plan window with rendered markdown and an approve callback.
|
|
* @param {string} planMarkdown - the agent's proposed plan (raw markdown)
|
|
* @param {Function} onApprove - called when the user clicks Approve & Run
|
|
*/
|
|
export function openPlanWindow(planMarkdown, onApprove) {
|
|
const modal = _getModal();
|
|
_onApprove = onApprove || null;
|
|
const body = modal.querySelector('#plan-window-body');
|
|
if (body) {
|
|
body.innerHTML = markdownModule.processWithThinking(
|
|
markdownModule.squashOutsideCode(planMarkdown || '')
|
|
);
|
|
if (window.hljs) body.querySelectorAll('pre code').forEach((b) => window.hljs.highlightElement(b));
|
|
}
|
|
const approveBtn = modal.querySelector('#plan-window-approve');
|
|
if (approveBtn) approveBtn.style.display = onApprove ? '' : 'none';
|
|
// Title reflects state: still awaiting approval (approve callback present) vs
|
|
// already approved and being executed.
|
|
const title = modal.querySelector('#plan-window-title');
|
|
if (title) title.textContent = onApprove ? 'Proposed plan' : 'Approved plan';
|
|
modal.style.display = 'flex';
|
|
if (uiModule && uiModule.scrollHistory) { try { uiModule.scrollHistory(); } catch (_) {} }
|
|
}
|
|
|
|
export function closePlanWindow() {
|
|
if (_modal) _modal.style.display = 'none';
|
|
}
|
|
|
|
/** True when the plan window is currently visible (for live-refresh on progress). */
|
|
export function isPlanWindowOpen() {
|
|
return !!(_modal && _modal.style.display !== 'none');
|
|
}
|
|
|
|
export default { openPlanWindow, closePlanWindow, isPlanWindowOpen };
|