Set bounds after adding BrowserView

Otherwise apparently the view won't display.
This commit is contained in:
Max Goodhart
2020-11-11 23:54:49 -08:00
parent c1b9d46fa7
commit 9ba7dc564b

View File

@@ -100,18 +100,17 @@ export default class StreamWindow extends EventEmitter {
this.viewActions = {
offscreenView: (context, event) => {
const { view } = context
view.setBounds({ x: 0, y: 0, width, height })
// It appears necessary to initialize the browser view by adding it to a window and setting bounds. Otherwise, some streaming sites like Periscope will not load their videos due to RAFs not firing.
win.removeBrowserView(view)
offscreenWin.addBrowserView(view)
view.setBounds({ x: 0, y: 0, width, height })
},
positionView: (context, event) => {
const { pos, view } = context
view.setBounds(pos)
offscreenWin.removeBrowserView(view)
win.addBrowserView(view)
view.setBounds(pos)
// It's necessary to remove and re-add the overlay view to ensure it's on top.
win.removeBrowserView(overlayView)